FilterTest::filterDataProvider() - Code Metrics - Inspection of "Include only src in scrutinizer" - yiisoft/data - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 019716...f69765 )

by Alexander

created 2020-05-15 23:03 UTC

FilterTest::filterDataProvider() B

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	129
Code Lines	74

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
eloc	74
c	3
b	0
f	1
dl	0
loc	129
rs	8.5672
cc	1
nc	1
nop	0

How to fix Long Method

<?php

declare(strict_types=1);

namespace Yiisoft\Data\Tests\Reader;

use Yiisoft\Data\Reader\Filter\All;
use Yiisoft\Data\Reader\Filter\Any;
use Yiisoft\Data\Reader\Filter\FilterInterface;
use Yiisoft\Data\Reader\Filter\Equals;
use Yiisoft\Data\Reader\Filter\GreaterThan;
use Yiisoft\Data\Reader\Filter\GreaterThanOrEqual;
use Yiisoft\Data\Reader\Filter\In;
use Yiisoft\Data\Reader\Filter\LessThan;
use Yiisoft\Data\Reader\Filter\LessThanOrEqual;
use Yiisoft\Data\Reader\Filter\Like;
use Yiisoft\Data\Reader\Filter\Not;
use Yiisoft\Data\Tests\TestCase;

final class FilterTest extends TestCase
{
    public function filterDataProvider(): array
    {
        return [
            'Equals' => [
                new Equals('test', 42),
                ['=', 'test', 42],
            ],
            'In' => [
                new In('test', [1, 2, 3]),
                ['in', 'test', [1, 2, 3]],
            ],
            'GreaterThan' => [
                new GreaterThan('test', 42),
                ['>', 'test', 42],
            ],
            'GreaterThanOrEqual' => [
                new GreaterThanOrEqual('test', 42),
                ['>=', 'test', 42],
            ],
            'LessThan' => [
                new LessThan('test', 42),
                ['<', 'test', 42],
            ],
            'LessThanOrEqual' => [
                new LessThanOrEqual('test', 42),
                ['<=', 'test', 42],
            ],
            'Like' => [
                new Like('test', '42'),
                ['like', 'test', '42'],
            ],
            'Not' => [
                new Not(new Equals('test', 42)),
                ['not', ['=', 'test', 42]],
            ],
            'Any' => [
                new Any(
                    new Equals('test', 1),
                    new Equals('test', 2)
                ),
                ['or', [
                    ['=', 'test', 1],
                    ['=', 'test', 2],
                ]]
            ],
            'All' => [
                new All(
                    new LessThan('test', 3),
                    new GreaterThan('test', 2)
                ),
                ['and', [
                    ['<', 'test', 3],
                    ['>', 'test', 2],
                ]]
            ],
            'NestedGroup' => [
                new All(
                    new Equals('test', 42),
                    new Any(
                        new Equals('test', 1),
                        new Equals('test', 2)
                    )
                ),
                [
                    'and',
                    [
                        ['=', 'test', 42],
                        [
                            'or',
                            [
                                ['=', 'test', 1],
                                ['=', 'test', 2],
                            ]
                        ]
                    ]
                ]
            ],
            'withFiltersArrayAll' => [
                (new All())->withFiltersArray([
                    ['<', 'test', 3],
                ]),
                [
                    'and',
                    [
                        ['<', 'test', 3],
                    ],
                ]
            ],
            'withFiltersArrayAny' => [
                (new Any())->withFiltersArray([
                    ['<', 'test1', 3],
                    new Equals('test2', 33),
                ]),
                [
                    'or',
                    [
                        ['<', 'test1', 3],
                        ['=', 'test2', 33],
                    ],
                ],
            ],
            'withFiltersArrayNestedGroup' => [
                (new All())->withFiltersArray([
                    ['<', 'test', 3],
                    [
                        'and',
                        [
                            ['>', 'test2', 99],
                        ]
                    ],
                ]),
                [
                    'and',
                    [
                        ['<', 'test', 3],
                        [
                            'and',
                            [
                                ['>', 'test2', 99],
                            ],
                        ],
                    ],
                ],
            ],
            'withFiltersArrayEmpty' => [
                (new All())->withFiltersArray([]),
                [
                    'and',
                    [],
                ],
            ]
        ];
    }

    /**
     * @dataProvider filterDataProvider
     */
    public function testFilter(FilterInterface $filter, array $filterArray): void
    {
        $this->assertSame($filterArray, $filter->toArray());
    }

    /**
     * @dataProvider arrayFailDataProvider
     */
    public function testWithFiltersArrayFail(array $filtersArray): void
    {
        $this->expectException(\InvalidArgumentException::class);
        (new All())->withFiltersArray($filtersArray);
    }

    public function arrayFailDataProvider(): array
    {
        return [
            'filterIsNotArray' => [
                ['test'],
            ],
            'emptyFilterArray' => [
                [[]],
            ],
            'operatorFailInvalidType' => [
                [[false]],
            ],
            'operatorFailWithEmptyString' => [
                [['']],
            ],
        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yiisoft\Data\Tests\Reader;
6
7			use Yiisoft\Data\Reader\Filter\All;
8			use Yiisoft\Data\Reader\Filter\Any;
9			use Yiisoft\Data\Reader\Filter\FilterInterface;
10			use Yiisoft\Data\Reader\Filter\Equals;
11			use Yiisoft\Data\Reader\Filter\GreaterThan;
12			use Yiisoft\Data\Reader\Filter\GreaterThanOrEqual;
13			use Yiisoft\Data\Reader\Filter\In;
14			use Yiisoft\Data\Reader\Filter\LessThan;
15			use Yiisoft\Data\Reader\Filter\LessThanOrEqual;
16			use Yiisoft\Data\Reader\Filter\Like;
17			use Yiisoft\Data\Reader\Filter\Not;
18			use Yiisoft\Data\Tests\TestCase;
19
20			final class FilterTest extends TestCase
21			{
22			public function filterDataProvider(): array
23			{
24			return [
25			'Equals' => [
26			new Equals('test', 42),
27			['=', 'test', 42],
28			],
29			'In' => [
30			new In('test', [1, 2, 3]),
31			['in', 'test', [1, 2, 3]],
32			],
33			'GreaterThan' => [
34			new GreaterThan('test', 42),
35			['>', 'test', 42],
36			],
37			'GreaterThanOrEqual' => [
38			new GreaterThanOrEqual('test', 42),
39			['>=', 'test', 42],
40			],
41			'LessThan' => [
42			new LessThan('test', 42),
43			['<', 'test', 42],
44			],
45			'LessThanOrEqual' => [
46			new LessThanOrEqual('test', 42),
47			['<=', 'test', 42],
48			],
49			'Like' => [
50			new Like('test', '42'),
51			['like', 'test', '42'],
52			],
53			'Not' => [
54			new Not(new Equals('test', 42)),
55			['not', ['=', 'test', 42]],
56			],
57			'Any' => [
58			new Any(
59			new Equals('test', 1),
60			new Equals('test', 2)
61			),
62			['or', [
63			['=', 'test', 1],
64			['=', 'test', 2],
65			]]
66			],
67			'All' => [
68			new All(
69			new LessThan('test', 3),
70			new GreaterThan('test', 2)
71			),
72			['and', [
73			['<', 'test', 3],
74			['>', 'test', 2],
75			]]
76			],
77			'NestedGroup' => [
78			new All(
79			new Equals('test', 42),
80			new Any(
81			new Equals('test', 1),
82			new Equals('test', 2)
83			)
84			),
85			[
86			'and',
87			[
88			['=', 'test', 42],
89			[
90			'or',
91			[
92			['=', 'test', 1],
93			['=', 'test', 2],
94			]
95			]
96			]
97			]
98			],
99			'withFiltersArrayAll' => [
100			(new All())->withFiltersArray([
101			['<', 'test', 3],
102			]),
103			[
104			'and',
105			[
106			['<', 'test', 3],
107			],
108			]
109			],
110			'withFiltersArrayAny' => [
111			(new Any())->withFiltersArray([
112			['<', 'test1', 3],
113			new Equals('test2', 33),
114			]),
115			[
116			'or',
117			[
118			['<', 'test1', 3],
119			['=', 'test2', 33],
120			],
121			],
122			],
123			'withFiltersArrayNestedGroup' => [
124			(new All())->withFiltersArray([
125			['<', 'test', 3],
126			[
127			'and',
128			[
129			['>', 'test2', 99],
130			]
131			],
132			]),
133			[
134			'and',
135			[
136			['<', 'test', 3],
137			[
138			'and',
139			[
140			['>', 'test2', 99],
141			],
142			],
143			],
144			],
145			],
146			'withFiltersArrayEmpty' => [
147			(new All())->withFiltersArray([]),
148			[
149			'and',
150			[],
151			],
152			]
153			];
154			}
155
156			/**
157			* @dataProvider filterDataProvider
158			*/
159			public function testFilter(FilterInterface $filter, array $filterArray): void
160			{
161			$this->assertSame($filterArray, $filter->toArray());
162			}
163
164			/**
165			* @dataProvider arrayFailDataProvider
166			*/
167			public function testWithFiltersArrayFail(array $filtersArray): void
168			{
169			$this->expectException(\InvalidArgumentException::class);
170			(new All())->withFiltersArray($filtersArray);
171			}
172
173			public function arrayFailDataProvider(): array
174			{
175			return [
176			'filterIsNotArray' => [
177			['test'],
178			],
179			'emptyFilterArray' => [
180			[[]],
181			],
182			'operatorFailInvalidType' => [
183			[[false]],
184			],
185			'operatorFailWithEmptyString' => [
186			[['']],
187			],
188			];
189			}
190			}
191

yiisoft / data

Push — master ( 019716...f69765 )

FilterTest::filterDataProvider() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like