Helper::mergeConfig() - Code Metrics - Inspection of "Refactoring helper" - yiisoft/composer-config-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#6)

by Dmitriy

created 2020-04-07 14:55 UTC

Helper::mergeConfig() B

↳ Parent: Helper

Complexity

Conditions	11
Paths	3

Size

Total Lines	27
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	11
eloc	17
nc	3
nop	1
dl	0
loc	27
rs	7.3166
c	0
b	0
f	0

How to fix Complexity

<?php

namespace Yiisoft\Composer\Config\Utils;

use ReflectionException;
use Riimu\Kit\PHPEncoder\PHPEncoder;

use function in_array;
use function is_array;
use function is_int;

/**
 * Helper class.
 */
class Helper
{
    private PHPEncoder $encoder;

    public function __construct()
    {
        $encoder = new PHPEncoder([
            'object.format' => 'serialize',
        ]);
        $encoder->addEncoder(new ClosureEncoder(), true);
        $this->encoder = $encoder;
    }

    /**
     * @param array $args
     * @return array the merged array
     */
    public function mergeConfig(...$args): array
    {
        $res = array_shift($args) ?: [];
        foreach ($args as $items) {
            if (!is_array($items)) {
                continue;
            }
            foreach ($items as $k => $v) {
                if (is_int($k)) {
                    /// XXX skip repeated values
                    if (in_array($v, $res, true)) {
                        continue;
                    }
                    if (array_key_exists($k, $res)) {
                        $res[] = $v;
                    } else {
                        $res[$k] = $v;
                    }
                } elseif (is_array($v) && isset($res[$k]) && is_array($res[$k])) {
                    $res[$k] = $this->mergeConfig($res[$k], $v);
                } else {
                    $res[$k] = $v;
                }
            }
        }

        return $res;
    }

    public function fixConfig(array $config): array
    {
        $remove = false;
        foreach ($config as $key => &$value) {
            if (is_array($value)) {
                $value = $this->fixConfig($value);
            } elseif ($value instanceof RemoveArrayKeys) {
                $remove = true;
                unset($config[$key]);
            }
        }
        if ($remove) {
            return array_values($config);
        }

        return $config;
    }

    /**
     * Returns PHP-executable string representation of given value.
     * Uses Riimu/Kit-PHPEncoder based `var_export` alternative.
     * And Opis/Closure to dump closures as PHP code.
     *
     * @param mixed $value
     * @return string
     * @throws ReflectionException
     */
    public function exportVar($value): string
    {
        return $this->encoder->encode($value);
    }
}


1			<?php
2
3			namespace Yiisoft\Composer\Config\Utils;
4
5			use ReflectionException;
6			use Riimu\Kit\PHPEncoder\PHPEncoder;
7
8			use function in_array;
9			use function is_array;
10			use function is_int;
11
12			/**
13			* Helper class.
14			*/
15			class Helper
16			{
17			private PHPEncoder $encoder;
18
19			public function __construct()
20			{
21			$encoder = new PHPEncoder([
22			'object.format' => 'serialize',
23			]);
24			$encoder->addEncoder(new ClosureEncoder(), true);
25			$this->encoder = $encoder;
26			}
27
28			/**
29			* @param array $args
30			* @return array the merged array
31			*/
32			public function mergeConfig(...$args): array
33			{
34			$res = array_shift($args) ?: [];
35			foreach ($args as $items) {
36			if (!is_array($items)) {
37			continue;
38			}
39			foreach ($items as $k => $v) {
40			if (is_int($k)) {
41			/// XXX skip repeated values
42			if (in_array($v, $res, true)) {
43			continue;
44			}
45			if (array_key_exists($k, $res)) {
46			$res[] = $v;
47			} else {
48			$res[$k] = $v;
49			}
50			} elseif (is_array($v) && isset($res[$k]) && is_array($res[$k])) {
51			$res[$k] = $this->mergeConfig($res[$k], $v);
52			} else {
53			$res[$k] = $v;
54			}
55			}
56			}
57
58			return $res;
59			}
60
61			public function fixConfig(array $config): array
62			{
63			$remove = false;
64			foreach ($config as $key => &$value) {
65			if (is_array($value)) {
66			$value = $this->fixConfig($value);
67			} elseif ($value instanceof RemoveArrayKeys) {
68			$remove = true;
69			unset($config[$key]);
70			}
71			}
72			if ($remove) {
73			return array_values($config);
74			}
75
76			return $config;
77			}
78
79			/**
80			* Returns PHP-executable string representation of given value.
81			* Uses Riimu/Kit-PHPEncoder based `var_export` alternative.
82			* And Opis/Closure to dump closures as PHP code.
83			*
84			* @param mixed $value
85			* @return string
86			* @throws ReflectionException
87			*/
88			public function exportVar($value): string
89			{
90			return $this->encoder->encode($value);
91			}
92			}
93

yiisoft / composer-config-plugin

Pull Request — master (#6)

Helper::mergeConfig() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like