Yiisoft\Composer\Config\Reader\PhpReader::readRaw()

Complexity

Conditions	7
Paths	1

Size

Total Lines	44
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	1
CRAP Score	7

Importance

Changes	2
Bugs	0	Features	0

<?php
    protected function readRaw(string $path)
    {
        $params = $this->builder->getVars()['params'] ?? [];

        $builder = $this->builder;

        /** @var Builder $result */
        $result = static function (array $params) use ($builder) {
            $fileName = func_get_arg(1);

            $parser = (new ParserFactory())->create(ParserFactory::PREFER_PHP7);
            try {

                $code = file_get_contents($fileName);
                $ast = $parser->parse($code);

                /** @var Stmt $node */
                foreach ($ast as $node){
                    if(isset($node->type) && $node->type == Use_::TYPE_NORMAL and !empty($node->uses)){
                        foreach ($node->uses as $use) {
                            $className = end($use->name->parts);
                            $builder->uses[ $className ] = 'use ' . implode('\\', $use->name->parts) . ';';
                        }
                    }
                }

                /**
                 * Everything is not evaluated at compile time by default except Buildtime::* calls.
                 * @see https://gist.github.com/samdark/86f2b9ff01a96892efbbf254eca8482d
                 */
                $prettyPrinter = new PhpRender(['builder' => $builder, 'context' => $fileName]);
                $newCode = $prettyPrinter->prettyPrintFile($ast);

It seems like $ast can also be of type null; however, parameter $stmts of PhpParser\PrettyPrinterAbstract::prettyPrintFile() does only seem to accept array, maybe add an additional type check?

                $outputPathFile = $builder->getOutputPath(basename($fileName) . '.' .md5($newCode) . '.ast');
                file_put_contents($outputPathFile, $newCode);
                $output = require $outputPathFile;
                @unlink($outputPathFile);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

                return $output;

            } catch (Error $e) {
                throw $e;
            }
        };

        return $result($params, $path);
    }