Yiisoft\Composer\Config\Reader\PhpReader

Complexity

Total Complexity

10

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	parsePhp()	0	5	1
A	printPhp()	0	8	1
A	requireWithParams()	0	9	1
A	extractUses()	0	8	6
A	readRaw()	0	13	1

<?php

declare(strict_types=1);

namespace Yiisoft\Composer\Config\Reader;

use PhpParser\Node\Stmt;
use PhpParser\Node\Stmt\Use_;
use PhpParser\ParserFactory;
use Yiisoft\Composer\Config\Util\PhpPrinter;

/**
 * PhpReader - reads PHP files.
 */
class PhpReader extends AbstractReader
{
    protected function readRaw(string $path)
    {
        $ast = $this->parsePhp($path);
        $this->extractUses($ast);
        $newCode = $this->printPhp($ast);

        //$newFile = $this->builder->getOutputPath(basename($path) . '.' .md5($newCode) . '.ast');
        $newFile = $path . '.new.php';
        file_put_contents($newFile, $newCode);
        $output = $this->requireWithParams($newFile);
        @unlink($newFile);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

        return $output;
    }

    /**
     * @return mixed
     */
    protected function requireWithParams(string $path)
    {
        $params = $this->builder->getVars()['params'] ?? [];

        $result = static function (array $params) {
            return require func_get_arg(1);
        };
                                  
        return $result($params, $path);                                  
    }


    protected function parsePhp(string $path): array
    {
        $parser = (new ParserFactory())->create(ParserFactory::PREFER_PHP7);

        return $parser->parse(file_get_contents($path));

The expression return $parser->parse(file_get_contents($path)) could return the type null which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }

    protected function extractUses($ast)
    {
        /** @var Stmt $node */
        foreach ($ast as $node){
            if (isset($node->type) && $node->type == Use_::TYPE_NORMAL and !empty($node->uses)) {
                foreach ($node->uses as $use) {
                    $className = end($use->name->parts);
                    $this->builder->uses[$className] = 'use ' . implode('\\', $use->name->parts) . ';';
                }
            }
        }
    }

    protected function printPhp(array $ast): string
    {
        $printer = new PhpPrinter([
            //'builder' => $this->builder,
            //'context' => $path,
        ]);

        return $printer->prettyPrintFile($ast);
    }
}