Yiisoft\Classifier\PhpParserClassifier::find()

Complexity

Conditions	10
Paths	4

Size

Total Lines	48
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function find(): iterable
    {
        $countInterfaces = count($this->interfaces);
        $countAttributes = count($this->attributes);

        if ($countInterfaces === 0 && $countAttributes === 0) {
            return [];
        }

        $files = (new Finder())
            ->in($this->directory)
            ->name('*.php')
            ->sortByName()
            ->files();

        $interfaces = $this->interfaces;
        $attributes = $this->attributes;

        foreach ($files as $file) {
            $nodes = $this->parser->parse(file_get_contents($file->getRealPath()));
            $this->traverser->traverse($nodes);

It seems like $nodes can also be of type null; however, parameter $nodes of PhpParser\NodeTraverser::traverse() does only seem to accept array, maybe add an additional type check?

            /**
             * @var $result Node\Stmt\Class_[]
             */
            $result = $this->nodeFinder->find(
                $nodes,
                function (Node $node) use ($interfaces, $countInterfaces, $attributes, $countAttributes) {
                    if (!$node instanceof Node\Stmt\Class_) {
                        return false;
                    }
                    $interfacesNames = array_map(fn (Node\Name $name) => $name->toString(), $node->implements);
                    if (count(array_intersect($interfaces, $interfacesNames)) !== $countInterfaces) {
                        return false;
                    }
                    $attributesNames = [];
                    foreach ($node->attrGroups as $attrGroup) {
                        foreach ($attrGroup->attrs as $attr) {
                            $attributesNames[] = $attr->name->toString();
                        }
                    }
                    if (count(array_intersect($attributes, $attributesNames)) !== $countAttributes) {
                        return false;
                    }
                    return true;
                }
            );
            foreach ($result as $class) {
                yield $class->namespacedName->toString();

The method toString() does not exist on null.

            }