ClassifierVisitor::enterNode() - Code Metrics - Inspection of "Refactoring & PhpParserClassifier" - yiisoft/classifier - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#38)

by Rustam

created 2023-09-22 05:37 UTC

ClassifierVisitor::enterNode() A

↳ Parent: ClassifierVisitor

Complexity

Conditions	4
Paths	3

Size

Total Lines	13
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	5
c	1
b	0
f	0
nc	3
nop	1
dl	0
loc	13
ccs	6
cts	6
cp	1
crap	4
rs	10

<?php

declare(strict_types=1);

namespace Yiisoft\Classifier;

use PhpParser\Node;
use PhpParser\NodeVisitorAbstract;

/**
 * @internal Visitor for Classifier
 */
final class ClassifierVisitor extends NodeVisitorAbstract
{
    /**
     * @var array<class-string>

     */
    private array $classNames = [];

    /**
     * @param \Closure(class-string): bool $shouldSkipClass
     */
    public function __construct(private \Closure $shouldSkipClass)
    {
    }

    public function enterNode(Node $node)
    {
        if ($node instanceof Node\Stmt\Class_) {
            /**
             * @psalm-var class-string|null $className
             */
            $className = $node->namespacedName?->toString();
            if ($className !== null && !($this->shouldSkipClass)($className)) {
                $this->classNames[] = $className;
            }
        }

        return parent::enterNode($node);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    /**
     * @return array<class-string>

     */
    public function getClassNames(): array
    {
        return $this->classNames;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Yiisoft\Classifier;
6
7		use PhpParser\Node;
8		use PhpParser\NodeVisitorAbstract;
9
10		/**
11		* @internal Visitor for Classifier
12		*/
13		final class ClassifierVisitor extends NodeVisitorAbstract
14		{
15		/**
16		* @var array<class-string>
		0 ignored issues – show Documentation Bug introduced 2023-09-22 05:20 UTC by Report Bug Copy Issue Report The doc comment `array<class-string>` at position `2` could not be parsed: Unknown type name 'class-string' at position 2 in array<class-string>. Loading history...
17		*/
18		private array $classNames = [];
19
20		/**
21		* @param \Closure(class-string): bool $shouldSkipClass
22		*/
23	10	public function __construct(private \Closure $shouldSkipClass)
24		{
25	10	}
26
27	10	public function enterNode(Node $node)
28		{
29	10	if ($node instanceof Node\Stmt\Class_) {
30		/**
31		* @psalm-var class-string\|null $className
32		*/
33	10	$className = $node->namespacedName?->toString();
34	10	if ($className !== null && !($this->shouldSkipClass)($className)) {
35	10	$this->classNames[] = $className;
36		}
37		}
38
39	10	return parent::enterNode($node);
		0 ignored issues – show Bug introduced 2023-09-22 05:20 UTC by Report Bug Copy Issue Report Are you sure the usage of `parent::enterNode($node)` targeting `PhpParser\NodeVisitorAbstract::enterNode()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
40		}
41
42		/**
43		* @return array<class-string>
		0 ignored issues – show Documentation Bug introduced 2023-09-22 05:20 UTC by Report Bug Copy Issue Report The doc comment `array<class-string>` at position `2` could not be parsed: Unknown type name 'class-string' at position 2 in array<class-string>. Loading history...
44		*/
45	10	public function getClassNames(): array
46		{
47	10	return $this->classNames;
48		}
49		}
50

yiisoft / classifier

Pull Request — master (#38)

ClassifierVisitor::enterNode() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like