SaveOrder::applyOrder() - Code Metrics - Inspection of "Array collections with modifiers" - yiisoft/arrays - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#62)

by Sergei

created 2020-11-07 07:46 UTC

SaveOrder::applyOrder() B

↳ Parent: SaveOrder

Complexity

Conditions	10
Paths	11

Size

Total Lines	25
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	10
eloc	14
nc	11
nop	2
dl	0
loc	25
rs	7.6666
c	0
b	0
f	0

How to fix Complexity

<?php

declare(strict_types=1);

namespace Yiisoft\Arrays\Collection\Modifier;

use Yiisoft\Arrays\ArrayHelper;
use Yiisoft\Arrays\Collection\Modifier\ModifierInterface\AfterMergeModifierInterface;
use Yiisoft\Arrays\Collection\Modifier\ModifierInterface\BeforeMergeModifierInterface;

/**
 * Modifier "Save Order"
 *
 * Модификатор запоминает порядок элементов в текущей коллекции и пытается его сохранить
 * при объединении массивов.
 */
final class SaveOrder implements BeforeMergeModifierInterface, AfterMergeModifierInterface
{
    private array $array = [];

    private bool $nested = false;

    public function nested(): self
    {
        $new = clone $this;
        $new->nested = true;
        return $new;
    }

    public function notNested(): self
    {
        $new = clone $this;
        $new->nested = false;
        return $new;
    }

    public function beforeMerge(array $arrays, int $index): array
    {
        $this->array = $arrays[$index];
        return $this->array;
    }

    public function afterMerge(array $data): array
    {
        return $this->applyOrder($data, $this->array);
    }

    private function applyOrder(array $data, array $array): array
    {
        $result = [];

        foreach ($array as $key => $value) {
            if (is_string($key)) {
                if (array_key_exists($key, $data)) {
                    $result[$key] = ArrayHelper::remove($data, $key);
                }
            } else {
                foreach ($data as $dataKey => $dataValue) {
                    if (is_int($dataKey) && $dataValue === $value) {
                        $result[] = $dataValue;
                        unset($data[$dataKey]);
                        break;
                    }
                }
            }

            if ($this->nested && is_array($value) && is_array($result[$key])) {
                $result[$key] = $this->applyOrder($result[$key], $value);
            }
        }

        return array_merge($result, $data);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yiisoft\Arrays\Collection\Modifier;
6
7			use Yiisoft\Arrays\ArrayHelper;
8			use Yiisoft\Arrays\Collection\Modifier\ModifierInterface\AfterMergeModifierInterface;
9			use Yiisoft\Arrays\Collection\Modifier\ModifierInterface\BeforeMergeModifierInterface;
10
11			/**
12			* Modifier "Save Order"
13			*
14			* Модификатор запоминает порядок элементов в текущей коллекции и пытается его сохранить
15			* при объединении массивов.
16			*/
17			final class SaveOrder implements BeforeMergeModifierInterface, AfterMergeModifierInterface
18			{
19			private array $array = [];
20
21			private bool $nested = false;
22
23			public function nested(): self
24			{
25			$new = clone $this;
26			$new->nested = true;
27			return $new;
28			}
29
30			public function notNested(): self
31			{
32			$new = clone $this;
33			$new->nested = false;
34			return $new;
35			}
36
37			public function beforeMerge(array $arrays, int $index): array
38			{
39			$this->array = $arrays[$index];
40			return $this->array;
41			}
42
43			public function afterMerge(array $data): array
44			{
45			return $this->applyOrder($data, $this->array);
46			}
47
48			private function applyOrder(array $data, array $array): array
49			{
50			$result = [];
51
52			foreach ($array as $key => $value) {
53			if (is_string($key)) {
54			if (array_key_exists($key, $data)) {
55			$result[$key] = ArrayHelper::remove($data, $key);
56			}
57			} else {
58			foreach ($data as $dataKey => $dataValue) {
59			if (is_int($dataKey) && $dataValue === $value) {
60			$result[] = $dataValue;
61			unset($data[$dataKey]);
62			break;
63			}
64			}
65			}
66
67			if ($this->nested && is_array($value) && is_array($result[$key])) {
68			$result[$key] = $this->applyOrder($result[$key], $value);
69			}
70			}
71
72			return array_merge($result, $data);
73			}
74			}
75

yiisoft / arrays

Pull Request — master (#62)

SaveOrder::applyOrder() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like