ymaker\helpers\UserAgentHelper

Complexity

Total Complexity

5

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	isGooglePageSpeed()	0	9	4

<?php
/**
 * @link https://github.com/yiimaker/yii2-helpers
 * @copyright Copyright (c) 2017 Yii Maker
 * @license BSD 3-Clause License
 */

namespace ymaker\helpers;

use Yii;

/**
 * User agent helper.
 *
 * @author Vladimir Kuprienko <vldmr.kuprienko@gmail.com>
 * @since 1.0
 */
class UserAgentHelper
{
    /**
     * @var null|string
     */
    private static $_cache;


    /**
     * This class should not be instantiated.
     */
    private function __construct()
    {
    }

    /**
     * Check whether user agent is a Google Page Speed Insights.
     * @see https://stackoverflow.com/questions/29162881
     *
     * @param bool $useCache
     * @return bool

Should the return type not be boolean|string?

     */
    public static function isGooglePageSpeed($useCache = true)
    {
        if (null === self::$_cache || false === $useCache) {
            $userAgent = Yii::$app->getRequest()->getUserAgent();
            self::$_cache = (null !== $userAgent) && (false !== stripos($userAgent, 'Speed Insights'));

It seems like null !== $userAgent && false !== stripos($userAgent, 'Speed Insights') of type boolean is incompatible with the declared type null|string of property $_cache.

        }

        return self::$_cache;
    }
}