Issues in CommandTrait.php - New Issues - Inspection of "Fixes" - yiicod/yii2-socketio - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#18)

unknown

created 2019-09-21 14:39 UTC

commands/CommandTrait.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace yiicod\socketio\commands;

use Symfony\Component\Process\Process;
use Yii;
use yii\helpers\ArrayHelper;
use yii\helpers\Console;
use yii\helpers\Json;
use yiicod\socketio\Broadcast;

trait CommandTrait
{
    /**
     * @var string
     */
    public $server = 'locahost:1212';

    /**
     * [
     *     key => 'path to key',
     *     cert => 'path to cert',
     * ]
     *
     * @var array
     */
    public $ssl = [];
	
	/**
	 * Process job by id and connection
	 * @param $handler
	 * @param $data
	 * @param $id
	 */
    public function actionProcess($handler, $data, $id)
    {
        Broadcast::process($handler, @json_decode($data, true) ?? [], $id);
    }

    public function nodejs()
    {
        // Automatically send every new message to available log routes
        Yii::getLogger()->flushInterval = 1;

        $cmd = sprintf('node %s/%s', realpath(dirname(__FILE__) . '/../server'), 'index.js');
        $args = array_filter([
            'server' => $this->server,
            'pub' => json_encode(array_filter([
                'host' => Broadcast::getDriver()->hostname,
                'port' => Broadcast::getDriver()->port,
                'password' => Broadcast::getDriver()->password,
            ])),
            'sub' => json_encode(array_filter([
                'host' => Broadcast::getDriver()->hostname,
                'port' => Broadcast::getDriver()->port,
                'password' => Broadcast::getDriver()->password,
            ])),
            'channels' => implode(',', Broadcast::channels()),
            'nsp' => Broadcast::getManager()->nsp,
            'ssl' => empty($this->ssl) ? null : json_encode($this->ssl),
            'runtime' => Yii::getAlias('@runtime/logs'),
        ], 'strlen');
        foreach ($args as $key => $value) {
            $cmd .= ' -' . $key . '=\'' . $value . '\'';
        }

        $process = new Process($cmd);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return $process;
    }

    /**
     * Predis proccess
     */
    public function predis()
    {
        $pubSubLoop = function () {
            $client = Broadcast::getDriver()->getConnection(true);

            // Initialize a new pubsub consumer.
            $pubsub = $client->pubSubLoop();

            $channels = [];
            foreach (Broadcast::channels() as $key => $channel) {
                $channels[$key] = $channel . '.io';
            }

            // Subscribe to your channels
            $pubsub->subscribe(ArrayHelper::merge(['control_channel'], $channels));

            // Start processing the pubsup messages. Open a terminal and use redis-cli
            // to push messages to the channels. Examples:
            //   ./redis-cli PUBLISH notifications "this is a test"
            //   ./redis-cli PUBLISH control_channel quit_loop
			/** @var object $message */
			foreach ($pubsub as $message) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                switch ($message->kind) {
                    case 'subscribe':
                        $this->output("Subscribed to {$message->channel}\n");
                        break;
                    case 'message':
                        if ('control_channel' == $message->channel) {
                            if ('quit_loop' == $message->payload) {
                                $this->output("Aborting pubsub loop...\n", Console::FG_RED);
                                $pubsub->unsubscribe();
                            } else {
                                $this->output("Received an unrecognized command: {$message->payload}\n", Console::FG_RED);
                            }
                        } else {
                            $payload = Json::decode($message->payload);
                            $data = $payload['data'] ?? [];
							$id = $payload['id'] ?? '';

//                            $pid = pcntl_fork();
//                            if ($pid == -1) {
//                                exit('Error while forking process.');
//                            } elseif ($pid) {
//                                //parent. Wait for the child and continues
//                                pcntl_wait($status);
//                                $exitStatus = pcntl_wexitstatus($status);
//                                if ($exitStatus !== 0) {
//                                    //put job back to queue or other stuff
//                                }
//                            }else {
                            Broadcast::on($payload['name'], $data, $id);
//                                Yii::$app->end();
//                            }
                            // Received the following message from {$message->channel}:") {$message->payload}";
                        }
                        break;
                }
            }

            // Always unset the pubsub consumer instance when you are done! The
            // class destructor will take care of cleanups and prevent protocol
            // desynchronizations between the client and the server.
            unset($pubsub);
        };

        // Auto recconnect on redis timeout
        try {
            $pubSubLoop();
        } catch (\Predis\Connection\ConnectionException $e) {
            $pubSubLoop();
        }

        return true;
    }
}


1			<?php
2
3			namespace yiicod\socketio\commands;
4
5			use Symfony\Component\Process\Process;
6			use Yii;
7			use yii\helpers\ArrayHelper;
8			use yii\helpers\Console;
9			use yii\helpers\Json;
10			use yiicod\socketio\Broadcast;
11
12			trait CommandTrait
13			{
14			/**
15			* @var string
16			*/
17			public $server = 'locahost:1212';
18
19			/**
20			* [
21			* key => 'path to key',
22			* cert => 'path to cert',
23			* ]
24			*
25			* @var array
26			*/
27			public $ssl = [];
28
29			/**
30			* Process job by id and connection
31			* @param $handler
32			* @param $data
33			* @param $id
34			*/
35			public function actionProcess($handler, $data, $id)
36			{
37			Broadcast::process($handler, @json_decode($data, true) ?? [], $id);
38			}
39
40			public function nodejs()
41			{
42			// Automatically send every new message to available log routes
43			Yii::getLogger()->flushInterval = 1;
44
45			$cmd = sprintf('node %s/%s', realpath(dirname(__FILE__) . '/../server'), 'index.js');
46			$args = array_filter([
47			'server' => $this->server,
48			'pub' => json_encode(array_filter([
49			'host' => Broadcast::getDriver()->hostname,
50			'port' => Broadcast::getDriver()->port,
51			'password' => Broadcast::getDriver()->password,
52			])),
53			'sub' => json_encode(array_filter([
54			'host' => Broadcast::getDriver()->hostname,
55			'port' => Broadcast::getDriver()->port,
56			'password' => Broadcast::getDriver()->password,
57			])),
58			'channels' => implode(',', Broadcast::channels()),
59			'nsp' => Broadcast::getManager()->nsp,
60			'ssl' => empty($this->ssl) ? null : json_encode($this->ssl),
61			'runtime' => Yii::getAlias('@runtime/logs'),
62			], 'strlen');
63			foreach ($args as $key => $value) {
64			$cmd .= ' -' . $key . '=\'' . $value . '\'';
65			}
66
67			$process = new Process($cmd);
			0 ignored issues – show Documentation introduced 2019-09-21 15:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$cmd` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
68
69			return $process;
70			}
71
72			/**
73			* Predis proccess
74			*/
75			public function predis()
76			{
77			$pubSubLoop = function () {
78			$client = Broadcast::getDriver()->getConnection(true);
79
80			// Initialize a new pubsub consumer.
81			$pubsub = $client->pubSubLoop();
82
83			$channels = [];
84			foreach (Broadcast::channels() as $key => $channel) {
85			$channels[$key] = $channel . '.io';
86			}
87
88			// Subscribe to your channels
89			$pubsub->subscribe(ArrayHelper::merge(['control_channel'], $channels));
90
91			// Start processing the pubsup messages. Open a terminal and use redis-cli
92			// to push messages to the channels. Examples:
93			// ./redis-cli PUBLISH notifications "this is a test"
94			// ./redis-cli PUBLISH control_channel quit_loop
95			/** @var object $message */
96			foreach ($pubsub as $message) {
			0 ignored issues – show Bug introduced 2019-09-21 15:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$pubsub` of type `object<Predis\PubSub\Consumer>\|null` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
97			switch ($message->kind) {
98			case 'subscribe':
99			$this->output("Subscribed to {$message->channel}\n");
100			break;
101			case 'message':
102			if ('control_channel' == $message->channel) {
103			if ('quit_loop' == $message->payload) {
104			$this->output("Aborting pubsub loop...\n", Console::FG_RED);
105			$pubsub->unsubscribe();
106			} else {
107			$this->output("Received an unrecognized command: {$message->payload}\n", Console::FG_RED);
108			}
109			} else {
110			$payload = Json::decode($message->payload);
111			$data = $payload['data'] ?? [];
112			$id = $payload['id'] ?? '';
113
114			// $pid = pcntl_fork();
115			// if ($pid == -1) {
116			// exit('Error while forking process.');
117			// } elseif ($pid) {
118			// //parent. Wait for the child and continues
119			// pcntl_wait($status);
120			// $exitStatus = pcntl_wexitstatus($status);
121			// if ($exitStatus !== 0) {
122			// //put job back to queue or other stuff
123			// }
124			// }else {
125			Broadcast::on($payload['name'], $data, $id);
126			// Yii::$app->end();
127			// }
128			// Received the following message from {$message->channel}:") {$message->payload}";
129			}
130			break;
131			}
132			}
133
134			// Always unset the pubsub consumer instance when you are done! The
135			// class destructor will take care of cleanups and prevent protocol
136			// desynchronizations between the client and the server.
137			unset($pubsub);
138			};
139
140			// Auto recconnect on redis timeout
141			try {
142			$pubSubLoop();
143			} catch (\Predis\Connection\ConnectionException $e) {
144			$pubSubLoop();
145			}
146
147			return true;
148			}
149			}
150

yiicod / yii2-socketio

Pull Request — master (#18)

commands/CommandTrait.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like