yiicod / yii2-socketio

Process.php

<?php

namespace yiicod\socketio;

use Symfony\Component\Process\Process as SymfonyProcess;
use Yii;
use yii\helpers\HtmlPurifier;

/**
 * Class Process
 *
 * @package SfCod\SocketIoBundle
 */

/**
 * Class Process
 *
 * @package yiicod\socketio
 */
class Process
{
    /**
     * @var array
     */
    private static $_inWork = [];

    /**
     * @var
     */
    public $yiiAlias;

    /**
     * @return int
     */
    public function getParallelEnv(): int
    {
        return getenv('SOCKET_IO.PARALLEL') ? getenv('SOCKET_IO.PARALLEL') : 10;
    }

	/**
	 * Run process. If more then limit then wait and try run process on more time.
	 *
	 * @param string $handle
	 * @param array $data
	 * @param string $id
	 *
	 * @return SymfonyProcess
	 */
    public function run(string $handle, array $data, string $id)
    {
        $this->inWork();

        while (count(self::$_inWork) >= $this->getParallelEnv()) {
            usleep(100);

            $this->inWork();
        }

        return $this->push($handle, $data, $id);
    }

    /**
     * In work processes
     */
    private function inWork()
    {
        foreach (self::$_inWork as $i => $proccess) {
            if (false === $proccess->isRunning()) {
                unset(self::$_inWork[$i]);
            }
        }
    }

	/**
	 * Create cmd process and push to queue.
	 *
	 * @param string $handle
	 * @param array $data
	 * @param string $id
	 *
	 * @return SymfonyProcess
	 */
    private function push(string $handle, array $data, string $id): SymfonyProcess
    {
        $cmd = HtmlPurifier::process(sprintf('php yii socketio/process %s %s %s', escapeshellarg($handle), escapeshellarg(json_encode($data)), escapeshellarg($id)));

        if (is_null($this->yiiAlias)) {
            if (file_exists(Yii::getAlias('@app/yii'))) {
                $this->yiiAlias = '@app';
            } elseif (file_exists(Yii::getAlias('@app/../yii'))) {
                $this->yiiAlias = '@app/../';
            }
        }

        $process = new SymfonyProcess($cmd, Yii::getAlias($this->yiiAlias));

$cmd is of type string|false|null, but the function expects a array.

It seems like \Yii::getAlias($this->yiiAlias) targeting yii\BaseYii::getAlias() can also be of type boolean; however, Symfony\Component\Process\Process::__construct() does only seem to accept null|string, maybe add an additional type check?

        $process->setTimeout(10);
        $process->start();

        self::$_inWork[] = $process;

        return $process;
    }
}