Process::inWork() - Code Metrics - Inspection of "Small improvement" - yiicod/yii2-socketio - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c0f953...e85667 )

by Alexey

created 2018-02-18 21:31 UTC

Process::inWork() A

↳ Parent: Process

Complexity

Conditions	3
Paths	3

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	4
nc	3
nop	0

<?php

namespace yiicod\socketio;

use Yii;
use yii\helpers\HtmlPurifier;

/**
 * Class Process
 *
 * @package SfCod\SocketIoBundle
 */

/**
 * Class Process
 *
 * @package yiicod\socketio
 */
class Process
{
    /**
     * @var array
     */
    private static $_inWork = [];

    /**
     * @var
     */
    public $yiiAlias;

    /**
     * @return int
     */
    public function getParallelEnv(): int
    {
        return getenv('SOCKET_IO.PARALLEL') ? getenv('SOCKET_IO.PARALLEL') : 10;
    }

    /**
     * Run process. If more then limit then wait and try run process on more time.
     *
     * @param string $handle
     * @param array $data
     *
     * @return \Symfony\Component\Process\Process
     */
    public function run(string $handle, array $data)
    {
        $this->inWork();

        while (count(self::$_inWork) >= $this->getParallelEnv()) {
            usleep(100);

            $this->inWork();
        }

        return $this->push($handle, $data);
    }

    /**
     * In work processes
     */
    private function inWork()
    {
        foreach (self::$_inWork as $i => $proccess) {
            if (false === $proccess->isRunning()) {
                unset(self::$_inWork[$i]);
            }
        }
    }

    /**
     * Create cmd process and push to queue.
     *
     * @param string $handle
     * @param array $data
     *
     * @return \Symfony\Component\Process\Process
     */
    private function push(string $handle, array $data): \Symfony\Component\Process\Process
    {
        $cmd = HtmlPurifier::process(sprintf('php yii socketio/process %s %s', escapeshellarg($handle), escapeshellarg(serialize($data))));

        if (is_null($this->yiiAlias)) {
            if (file_exists(Yii::getAlias('@app/yii'))) {
                $this->yiiAlias = '@app';
            } elseif (file_exists(Yii::getAlias('@app/../yii'))) {
                $this->yiiAlias = '@app/../';
            }
        }

        $process = new \Symfony\Component\Process\Process($cmd, Yii::getAlias($this->yiiAlias));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $process->setTimeout(10);
        $process->start();

        self::$_inWork[] = $process;

        return $process;
    }
}


1			<?php
2
3			namespace yiicod\socketio;
4
5			use Yii;
6			use yii\helpers\HtmlPurifier;
7
8			/**
9			* Class Process
10			*
11			* @package SfCod\SocketIoBundle
12			*/
13
14			/**
15			* Class Process
16			*
17			* @package yiicod\socketio
18			*/
19			class Process
20			{
21			/**
22			* @var array
23			*/
24			private static $_inWork = [];
25
26			/**
27			* @var
28			*/
29			public $yiiAlias;
30
31			/**
32			* @return int
33			*/
34			public function getParallelEnv(): int
35			{
36			return getenv('SOCKET_IO.PARALLEL') ? getenv('SOCKET_IO.PARALLEL') : 10;
37			}
38
39			/**
40			* Run process. If more then limit then wait and try run process on more time.
41			*
42			* @param string $handle
43			* @param array $data
44			*
45			* @return \Symfony\Component\Process\Process
46			*/
47			public function run(string $handle, array $data)
48			{
49			$this->inWork();
50
51			while (count(self::$_inWork) >= $this->getParallelEnv()) {
52			usleep(100);
53
54			$this->inWork();
55			}
56
57			return $this->push($handle, $data);
58			}
59
60			/**
61			* In work processes
62			*/
63			private function inWork()
64			{
65			foreach (self::$_inWork as $i => $proccess) {
66			if (false === $proccess->isRunning()) {
67			unset(self::$_inWork[$i]);
68			}
69			}
70			}
71
72			/**
73			* Create cmd process and push to queue.
74			*
75			* @param string $handle
76			* @param array $data
77			*
78			* @return \Symfony\Component\Process\Process
79			*/
80			private function push(string $handle, array $data): \Symfony\Component\Process\Process
81			{
82			$cmd = HtmlPurifier::process(sprintf('php yii socketio/process %s %s', escapeshellarg($handle), escapeshellarg(serialize($data))));
83
84			if (is_null($this->yiiAlias)) {
85			if (file_exists(Yii::getAlias('@app/yii'))) {
86			$this->yiiAlias = '@app';
87			} elseif (file_exists(Yii::getAlias('@app/../yii'))) {
88			$this->yiiAlias = '@app/../';
89			}
90			}
91
92			$process = new \Symfony\Component\Process\Process($cmd, Yii::getAlias($this->yiiAlias));
			0 ignored issues – show Bug introduced 2018-02-18 22:08 UTC by Report Bug Copy Issue Report It seems like `$cmd` defined by `\yii\helpers\HtmlPurifie...arg(serialize($data))))` on line `82` can also be of type `false` or `null`; however, `Symfony\Component\Process\Process::__construct()` does only seem to accept `string\|array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2018-02-18 22:08 UTC by Report Bug Copy Issue Report It seems like `\Yii::getAlias($this->yiiAlias)` targeting `yii\BaseYii::getAlias()` can also be of type `boolean`; however, `Symfony\Component\Process\Process::__construct()` does only seem to accept `null\|string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
93			$process->setTimeout(10);
94			$process->start();
95
96			self::$_inWork[] = $process;
97
98			return $process;
99			}
100			}
101

yiicod / yii2-socketio

Push — master ( c0f953...e85667 )

Process::inWork() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like