CommandTrait::predis() - Code Metrics - Inspection of "Fix daemon trait" - yiicod/yii2-socketio - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e85667...590689 )

by Alexey

created 2018-02-19 09:42 UTC

CommandTrait::predis() C

↳ Parent: CommandTrait

Complexity

Conditions	8
Paths	2

Size

Total Lines	72
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	72
rs	6.3883
c	0
b	0
f	0
cc	8
eloc	31
nc	2
nop	0

How to fix Long Method

<?php

namespace yiicod\socketio\commands;

use Symfony\Component\Process\Process;
use Yii;
use yii\helpers\ArrayHelper;
use yii\helpers\Console;
use yii\helpers\Json;
use yiicod\socketio\Broadcast;

trait CommandTrait
{
    /**
     * @var string
     */
    public $server = 'locahost:1212';

    /**
     * [
     *     key => 'path to key',
     *     cert => 'path to cert',
     * ]
     *
     * @var array
     */
    public $ssl = [];

    /**
     * Process job by id and connection
     */
    public function actionProcess($handler, $data)
    {
        Broadcast::process($handler, @unserialize($data) ?? []);
    }

    public function nodejs()
    {
        // Automatically send every new message to available log routes
        Yii::getLogger()->flushInterval = 1;

        $cmd = sprintf('node %s/%s', realpath(dirname(__FILE__) . '/../server'), 'index.js');
        $args = array_filter([
            'server' => $this->server,
            'pub' => json_encode(array_filter([
                'host' => Broadcast::getDriver()->hostname,
                'port' => Broadcast::getDriver()->port,
                'password' => Broadcast::getDriver()->password,
            ])),
            'sub' => json_encode(array_filter([
                'host' => Broadcast::getDriver()->hostname,
                'port' => Broadcast::getDriver()->port,
                'password' => Broadcast::getDriver()->password,
            ])),
            'channels' => implode(',', Broadcast::channels()),
            'nsp' => Broadcast::getManager()->nsp,
            'ssl' => empty($this->ssl) ? null : json_encode($this->ssl),
            'runtime' => Yii::getAlias('@runtime/logs'),
        ], 'strlen');
        foreach ($args as $key => $value) {
            $cmd .= ' -' . $key . '=\'' . $value . '\'';
        }

        $process = new Process($cmd);

        return $process;
    }

    /**
     * Predis proccess
     */
    public function predis()
    {
        $pubSubLoop = function () {
            $client = Broadcast::getDriver()->getConnection(true);

            // Initialize a new pubsub consumer.
            $pubsub = $client->pubSubLoop();

            $channels = [];
            foreach (Broadcast::channels() as $key => $channel) {
                $channels[$key] = $channel . '.io';
            }

            // Subscribe to your channels
            $pubsub->subscribe(ArrayHelper::merge(['control_channel'], $channels));

            // Start processing the pubsup messages. Open a terminal and use redis-cli
            // to push messages to the channels. Examples:
            //   ./redis-cli PUBLISH notifications "this is a test"
            //   ./redis-cli PUBLISH control_channel quit_loop
            foreach ($pubsub as $message) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                switch ($message->kind) {
                    case 'subscribe':
                        $this->output("Subscribed to {$message->channel}\n");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                        break;
                    case 'message':
                        if ('control_channel' == $message->channel) {
                            if ('quit_loop' == $message->payload) {
                                $this->output("Aborting pubsub loop...\n", Console::FG_RED);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                                $pubsub->unsubscribe();
                            } else {
                                $this->output("Received an unrecognized command: {$message->payload}\n", Console::FG_RED);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                            }
                        } else {
                            $payload = Json::decode($message->payload);
                            $data = $payload['data'] ?? [];

//                            $pid = pcntl_fork();
//                            if ($pid == -1) {
//                                exit('Error while forking process.');
//                            } elseif ($pid) {
//                                //parent. Wait for the child and continues
//                                pcntl_wait($status);
//                                $exitStatus = pcntl_wexitstatus($status);
//                                if ($exitStatus !== 0) {
//                                    //put job back to queue or other stuff
//                                }
//                            }else {
                            Broadcast::on($payload['name'], $data);
//                                Yii::$app->end();
//                            }
                            // Received the following message from {$message->channel}:") {$message->payload}";
                        }
                        break;
                }
            }

            // Always unset the pubsub consumer instance when you are done! The
            // class destructor will take care of cleanups and prevent protocol
            // desynchronizations between the client and the server.
            unset($pubsub);
        };

        // Auto recconnect on redis timeout
        try {
            $pubSubLoop();
        } catch (\Predis\Connection\ConnectionException $e) {
            $pubSubLoop();
        }

        return true;
    }
}


1			<?php
2
3			namespace yiicod\socketio\commands;
4
5			use Symfony\Component\Process\Process;
6			use Yii;
7			use yii\helpers\ArrayHelper;
8			use yii\helpers\Console;
9			use yii\helpers\Json;
10			use yiicod\socketio\Broadcast;
11
12			trait CommandTrait
13			{
14			/**
15			* @var string
16			*/
17			public $server = 'locahost:1212';
18
19			/**
20			* [
21			* key => 'path to key',
22			* cert => 'path to cert',
23			* ]
24			*
25			* @var array
26			*/
27			public $ssl = [];
28
29			/**
30			* Process job by id and connection
31			*/
32			public function actionProcess($handler, $data)
33			{
34			Broadcast::process($handler, @unserialize($data) ?? []);
35			}
36
37			public function nodejs()
38			{
39			// Automatically send every new message to available log routes
40			Yii::getLogger()->flushInterval = 1;
41
42			$cmd = sprintf('node %s/%s', realpath(dirname(__FILE__) . '/../server'), 'index.js');
43			$args = array_filter([
44			'server' => $this->server,
45			'pub' => json_encode(array_filter([
46			'host' => Broadcast::getDriver()->hostname,
47			'port' => Broadcast::getDriver()->port,
48			'password' => Broadcast::getDriver()->password,
49			])),
50			'sub' => json_encode(array_filter([
51			'host' => Broadcast::getDriver()->hostname,
52			'port' => Broadcast::getDriver()->port,
53			'password' => Broadcast::getDriver()->password,
54			])),
55			'channels' => implode(',', Broadcast::channels()),
56			'nsp' => Broadcast::getManager()->nsp,
57			'ssl' => empty($this->ssl) ? null : json_encode($this->ssl),
58			'runtime' => Yii::getAlias('@runtime/logs'),
59			], 'strlen');
60			foreach ($args as $key => $value) {
61			$cmd .= ' -' . $key . '=\'' . $value . '\'';
62			}
63
64			$process = new Process($cmd);
65
66			return $process;
67			}
68
69			/**
70			* Predis proccess
71			*/
72			public function predis()
73			{
74			$pubSubLoop = function () {
75			$client = Broadcast::getDriver()->getConnection(true);
76
77			// Initialize a new pubsub consumer.
78			$pubsub = $client->pubSubLoop();
79
80			$channels = [];
81			foreach (Broadcast::channels() as $key => $channel) {
82			$channels[$key] = $channel . '.io';
83			}
84
85			// Subscribe to your channels
86			$pubsub->subscribe(ArrayHelper::merge(['control_channel'], $channels));
87
88			// Start processing the pubsup messages. Open a terminal and use redis-cli
89			// to push messages to the channels. Examples:
90			// ./redis-cli PUBLISH notifications "this is a test"
91			// ./redis-cli PUBLISH control_channel quit_loop
92			foreach ($pubsub as $message) {
			0 ignored issues – show Bug introduced 2018-02-19 10:19 UTC by Report Bug Copy Issue Report The expression `$pubsub` of type `object<Predis\PubSub\Consumer>\|null` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
93			switch ($message->kind) {
94			case 'subscribe':
95			$this->output("Subscribed to {$message->channel}\n");
			0 ignored issues – show Bug introduced 2018-01-30 00:05 UTC by Report Bug Copy Issue Report It seems like `output()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
96			break;
97			case 'message':
98			if ('control_channel' == $message->channel) {
99			if ('quit_loop' == $message->payload) {
100			$this->output("Aborting pubsub loop...\n", Console::FG_RED);
			0 ignored issues – show Bug introduced 2018-01-30 00:05 UTC by Report Bug Copy Issue Report It seems like `output()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
101			$pubsub->unsubscribe();
102			} else {
103			$this->output("Received an unrecognized command: {$message->payload}\n", Console::FG_RED);
			0 ignored issues – show Bug introduced 2018-01-30 00:05 UTC by Report Bug Copy Issue Report It seems like `output()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
104			}
105			} else {
106			$payload = Json::decode($message->payload);
107			$data = $payload['data'] ?? [];
108
109			// $pid = pcntl_fork();
110			// if ($pid == -1) {
111			// exit('Error while forking process.');
112			// } elseif ($pid) {
113			// //parent. Wait for the child and continues
114			// pcntl_wait($status);
115			// $exitStatus = pcntl_wexitstatus($status);
116			// if ($exitStatus !== 0) {
117			// //put job back to queue or other stuff
118			// }
119			// }else {
120			Broadcast::on($payload['name'], $data);
121			// Yii::$app->end();
122			// }
123			// Received the following message from {$message->channel}:") {$message->payload}";
124			}
125			break;
126			}
127			}
128
129			// Always unset the pubsub consumer instance when you are done! The
130			// class destructor will take care of cleanups and prevent protocol
131			// desynchronizations between the client and the server.
132			unset($pubsub);
133			};
134
135			// Auto recconnect on redis timeout
136			try {
137			$pubSubLoop();
138			} catch (\Predis\Connection\ConnectionException $e) {
139			$pubSubLoop();
140			}
141
142			return true;
143			}
144			}
145

yiicod / yii2-socketio

Push — master ( e85667...590689 )

CommandTrait::predis() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like