MailHandler::send() - Code Metrics - yiicod/yii2-mailqueue - Measure and Improve Code Quality continuously with Scrutinizer

MailHandler::send() B
last analyzed 2018-02-18 22:18 UTC

↳ Parent: MailHandler

Complexity

Conditions	5
Paths	8

Size

Total Lines	20
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	20
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	14
nc	8
nop	1

<?php

namespace yiicod\mailqueue\components;

use Yii;
use yiicod\mailqueue\models\MailRepositoryInterface;

class MailHandler implements MailHandlerInterface
{
    const STATUS_SENT = 1;

    const STATUS_PENDING = 0;

    const STATUS_FAILED = 2;

    /**
     * Find mails
     *
     * @return mixed
     */
    public function findAll()
    {
        $class = Yii::$app->get('mailqueue')->modelMap['mailQueue']['class'];
        $models = $class::find()
            ->where(sprintf('%s=:pending', $class::attributesMap()['fieldStatus']))
            ->params([':pending' => self::STATUS_PENDING])
            ->orderBy($class::attributesMap()['fieldPriority'])
            ->limit(60)
            ->all();

        return $models;
    }

    /**
     * @param MailRepositoryInterface $item
     *
     * @return bool
     */
    public function send(MailRepositoryInterface $item): bool
    {
        if (Yii::$app->has($item->mailer ?? '')) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $mailer = Yii::$app->get($item->mailer);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        } else {
            $mailer = Yii::$app->mailer;
        }
        $message = $mailer->compose(null, ['item' => $item]);
        $message->setTo($item->to)
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            ->setSubject($item->subject)
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            ->setHtmlBody($item->body);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        if (false === empty($item->from) && true === empty($message->getFrom())) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $message->setFrom($item->from);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        }
        foreach ($item->getAttaches() as $attach) {
            $message->attach($attach);
        }

        return $message->send();
    }

    /**
     * @param array $ids
     *
     * @return mixed
     */
    public function success(array $ids)
    {
        $class = Yii::$app->get('mailqueue')->modelMap['mailQueue']['class'];
        $class::updateAll([
            $class::attributesMap()['fieldStatus'] => self::STATUS_SENT,
            $class::attributesMap()['fieldCreatedDate'] => date('Y-m-d H:i:s'),
        ], ['id' => $ids]);
    }

    /**
     * @param array $ids
     *
     * @return mixed
     */
    public function failed(array $ids)
    {
        $class = Yii::$app->get('mailqueue')->modelMap['mailQueue']['class'];
        $class::updateAll([
            $class::attributesMap()['fieldStatus'] => self::STATUS_FAILED,
            $class::attributesMap()['fieldCreatedDate'] => date('Y-m-d H:i:s'),
        ], ['id' => $ids]);
    }
}


1			<?php
2
3			namespace yiicod\mailqueue\components;
4
5			use Yii;
6			use yiicod\mailqueue\models\MailRepositoryInterface;
7
8			class MailHandler implements MailHandlerInterface
9			{
10			const STATUS_SENT = 1;
11
12			const STATUS_PENDING = 0;
13
14			const STATUS_FAILED = 2;
15
16			/**
17			* Find mails
18			*
19			* @return mixed
20			*/
21			public function findAll()
22			{
23			$class = Yii::$app->get('mailqueue')->modelMap['mailQueue']['class'];
24			$models = $class::find()
25			->where(sprintf('%s=:pending', $class::attributesMap()['fieldStatus']))
26			->params([':pending' => self::STATUS_PENDING])
27			->orderBy($class::attributesMap()['fieldPriority'])
28			->limit(60)
29			->all();
30
31			return $models;
32			}
33
34			/**
35			* @param MailRepositoryInterface $item
36			*
37			* @return bool
38			*/
39			public function send(MailRepositoryInterface $item): bool
40			{
41			if (Yii::$app->has($item->mailer ?? '')) {
			0 ignored issues – show Bug introduced 2018-02-18 21:38 UTC by Report Bug Copy Issue Report Accessing `mailer` on the interface `yiicod\mailqueue\models\MailRepositoryInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
42			$mailer = Yii::$app->get($item->mailer);
			0 ignored issues – show Bug introduced 2018-02-18 21:38 UTC by Report Bug Copy Issue Report Accessing `mailer` on the interface `yiicod\mailqueue\models\MailRepositoryInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
43			} else {
44			$mailer = Yii::$app->mailer;
45			}
46			$message = $mailer->compose(null, ['item' => $item]);
47			$message->setTo($item->to)
			0 ignored issues – show Bug introduced 2018-02-18 21:38 UTC by Report Bug Copy Issue Report Accessing `to` on the interface `yiicod\mailqueue\models\MailRepositoryInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
48			->setSubject($item->subject)
			0 ignored issues – show Bug introduced 2018-02-18 21:38 UTC by Report Bug Copy Issue Report Accessing `subject` on the interface `yiicod\mailqueue\models\MailRepositoryInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
49			->setHtmlBody($item->body);
			0 ignored issues – show Bug introduced 2018-02-18 21:38 UTC by Report Bug Copy Issue Report Accessing `body` on the interface `yiicod\mailqueue\models\MailRepositoryInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
50			if (false === empty($item->from) && true === empty($message->getFrom())) {
			0 ignored issues – show Bug introduced 2018-02-18 21:38 UTC by Report Bug Copy Issue Report Accessing `from` on the interface `yiicod\mailqueue\models\MailRepositoryInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
51			$message->setFrom($item->from);
			0 ignored issues – show Bug introduced 2018-02-18 21:38 UTC by Report Bug Copy Issue Report Accessing `from` on the interface `yiicod\mailqueue\models\MailRepositoryInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
52			}
53			foreach ($item->getAttaches() as $attach) {
54			$message->attach($attach);
55			}
56
57			return $message->send();
58			}
59
60			/**
61			* @param array $ids
62			*
63			* @return mixed
64			*/
65			public function success(array $ids)
66			{
67			$class = Yii::$app->get('mailqueue')->modelMap['mailQueue']['class'];
68			$class::updateAll([
69			$class::attributesMap()['fieldStatus'] => self::STATUS_SENT,
70			$class::attributesMap()['fieldCreatedDate'] => date('Y-m-d H:i:s'),
71			], ['id' => $ids]);
72			}
73
74			/**
75			* @param array $ids
76			*
77			* @return mixed
78			*/
79			public function failed(array $ids)
80			{
81			$class = Yii::$app->get('mailqueue')->modelMap['mailQueue']['class'];
82			$class::updateAll([
83			$class::attributesMap()['fieldStatus'] => self::STATUS_FAILED,
84			$class::attributesMap()['fieldCreatedDate'] => date('Y-m-d H:i:s'),
85			], ['id' => $ids]);
86			}
87			}
88

yiicod / yii2-mailqueue

MailHandler::send() B last analyzed 2018-02-18 22:18 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

MailHandler::send() B
last analyzed 2018-02-18 22:18 UTC