Issues in TmpRepository.php (master) - Issues in master - yiicod/yii2-fileupload - Measure and Improve Code Quality continuously with Scrutinizer

Issues (28)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

models/behaviors/TmpRepository.php (3 issues)

Labels

Bug 3

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace yiicod\fileupload\models\behaviors;

use Symfony\Component\Filesystem\Filesystem;
use Yii;
use yii\db\ActiveRecord;
use yii\web\Application;

class TmpRepository implements TmpRepositoryInterface
{
    /**
     * @var ActiveRecord
     */
    private $owner;

    public function __construct($owner)
    {
        $this->owner = $owner;
    }

    /**
     * Generate session key for file
     *
     * @param string $field Field name
     *
     * @return string
     */
    public function generateKey(string $field): string
    {
        return 'file_' . get_class($this->owner)::tableName() . $field;

    }

    /**
     * Save file to session, after move to "getFilePath"
     *
     * @author Orlov Alexey <[email protected]>
     *
     * @param string $file
     * @param string $field
     *
     * @return bool
     */
    public function setFile(string $file, string $field): bool
    {
        if (Yii::$app instanceof Application) {
            Yii::$app->session->set($this->generateKey($field), $file);
        }

        return true;
    }

    /**
     * Get file by session key
     *
     * @param string $field
     * @param bool $onlyName get only file name
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return string Return string
     */
    public function getFile(string $field): string
    {
        if (Yii::$app instanceof Application) {
            $file = Yii::$app->session->get($this->generateKey($field), '');

            return $file;
        }

        return '';
    }

    public function getFileName(string $field): string
    {
        $file = $this->getFile($field);
        $name = end(explode('/', $file));


        return $name;
    }

    /**
     * Remove file by session key
     *
     * @param string $field
     *
     * @return bool
     */
    public function removeFile(string $field): bool
    {
        if (Yii::$app instanceof Application) {
            $fs = new Filesystem();
            $fs->remove(Yii::$app->session->get($this->generateKey($field)));
            Yii::$app->session->set($this->generateKey($field), '');
        }

        return true;
    }
}


1			<?php
2
3			namespace yiicod\fileupload\models\behaviors;
4
5			use Symfony\Component\Filesystem\Filesystem;
6			use Yii;
7			use yii\db\ActiveRecord;
8			use yii\web\Application;
9
10			class TmpRepository implements TmpRepositoryInterface
11			{
12			/**
13			* @var ActiveRecord
14			*/
15			private $owner;
16
17			public function __construct($owner)
18			{
19			$this->owner = $owner;
20			}
21
22			/**
23			* Generate session key for file
24			*
25			* @param string $field Field name
26			*
27			* @return string
28			*/
29			public function generateKey(string $field): string
30			{
31			return 'file_' . get_class($this->owner)::tableName() . $field;
			0 ignored issues – show Bug introduced 2018-02-18 19:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `tableName` cannot be called on `get_class($this->owner)` (of type `string`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
32			}
33
34			/**
35			* Save file to session, after move to "getFilePath"
36			*
37			* @author Orlov Alexey <[email protected]>
38			*
39			* @param string $file
40			* @param string $field
41			*
42			* @return bool
43			*/
44			public function setFile(string $file, string $field): bool
45			{
46			if (Yii::$app instanceof Application) {
47			Yii::$app->session->set($this->generateKey($field), $file);
48			}
49
50			return true;
51			}
52
53			/**
54			* Get file by session key
55			*
56			* @param string $field
57			* @param bool $onlyName get only file name
			0 ignored issues – show Bug introduced 2018-02-18 19:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$onlyName`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
58			*
59			* @return string Return string
60			*/
61			public function getFile(string $field): string
62			{
63			if (Yii::$app instanceof Application) {
64			$file = Yii::$app->session->get($this->generateKey($field), '');
65
66			return $file;
67			}
68
69			return '';
70			}
71
72			public function getFileName(string $field): string
73			{
74			$file = $this->getFile($field);
75			$name = end(explode('/', $file));
			0 ignored issues – show Bug introduced 2018-02-18 19:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this `explode('/', $file)` cannot be passed to `end()` as the parameter `$array` expects a reference. Loading history...
76
77			return $name;
78			}
79
80			/**
81			* Remove file by session key
82			*
83			* @param string $field
84			*
85			* @return bool
86			*/
87			public function removeFile(string $field): bool
88			{
89			if (Yii::$app instanceof Application) {
90			$fs = new Filesystem();
91			$fs->remove(Yii::$app->session->get($this->generateKey($field)));
92			Yii::$app->session->set($this->generateKey($field), '');
93			}
94
95			return true;
96			}
97			}
98

yiicod / yii2-fileupload

Issues (28)

Security Analysis not enabled

models/behaviors/TmpRepository.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like