Scale::handle() - Code Metrics - yiicod/yii2-easyimage - Measure and Improve Code Quality continuously with Scrutinizer

Scale::handle() A
last analyzed 2018-02-18 19:03 UTC

↳ Parent: Scale

Complexity

Conditions	3
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
c	0
b	0
f	0
rs	9.4285
cc	3
eloc	5
nc	2
nop	2

<?php

namespace yiicod\easyimage\tools;

use Exception;
use Imagine\Image\ManipulatorInterface;
use yiicod\easyimage\base\ToolInterface;

/**
 * Class Scale
 * Scale image tool
 *
 * @author Virchenko Maksim <[email protected]>
 *
 * @package yiicod\easyimage\tools
 */
class Scale implements ToolInterface
{
    /**
     * Handle image
     *
     * @param ManipulatorInterface $image
     * @param array $params
     *
     * @return ManipulatorInterface
     *
     * @throws Exception
     */
    public static function handle(ManipulatorInterface $image, array $params = []): ManipulatorInterface
    {
        if (false === isset($params['width']) && false === isset($params['height'])) {
            throw new Exception('Params "width" or "height" is required for action "Scale"');
        }

        $image->getImagick()->scaleImage($params['width'] ?? 0, $params['height'] ?? 0);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        return $image;
    }
}


1			<?php
2
3			namespace yiicod\easyimage\tools;
4
5			use Exception;
6			use Imagine\Image\ManipulatorInterface;
7			use yiicod\easyimage\base\ToolInterface;
8
9			/**
10			* Class Scale
11			* Scale image tool
12			*
13			* @author Virchenko Maksim <[email protected]>
14			*
15			* @package yiicod\easyimage\tools
16			*/
17			class Scale implements ToolInterface
18			{
19			/**
20			* Handle image
21			*
22			* @param ManipulatorInterface $image
23			* @param array $params
24			*
25			* @return ManipulatorInterface
26			*
27			* @throws Exception
28			*/
29			public static function handle(ManipulatorInterface $image, array $params = []): ManipulatorInterface
30			{
31			if (false === isset($params['width']) && false === isset($params['height'])) {
32			throw new Exception('Params "width" or "height" is required for action "Scale"');
33			}
34
35			$image->getImagick()->scaleImage($params['width'] ?? 0, $params['height'] ?? 0);
			0 ignored issues – show Bug introduced 2018-02-18 19:03 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Imagine\Image\ManipulatorInterface` as the method `getImagick()` does only exist in the following implementations of said interface: `Imagine\Imagick\Image`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
36
37			return $image;
38			}
39			}
40

yiicod / yii2-easyimage

Scale::handle() A last analyzed 2018-02-18 19:03 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

Scale::handle() A
last analyzed 2018-02-18 19:03 UTC