Issues in FileOutput.php (master) - Issues in master - yiicod/yii2-cron - Measure and Improve Code Quality continuously with Scrutinizer

Issues (18)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

commands/FileOutput.php (12 issues)

Labels

Severity

Major 12

orlov 12

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @see http://www.yiiframework.com/
 *
 * @copyright Copyright (c) 2008 Yii Software LLC
 * @license http://www.yiiframework.com/license/
 */

namespace yiicod\cron\commands;

use yii\base\InvalidConfigException;

/**
 * FileOutput records log messages in a file.
 */
class FileOutput
{
    /**
     * @var string log file path or path alias. If not set, it will use the "@runtime/logs/app.log" file.
     * The directory containing the log files will be automatically created if not existing.
     */
    public $logFile;

    /**
     * @var int maximum log file size, in kilo-bytes. Defaults to 10240, meaning 10MB.
     */
    public $maxFileSize = 10240; // in KB
    /**
     * @var int number of log files used for rotation. Defaults to 5.
     */
    public $maxLogFiles = 5;

    /**
     * @var bool Whether to rotate log files by copy and truncate in contrast to rotation by
     * renaming files. Defaults to `true` to be more compatible with log tailers and is windows
     * systems which do not play well with rename on open files. Rotation by renaming however is
     * a bit faster.
     *
     * The problem with windows systems where the [rename()](http://www.php.net/manual/en/function.rename.php)
     * function does not work with files that are opened by some process is described in a
     * [comment by Martin Pelletier](http://www.php.net/manual/en/function.rename.php#102274) in
     * the PHP documentation. By setting rotateByCopy to `true` you can work
     * around this problem.
     */
    public $rotateByCopy = true;

    /**
     * Initializes the route.
     * This method is invoked after the route is created by the route manager.
     */
    public function __construct($logFile)
    {
        $this->logFile = $logFile;
    }

    /**
     * Writes log messages to a file.
     *
     * @throws InvalidConfigException if unable to open the log file for writing
     */
    public function stdout($text)
    {
        /* Disable empty output */
        if (empty($text)) {
            return;
        }
        $text = sprintf("\n---------------------------------\n%s Stack output:\n---------------------------------\n%s", date('Y-m-d H:i:s'), $text);
        if (false === ($fp = @fopen($this->logFile, 'a'))) {
            throw new InvalidConfigException("Unable to append to log file: {$this->logFile}");
        }
        @flock($fp, LOCK_EX);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        // clear stat cache to ensure getting the real current file size and not a cached one
        // this may result in rotating twice when cached file size is used on subsequent calls
        clearstatcache();

        if (@filesize($this->logFile) > $this->maxFileSize * 1024) {
            $this->rotateFiles();
            @flock($fp, LOCK_UN);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            @fclose($fp);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            @file_put_contents($this->logFile, $text, FILE_APPEND | LOCK_EX);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        } else {
            @fwrite($fp, $text);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            @flock($fp, LOCK_UN);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            @fclose($fp);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }
    }

    /**
     * Rotates log files.
     */
    protected function rotateFiles()
    {
        $file = $this->logFile;
        for ($i = $this->maxLogFiles; $i >= 0; --$i) {
            // $i == 0 is the original log file
            $rotateFile = $file . (0 === $i ? '' : '.' . $i);
            if (is_file($rotateFile)) {
                // suppress errors because it's possible multiple processes enter into this section
                if ($i === $this->maxLogFiles) {
                    @unlink($rotateFile);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
                } else {
                    if ($this->rotateByCopy) {
                        @copy($rotateFile, $file . '.' . ($i + 1));
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
                        if ($fp = @fopen($rotateFile, 'a')) {
                            @ftruncate($fp, 0);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
                            @fclose($fp);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
                        }
                    } else {
                        @rename($rotateFile, $file . '.' . ($i + 1));
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
                    }
                }
            }
        }
    }
}


1			<?php
2			/**
3			* @see http://www.yiiframework.com/
4			*
5			* @copyright Copyright (c) 2008 Yii Software LLC
6			* @license http://www.yiiframework.com/license/
7			*/
8
9			namespace yiicod\cron\commands;
10
11			use yii\base\InvalidConfigException;
12
13			/**
14			* FileOutput records log messages in a file.
15			*/
16			class FileOutput
17			{
18			/**
19			* @var string log file path or path alias. If not set, it will use the "@runtime/logs/app.log" file.
20			* The directory containing the log files will be automatically created if not existing.
21			*/
22			public $logFile;
23
24			/**
25			* @var int maximum log file size, in kilo-bytes. Defaults to 10240, meaning 10MB.
26			*/
27			public $maxFileSize = 10240; // in KB
28			/**
29			* @var int number of log files used for rotation. Defaults to 5.
30			*/
31			public $maxLogFiles = 5;
32
33			/**
34			* @var bool Whether to rotate log files by copy and truncate in contrast to rotation by
35			* renaming files. Defaults to `true` to be more compatible with log tailers and is windows
36			* systems which do not play well with rename on open files. Rotation by renaming however is
37			* a bit faster.
38			*
39			* The problem with windows systems where the [rename()](http://www.php.net/manual/en/function.rename.php)
40			* function does not work with files that are opened by some process is described in a
41			* [comment by Martin Pelletier](http://www.php.net/manual/en/function.rename.php#102274) in
42			* the PHP documentation. By setting rotateByCopy to `true` you can work
43			* around this problem.
44			*/
45			public $rotateByCopy = true;
46
47			/**
48			* Initializes the route.
49			* This method is invoked after the route is created by the route manager.
50			*/
51			public function __construct($logFile)
52			{
53			$this->logFile = $logFile;
54			}
55
56			/**
57			* Writes log messages to a file.
58			*
59			* @throws InvalidConfigException if unable to open the log file for writing
60			*/
61			public function stdout($text)
62			{
63			/* Disable empty output */
64			if (empty($text)) {
65			return;
66			}
67			$text = sprintf("\n---------------------------------\n%s Stack output:\n---------------------------------\n%s", date('Y-m-d H:i:s'), $text);
68			if (false === ($fp = @fopen($this->logFile, 'a'))) {
69			throw new InvalidConfigException("Unable to append to log file: {$this->logFile}");
70			}
71			@flock($fp, LOCK_EX);
			0 ignored issues – show Security Best Practice introduced 2018-02-18 18:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
72
73			// clear stat cache to ensure getting the real current file size and not a cached one
74			// this may result in rotating twice when cached file size is used on subsequent calls
75			clearstatcache();
76
77			if (@filesize($this->logFile) > $this->maxFileSize * 1024) {
78			$this->rotateFiles();
79			@flock($fp, LOCK_UN);
			0 ignored issues – show Security Best Practice introduced 2018-02-18 18:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
80			@fclose($fp);
			0 ignored issues – show Security Best Practice introduced 2018-02-18 18:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
81			@file_put_contents($this->logFile, $text, FILE_APPEND \| LOCK_EX);
			0 ignored issues – show Security Best Practice introduced 2018-02-18 18:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
82			} else {
83			@fwrite($fp, $text);
			0 ignored issues – show Security Best Practice introduced 2018-02-18 18:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
84			@flock($fp, LOCK_UN);
			0 ignored issues – show Security Best Practice introduced 2018-02-18 18:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
85			@fclose($fp);
			0 ignored issues – show Security Best Practice introduced 2018-02-18 18:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
86			}
87			}
88
89			/**
90			* Rotates log files.
91			*/
92			protected function rotateFiles()
93			{
94			$file = $this->logFile;
95			for ($i = $this->maxLogFiles; $i >= 0; --$i) {
96			// $i == 0 is the original log file
97			$rotateFile = $file . (0 === $i ? '' : '.' . $i);
98			if (is_file($rotateFile)) {
99			// suppress errors because it's possible multiple processes enter into this section
100			if ($i === $this->maxLogFiles) {
101			@unlink($rotateFile);
			0 ignored issues – show Security Best Practice introduced 2018-02-18 18:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
102			} else {
103			if ($this->rotateByCopy) {
104			@copy($rotateFile, $file . '.' . ($i + 1));
			0 ignored issues – show Security Best Practice introduced 2018-02-18 18:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
105			if ($fp = @fopen($rotateFile, 'a')) {
106			@ftruncate($fp, 0);
			0 ignored issues – show Security Best Practice introduced 2018-02-18 18:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
107			@fclose($fp);
			0 ignored issues – show Security Best Practice introduced 2018-02-18 18:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
108			}
109			} else {
110			@rename($rotateFile, $file . '.' . ($i + 1));
			0 ignored issues – show Security Best Practice introduced 2018-02-18 18:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
111			}
112			}
113			}
114			}
115			}
116			}
117

yiicod / yii2-cron

Issues (18)

Security Analysis not enabled

commands/FileOutput.php (12 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like