yiicod\base\traits\DataCacheTrait

Complexity

Total Complexity

7

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	keyDataCache()	0	8	2
A	getDataCache()	0	12	4
A	resetDataCache()	0	8	1

<?php

namespace yiicod\base\traits;

/**
 * Class DataCacheTrait
 * Deduplicate data resolver.
 *
 * @package yiicod\base\traits
 */
trait DataCacheTrait
{
    private static $dataCache = [];

    /**
     * @param array $values
     *
     * @return string
     */
    public static function keyDataCache($values = [])
    {
        if (is_array($values)) {
            return implode('', array_merge([__CLASS__], $values));
        }

        return __CLASS__ . $values;
    }

    /**
     * Get value by key. If value is not set then will be called callback
     *
     * @param string|array $key
     * @param callable $callback
     * @param bool $reset
     *
     * @return mixed
     */
    public static function getDataCache($key, $callback, $reset = false)
    {
        if (true === $reset) {
            self::resetDataCache($key);

It seems like $key defined by parameter $key on line 38 can also be of type array; however, yiicod\base\traits\DataCacheTrait::resetDataCache() does only seem to accept string, maybe add an additional type check?

        }
        $key = self::keyDataCache($key);

It seems like $key defined by self::keyDataCache($key) on line 43 can also be of type string; however, yiicod\base\traits\DataCacheTrait::keyDataCache() does only seem to accept array, maybe add an additional type check?

        if (false === array_key_exists($key, self::$dataCache) || true === $reset) {
            self::$dataCache[$key] = $callback();
        }

        return self::$dataCache[$key];
    }

    /**
     * Reset data by key
     *
     * @param string $key
     *
     * @return bool
     */
    public static function resetDataCache($key)
    {
        $key = self::keyDataCache($key);

$key is of type string, but the function expects a array.

        unset(self::$dataCache[$key]);

        return true;
    }
}