Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | View Code Duplication | class RequestPasswordResetAction extends Action |
|
1 ignored issue
–
show
|
|||
11 | { |
||
12 | const EVENT_AFTER_REQUEST_PASSWORD_RESET = 'afterRequestPasswordReset'; |
||
13 | const EVENT_BEFORE_REQUEST_PASSWORD_RESET = 'beforeRequestPasswordReset'; |
||
14 | const EVENT_ERROR_REQUEST_PASSWORD_RESET = 'errorRequestPasswordReset'; |
||
15 | |||
16 | public $view = '@yiicod/yii2-auth/views/webUser/requestPasswordResetToken'; |
||
17 | |||
18 | /** |
||
19 | * Model scenario |
||
20 | * @var |
||
21 | */ |
||
22 | public $scenario; |
||
23 | |||
24 | public function run() |
||
47 | |||
48 | public function trigger($name, Event $event = null) |
||
53 | } |
||
54 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.