Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
17 | class RoleController extends Controller |
||
18 | { |
||
19 | /** |
||
20 | * @var \yii\rbac\ManagerInterface |
||
21 | */ |
||
22 | private $_authManager; |
||
23 | |||
24 | /** |
||
25 | * @inheritdoc |
||
26 | */ |
||
27 | public function init() |
||
33 | |||
34 | /** |
||
35 | * Assign role to the user |
||
36 | * |
||
37 | * @param $roleName |
||
38 | * @param $email |
||
39 | * |
||
40 | * @return int |
||
41 | * |
||
42 | * @throws Exception |
||
43 | */ |
||
44 | View Code Duplication | public function actionAssign($roleName, $email) |
|
66 | |||
67 | /** |
||
68 | * Revoke role from the user |
||
69 | * |
||
70 | * @param $roleName |
||
71 | * @param $email |
||
72 | * |
||
73 | * @return int |
||
74 | * |
||
75 | * @throws Exception |
||
76 | */ |
||
77 | View Code Duplication | public function actionRevoke($roleName, $email) |
|
99 | |||
100 | /** |
||
101 | * Returns the named role. |
||
102 | * |
||
103 | * @param string $roleName |
||
104 | * |
||
105 | * @return Role |
||
106 | * |
||
107 | * @throws Exception |
||
108 | */ |
||
109 | protected function findRole($roleName) |
||
119 | } |
||
120 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.