Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
16 | class RouteController extends Controller |
||
17 | { |
||
18 | /** |
||
19 | * @var array route model class |
||
20 | */ |
||
21 | public $modelClass = [ |
||
22 | 'class' => RouteModel::class, |
||
23 | ]; |
||
24 | |||
25 | /** |
||
26 | * Returns a list of behaviors that this component should behave as. |
||
27 | * |
||
28 | * @return array |
||
29 | */ |
||
30 | public function behaviors(): array |
||
52 | |||
53 | /** |
||
54 | * Lists all Route models. |
||
55 | * |
||
56 | * @return mixed |
||
57 | */ |
||
58 | public function actionIndex() |
||
64 | |||
65 | /** |
||
66 | * Assign routes |
||
67 | * |
||
68 | * @return array |
||
69 | */ |
||
70 | View Code Duplication | public function actionAssign(): array |
|
78 | |||
79 | /** |
||
80 | * Remove routes |
||
81 | * |
||
82 | * @return array |
||
83 | */ |
||
84 | View Code Duplication | public function actionRemove(): array |
|
92 | |||
93 | /** |
||
94 | * Refresh cache of routes |
||
95 | * |
||
96 | * @return array |
||
97 | */ |
||
98 | public function actionRefresh(): array |
||
105 | } |
||
106 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.