paytext.paytext.PaymentText.clean() - Code Metrics - Inspection of "Refactor/rename" - yhoiseth/paytext - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#17)

by Yngve

created 2018-07-19 11:06 UTC

paytext.paytext.PaymentText.clean() C

↳ Parent: paytext.paytext

Complexity

Conditions

Size

Total Lines	50
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	33
dl	0
loc	50
rs	5.9999
c	0
b	0
f	0
cc	10
nop	1

How to fix Complexity

# pyre-strict
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

from re import compile as compile_regex
from typing import List, Any

import iso4217parse


class PaymentText:
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    text: str = ''

    def __init__(self, text: str) -> None:
        self.text = text

    def __repr__(self) -> str:
        return self.text

    def clean(self) -> None:
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        parts: List[str] = self.text.split()

        pattern = compile_regex(r'\*\d{4}')

        try:
            if pattern.match(parts[0]):

                del parts[0]
        except IndexError:
            return

        pattern = compile_regex(r'\d{2}\.\d{2}')

        if pattern.match(parts[0]):
            del parts[0]

        currency: Any = iso4217parse.by_alpha3(parts[0])

        if isinstance(currency, iso4217parse.Currency):

            del parts[0]
            del parts[0]

        pattern = compile_regex(r'\d{1}\.\d{4}')

        if pattern.match(parts[-1]):
            del parts[-1]
            del parts[-1]

        pattern = compile_regex(r'\d{2}\.\d{2}\.\d{2}')

        if pattern.match(parts[-1]):
            del parts[-1]

            pattern = compile_regex(r'.+:')

            if pattern.match(parts[-1]):
                del parts[-1]

        pattern = compile_regex(r'\d+,\d{2}')

        if pattern.match(parts[-1]):
            del parts[-1]

            currency: Any = iso4217parse.by_alpha3(parts[-1])
            if isinstance(currency, iso4217parse.Currency):
                del parts[-1]

        text = ' '.join(parts)

        self.text = text


1			# pyre-strict
			0 ignored issues – show Coding Style introduced 2018-07-19 11:09 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2
3			from re import compile as compile_regex
4			from typing import List, Any
5
6			import iso4217parse
7
8
9			class PaymentText:
			0 ignored issues – show Coding Style introduced 2018-07-16 21:22 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
10			text: str = ''
11
12			def __init__(self, text: str) -> None:
13			self.text = text
14
15			def __repr__(self) -> str:
16			return self.text
17
18			def clean(self) -> None:
			0 ignored issues – show Coding Style introduced 2018-07-16 21:22 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
19			parts: List[str] = self.text.split()
20
21			pattern = compile_regex(r'\*\d{4}')
22
23			try:
24			if pattern.match(parts[0]):
			1 ignored issue – show Comprehensibility Best Practice introduced 2018-07-07 18:42 UTC by Report Bug Copy Issue Report The variable `parts` does not seem to be defined. Loading history...
25			del parts[0]
26			except IndexError:
27			return
28
29			pattern = compile_regex(r'\d{2}\.\d{2}')
30
31			if pattern.match(parts[0]):
32			del parts[0]
33
34			currency: Any = iso4217parse.by_alpha3(parts[0])
35
36			if isinstance(currency, iso4217parse.Currency):
			1 ignored issue – show Comprehensibility Best Practice introduced 2018-07-07 18:42 UTC by Report Bug Copy Issue Report The variable `currency` does not seem to be defined. Loading history...
37			del parts[0]
38			del parts[0]
39
40			pattern = compile_regex(r'\d{1}\.\d{4}')
41
42			if pattern.match(parts[-1]):
43			del parts[-1]
44			del parts[-1]
45
46			pattern = compile_regex(r'\d{2}\.\d{2}\.\d{2}')
47
48			if pattern.match(parts[-1]):
49			del parts[-1]
50
51			pattern = compile_regex(r'.+:')
52
53			if pattern.match(parts[-1]):
54			del parts[-1]
55
56			pattern = compile_regex(r'\d+,\d{2}')
57
58			if pattern.match(parts[-1]):
59			del parts[-1]
60
61			currency: Any = iso4217parse.by_alpha3(parts[-1])
62			if isinstance(currency, iso4217parse.Currency):
63			del parts[-1]
64
65			text = ' '.join(parts)
66
67			self.text = text
68

yhoiseth / paytext

GitHub Access Token became invalid

Pull Request — master (#17)

paytext.paytext.PaymentText.clean() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Complexity

Duplication Side-by-Side

Filter issues like