Issues in JobsManager.php (next) - Issues in next - yawik/StackoverflowApi - Measure and Improve Code Quality continuously with Scrutinizer

Issues (9)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Service/JobsManager.php (1 issue)

Labels

Unused Code 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * YAWIK Stackoverflow API
 *
 * @filesource
 * @license MIT
 * @copyright  2016 - 2017 Cross Solution <http://cross-solution.de>
 */
  
/** */
namespace StackoverflowApi\Service;

use Doctrine\ODM\MongoDB\DocumentRepository;
use Jobs\Entity\JobInterface;
use StackoverflowApi\Client\Client;
use StackoverflowApi\Entity\ApiResponse;
use StackoverflowApi\Entity\JobData;
use Zend\Log\LoggerAwareInterface;
use Zend\Log\LoggerAwareTrait;

/**
 * Manager for job listings on stackoverflow.
 * 
 * @author Mathias Gelhausen <[email protected]>
 * @since 0.1.0
 */
class JobsManager implements LoggerAwareInterface
{
    use LoggerAwareTrait;

    /**
     * Stackoverflow client.
     *
     * @var \StackoverflowApi\Client\Client
     */
    private $client;

    /**
     * Creates a job manager instance.
     *
     * @param Client $client
     */
    public function __construct(Client $client)
    {
        $this->client = $client;
    }

    /**
     * Send a job to stackoverflow.
     *
     * Determines automatically, wether the job needs to be posted or updated.
     *
     * @param JobInterface $job
     * @param array        $data
     *
     * @return bool
     */
    public function send(JobInterface $job, $data)
    {

        /* @var \StackoverflowApi\Entity\JobData $jobData */

        $log = $this->getLogger();
        $log->info('Send Job: ' . $job->getId());
        $status = true;

        $jobData = $job->hasAttachedEntity('stackoverflow') ? $job->getAttachedEntity('stackoverflow') : $job->createAttachedEntity(JobData::class, ['jobId' => $job->getId()], 'stackoverflow');

        if ($jobData->isOnline()) {
            $data['action'] = 'put';
            $data['externalId'] = $jobData->getExternalId();
            $log->debug('--> Job is already online: External id ' . $jobData->getExternalId() . ': update');
        } else {
            $data['action'] = 'post';
            $log->debug('--> Job is not online: insert');
        }

        $log->debug('--> data:' , $data);
        $response = $this->client->sendJob($job, $data);

        $apiResponse = new ApiResponse($response);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $result   = $response->getXml();
        if ($result) {
            //$result = $result->response;
            if ('success' == $result->result) {
                $jobData->setExternalId($result->jobid)
                        ->setExternalUrl($result->joburl)
                        ->setIsOnline(true);
                $log->info('==> Successfully send ' . $job->getId(), ['id' => $result->jobid, 'url' => $result->joburl]);

            } else {
                $status = false;
                $log->err('==> Sending job ' . $job->getId() . ' failed.');
                $errors = (array) $result->errors->error;
                $log->debug($response->getStatusCode() . ': ' . $response->getReasonPhrase(), ['errors' => $errors, 'body' => $response->getBody()]);
            }
        } else {
            $status = false;
            $log->err('==> Unexpected error: ' . $response->getStatusCode() . ' ' . $response->getReasonPhrase());
            $log->debug($response->getBody());
        }

        /* temporarely disabled due to encondig issues. */
        /*$jobData->addResponse($apiResponse);*/

        return $status;
    }

    /**
     * Delete a job from stackoverflow
     *
     * @param JobInterface $job
     *
     * @return bool
     */
    public function remove(JobInterface $job)
    {
        /* @var \StackoverflowApi\Entity\JobData $jobData */
        $jobData = $job->getAttachedEntity('stackoverflow');

        if ($jobData->isOnline()) {
            $response = $this->client->deleteJob($jobData->getExternalId());

            $apiResponse = new ApiResponse($response);

            $jobData->addResponse($apiResponse);

            $result = $response->getXml();
            if ($result && 'success' == $result->result) {
                $jobData->setIsOnline(false);
                return true;
            }
        }

        return false;
    }
}

1		<?php
2		/**
3		* YAWIK Stackoverflow API
4		*
5		* @filesource
6		* @license MIT
7		* @copyright 2016 - 2017 Cross Solution <http://cross-solution.de>
8		*/
9
10		/** */
11		namespace StackoverflowApi\Service;
12
13		use Doctrine\ODM\MongoDB\DocumentRepository;
14		use Jobs\Entity\JobInterface;
15		use StackoverflowApi\Client\Client;
16		use StackoverflowApi\Entity\ApiResponse;
17		use StackoverflowApi\Entity\JobData;
18		use Zend\Log\LoggerAwareInterface;
19		use Zend\Log\LoggerAwareTrait;
20
21		/**
22		* Manager for job listings on stackoverflow.
23		*
24		* @author Mathias Gelhausen <[email protected]>
25		* @since 0.1.0
26		*/
27		class JobsManager implements LoggerAwareInterface
28		{
29		use LoggerAwareTrait;
30
31		/**
32		* Stackoverflow client.
33		*
34		* @var \StackoverflowApi\Client\Client
35		*/
36		private $client;
37
38		/**
39		* Creates a job manager instance.
40		*
41		* @param Client $client
42		*/
43	10	public function __construct(Client $client)
44		{
45	10	$this->client = $client;
46	10	}
47
48		/**
49		* Send a job to stackoverflow.
50		*
51		* Determines automatically, wether the job needs to be posted or updated.
52		*
53		* @param JobInterface $job
54		* @param array $data
55		*
56		* @return bool
57		*/
58	6	public function send(JobInterface $job, $data)
59		{
60
61		/* @var \StackoverflowApi\Entity\JobData $jobData */
62
63	6	$log = $this->getLogger();
64	6	$log->info('Send Job: ' . $job->getId());
65	6	$status = true;
66
67	6	$jobData = $job->hasAttachedEntity('stackoverflow') ? $job->getAttachedEntity('stackoverflow') : $job->createAttachedEntity(JobData::class, ['jobId' => $job->getId()], 'stackoverflow');
68
69	6	if ($jobData->isOnline()) {
70	1	$data['action'] = 'put';
71	1	$data['externalId'] = $jobData->getExternalId();
72	1	$log->debug('--> Job is already online: External id ' . $jobData->getExternalId() . ': update');
73	1	} else {
74	5	$data['action'] = 'post';
75	5	$log->debug('--> Job is not online: insert');
76		}
77
78	6	$log->debug('--> data:' , $data);
79	6	$response = $this->client->sendJob($job, $data);
80
81	6	$apiResponse = new ApiResponse($response);
		0 ignored issues – show Unused Code introduced 2017-10-27 15:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$apiResponse` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
82
83	6	$result = $response->getXml();
84	6	if ($result) {
85		//$result = $result->response;
86	2	if ('success' == $result->result) {
87	1	$jobData->setExternalId($result->jobid)
88	1	->setExternalUrl($result->joburl)
89	1	->setIsOnline(true);
90	1	$log->info('==> Successfully send ' . $job->getId(), ['id' => $result->jobid, 'url' => $result->joburl]);
91
92	1	} else {
93	1	$status = false;
94	1	$log->err('==> Sending job ' . $job->getId() . ' failed.');
95	1	$errors = (array) $result->errors->error;
96	1	$log->debug($response->getStatusCode() . ': ' . $response->getReasonPhrase(), ['errors' => $errors, 'body' => $response->getBody()]);
97		}
98	2	} else {
99	4	$status = false;
100	4	$log->err('==> Unexpected error: ' . $response->getStatusCode() . ' ' . $response->getReasonPhrase());
101	4	$log->debug($response->getBody());
102		}
103
104		/* temporarely disabled due to encondig issues. */
105		/$jobData->addResponse($apiResponse);/
106
107	6	return $status;
108		}
109
110		/**
111		* Delete a job from stackoverflow
112		*
113		* @param JobInterface $job
114		*
115		* @return bool
116		*/
117	3	public function remove(JobInterface $job)
118		{
119		/* @var \StackoverflowApi\Entity\JobData $jobData */
120	3	$jobData = $job->getAttachedEntity('stackoverflow');
121
122	3	if ($jobData->isOnline()) {
123	2	$response = $this->client->deleteJob($jobData->getExternalId());
124
125	2	$apiResponse = new ApiResponse($response);
126
127	2	$jobData->addResponse($apiResponse);
128
129	2	$result = $response->getXml();
130	2	if ($result && 'success' == $result->result) {
131	1	$jobData->setIsOnline(false);
132	1	return true;
133		}
134	1	}
135
136	2	return false;
137		}
138		}

yawik / StackoverflowApi

Issues (9)

Security Analysis no request data

src/Service/JobsManager.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like