yaroslawww / laravel-geonames

src/Console/Commands/LoadDataToDBCommand.php

<?php

namespace LaraGeoData\Console\Commands;

use Illuminate\Console\Command;
use Illuminate\Filesystem\Filesystem;

class LoadDataToDBCommand extends Command
{
    use HasTablesClassesMap, HasSuffixOption;

    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'geonames:import:file-to-db
        {type : Migration type. }
        {file? : Csv file path. }
        {--suffix= : Suffix used for specify country if need. }
        {--truncate : Truncate table before import. }
    ';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Upload data from csv file to DB.';

    /**
     * The filesystem instance.
     *
     * @var Filesystem
     */
    protected Filesystem $files;

    /**
     * Create a new command instance.
     *
     * @param Filesystem $files
     *
     * @return void
     */
    public function __construct(Filesystem $files)
    {
        parent::__construct();

        $this->files = $files;
    }

    public function handle()
    {
        $this->makeTableObjectNameByType($this->argument('type'), $this->files)

It seems like $this->argument('type') can also be of type array and null; however, parameter $type of LaraGeoData\Console\Commands\LoadDataToDBCommand::makeTableObjectNameByType() does only seem to accept string, maybe add an additional type check?

             ->loadData(
                 $this->argument('file'),

It seems like $this->argument('file') can also be of type array; however, parameter $filePath of LaraGeoData\Database\Tables\GeoTable::loadData() does only seem to accept null|string, maybe add an additional type check?

                 $this->getSuffix(),
                 (bool) $this->option('truncate')
             );

        return 0;
    }
}