LaraGeoData\GeoDataImporter

Complexity

Total Complexity

7

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Test Coverage

Coverage

84.62%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	extractFile()	0	3	1
A	truncateStorage()	0	3	1
A	storeFileFromUrl()	0	11	4

<?php

namespace LaraGeoData;

use Illuminate\Contracts\Container\Container;
use LaraGeoData\Storage\FilesystemStorage;

class GeoDataImporter
{
    protected FilesystemStorage $storage;

    public function __construct(Container $app)
    {
        $this->storage = new FilesystemStorage($app['files'], $app['config']->get('geonames.storage.path'));
    }

    public function storeFileFromUrl(string $url, ?string $name, ?\Closure $progressCallback = null, bool $force = false): bool
    {
        if (!($exists = $this->storage->exists($name)) || $force) {

It seems like $name can also be of type null; however, parameter $filePath of LaraGeoData\Storage\FilesystemStorage::exists() does only seem to accept string, maybe add an additional type check?

            if ($exists) {
                $this->storage->delete($name);

It seems like $name can also be of type null; however, parameter $filePath of LaraGeoData\Storage\FilesystemStorage::delete() does only seem to accept string, maybe add an additional type check?

            }

            return $this->storage->storeFromUrl($url, $name, $progressCallback);
        }

        return false;
    }

    /**
     * @param string $file
     *
     * @return bool
     * @throws \Exception
     */
    public function extractFile(string $file): bool
    {
        return $this->storage->extractZipFile($file);
    }

    /**
     * @return bool
     * @throws \Exception
     */
    public function truncateStorage(): bool
    {
        return $this->storage->truncate();
    }
}