yarhon / RouteGuardBundle

DependencyInjection/Container/ForeignExtensionAccessor.php

<?php

/*
 *
 * (c) Yaroslav Honcharuk <yaroslav.xs@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Yarhon\RouteGuardBundle\DependencyInjection\Container;

use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
use Symfony\Component\DependencyInjection\Extension\ConfigurationExtensionInterface;
use Symfony\Component\Config\Definition\Processor;
use Symfony\Component\Config\Definition\Exception\Exception as ConfigDefinitionException;
use Yarhon\RouteGuardBundle\Exception\LogicException;

/**
 * @author Yaroslav Honcharuk <yaroslav.xs@gmail.com>
 */
class ForeignExtensionAccessor
{
    /**
     * @var Processor
     */
    private $processor;

    /**
     * @param Processor|null $processor
     */
    public function __construct(Processor $processor = null)
    {
        $this->processor = $processor ?: new Processor();
    }

    /**
     * Returns processed config of a foreign extension outside of it's context.
     *
     * @param ContainerBuilder   $container
     * @param ExtensionInterface $extension
     *
     * @return array Processed configuration
     *
     * @throws LogicException When extension configuration class in not an instance of ConfigurationExtensionInterface
     */
    public function getProcessedConfig(ContainerBuilder $container, ExtensionInterface $extension)
    {
        if (!($extension instanceof ConfigurationExtensionInterface)) {
            throw new LogicException(sprintf('"%s" extension class is not an instance of %s.',
                $extension->getAlias(), ConfigurationExtensionInterface::class));
        }

        $configuration = $extension->getConfiguration([], $container);
        $configs = $container->getExtensionConfig($extension->getAlias());

        try {
            $processed = $this->processor->processConfiguration($configuration, $configs);

It seems like $configuration can also be of type null; however, parameter $configuration of Symfony\Component\Config\Definition\Processor::processConfiguration() does only seem to accept Symfony\Component\Config\Definition\ConfigurationInterface, maybe add an additional type check?

        } catch (ConfigDefinitionException $e) {
            throw new LogicException(sprintf('Cannot read configuration of the "%s" extension because of configuration exception.', $extension->getAlias()), 0, $e);
        }

        return $processed;
    }
}