Issues in MiniShortcut.php (master) - Issues in master - yansongda/pay - Measure and Improve Code Quality continuously with Scrutinizer

Issues (93)

src/Shortcut/Wechat/MiniShortcut.php (1 issue)

Labels

Severity

Major 1

<?php

declare(strict_types=1);

namespace Yansongda\Pay\Shortcut\Wechat;

use Yansongda\Artful\Contract\ShortcutInterface;
use Yansongda\Artful\Plugin\AddPayloadBodyPlugin;
use Yansongda\Artful\Plugin\ParserPlugin;
use Yansongda\Pay\Plugin\Wechat\AddRadarPlugin;
use Yansongda\Pay\Plugin\Wechat\ResponsePlugin;
use Yansongda\Pay\Plugin\Wechat\StartPlugin;
use Yansongda\Pay\Plugin\Wechat\V3\AddPayloadSignaturePlugin;
use Yansongda\Pay\Plugin\Wechat\V3\Pay\Mini\InvokePlugin;
use Yansongda\Pay\Plugin\Wechat\V3\Pay\Mini\PayPlugin;
use Yansongda\Pay\Plugin\Wechat\V3\VerifySignaturePlugin;

class MiniShortcut implements ShortcutInterface
{
    public function getPlugins(array $params): array
    {
        return [
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
            StartPlugin::class,
            PayPlugin::class,
            AddPayloadBodyPlugin::class,
            AddPayloadSignaturePlugin::class,
            AddRadarPlugin::class,
            InvokePlugin::class,
            VerifySignaturePlugin::class,
            ResponsePlugin::class,
            ParserPlugin::class,
        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yansongda\Pay\Shortcut\Wechat;
6
7			use Yansongda\Artful\Contract\ShortcutInterface;
8			use Yansongda\Artful\Plugin\AddPayloadBodyPlugin;
9			use Yansongda\Artful\Plugin\ParserPlugin;
10			use Yansongda\Pay\Plugin\Wechat\AddRadarPlugin;
11			use Yansongda\Pay\Plugin\Wechat\ResponsePlugin;
12			use Yansongda\Pay\Plugin\Wechat\StartPlugin;
13			use Yansongda\Pay\Plugin\Wechat\V3\AddPayloadSignaturePlugin;
14			use Yansongda\Pay\Plugin\Wechat\V3\Pay\Mini\InvokePlugin;
15			use Yansongda\Pay\Plugin\Wechat\V3\Pay\Mini\PayPlugin;
16			use Yansongda\Pay\Plugin\Wechat\V3\VerifySignaturePlugin;
17
18			class MiniShortcut implements ShortcutInterface
19			{
20			public function getPlugins(array $params): array
21			{
22			return [
			0 ignored issues – show Bug Best Practice introduced 2024-02-29 11:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return array(Yansongda\P...in\ParserPlugin::class)` returns the type `array<integer,string>` which is incompatible with the return type mandated by `Yansongda\Artful\Contrac...Interface::getPlugins()` of `Yansongda\Artful\Contract\PluginInterface[]`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
23			StartPlugin::class,
24			PayPlugin::class,
25			AddPayloadBodyPlugin::class,
26			AddPayloadSignaturePlugin::class,
27			AddRadarPlugin::class,
28			InvokePlugin::class,
29			VerifySignaturePlugin::class,
30			ResponsePlugin::class,
31			ParserPlugin::class,
32			];
33			}
34			}
35

yansongda / pay

Issues (93)

src/Shortcut/Wechat/MiniShortcut.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like