Issues in WebShortcut.php (master) - Issues in master - yansongda/pay - Measure and Improve Code Quality continuously with Scrutinizer

Issues (93)

src/Shortcut/Alipay/WebShortcut.php (1 issue)

Labels

Severity

Major 1

<?php

declare(strict_types=1);

namespace Yansongda\Pay\Shortcut\Alipay;

use Yansongda\Artful\Contract\ShortcutInterface;
use Yansongda\Artful\Plugin\ParserPlugin;
use Yansongda\Pay\Plugin\Alipay\V2\AddPayloadSignaturePlugin;
use Yansongda\Pay\Plugin\Alipay\V2\AddRadarPlugin;
use Yansongda\Pay\Plugin\Alipay\V2\FormatPayloadBizContentPlugin;
use Yansongda\Pay\Plugin\Alipay\V2\Pay\Web\PayPlugin;
use Yansongda\Pay\Plugin\Alipay\V2\ResponseHtmlPlugin;
use Yansongda\Pay\Plugin\Alipay\V2\StartPlugin;

class WebShortcut implements ShortcutInterface
{
    public function getPlugins(array $params): array
    {
        return [
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
            StartPlugin::class,
            PayPlugin::class,
            FormatPayloadBizContentPlugin::class,
            AddPayloadSignaturePlugin::class,
            AddRadarPlugin::class,
            ResponseHtmlPlugin::class,
            ParserPlugin::class,
        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yansongda\Pay\Shortcut\Alipay;
6
7			use Yansongda\Artful\Contract\ShortcutInterface;
8			use Yansongda\Artful\Plugin\ParserPlugin;
9			use Yansongda\Pay\Plugin\Alipay\V2\AddPayloadSignaturePlugin;
10			use Yansongda\Pay\Plugin\Alipay\V2\AddRadarPlugin;
11			use Yansongda\Pay\Plugin\Alipay\V2\FormatPayloadBizContentPlugin;
12			use Yansongda\Pay\Plugin\Alipay\V2\Pay\Web\PayPlugin;
13			use Yansongda\Pay\Plugin\Alipay\V2\ResponseHtmlPlugin;
14			use Yansongda\Pay\Plugin\Alipay\V2\StartPlugin;
15
16			class WebShortcut implements ShortcutInterface
17			{
18			public function getPlugins(array $params): array
19			{
20			return [
			0 ignored issues – show Bug Best Practice introduced 2024-01-11 12:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return array(Yansongda\P...in\ParserPlugin::class)` returns the type `array<integer,string>` which is incompatible with the return type mandated by `Yansongda\Artful\Contrac...Interface::getPlugins()` of `Yansongda\Artful\Contract\PluginInterface[]`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
21			StartPlugin::class,
22			PayPlugin::class,
23			FormatPayloadBizContentPlugin::class,
24			AddPayloadSignaturePlugin::class,
25			AddRadarPlugin::class,
26			ResponseHtmlPlugin::class,
27			ParserPlugin::class,
28			];
29			}
30			}
31

yansongda / pay

Issues (93)

src/Shortcut/Alipay/WebShortcut.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like