QueryShortcut - Code Metrics - Inspection of "feat: 银联支付" - yansongda/pay - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#662)

by Songda

created 2022-09-16 16:32 UTC

QueryShortcut A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	6
eloc	13
c	2
b	0
f	0
dl	0
loc	38
rs	10

4 Methods

Rating	Name	Size	Complexity
A	defaultPlugins()	4	1
A	refundPlugins()	4	1
A	getPlugins()	13	3
A	combinePlugins()	4	1

<?php

declare(strict_types=1);

namespace Yansongda\Pay\Plugin\Wechat\Shortcut;

use Yansongda\Pay\Contract\ShortcutInterface;
use Yansongda\Pay\Exception\Exception;
use Yansongda\Pay\Exception\InvalidParamsException;
use Yansongda\Pay\Plugin\Wechat\Pay\Common\FindRefundPlugin;
use Yansongda\Pay\Plugin\Wechat\Pay\Common\QueryPlugin;
use Yansongda\Supports\Str;

class QueryShortcut implements ShortcutInterface
{
    /**
     * @throws \Yansongda\Pay\Exception\InvalidParamsException
     */
    public function getPlugins(array $params): array
    {
        if (isset($params['combine_out_trade_no'])) {
            return $this->combinePlugins();
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
        }

        $typeMethod = Str::camel($params['_type'] ?? 'default').'Plugins';

        if (method_exists($this, $typeMethod)) {
            return $this->{$typeMethod}();
        }

        throw new InvalidParamsException(Exception::SHORTCUT_MULTI_TYPE_ERROR, "Query type [$typeMethod] not supported");
    }

    protected function defaultPlugins(): array
    {
        return [
            QueryPlugin::class,
        ];
    }

    protected function refundPlugins(): array
    {
        return [
            FindRefundPlugin::class,
        ];
    }

    protected function combinePlugins(): array
    {
        return [
            \Yansongda\Pay\Plugin\Wechat\Pay\Combine\QueryPlugin::class,
        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yansongda\Pay\Plugin\Wechat\Shortcut;
6
7			use Yansongda\Pay\Contract\ShortcutInterface;
8			use Yansongda\Pay\Exception\Exception;
9			use Yansongda\Pay\Exception\InvalidParamsException;
10			use Yansongda\Pay\Plugin\Wechat\Pay\Common\FindRefundPlugin;
11			use Yansongda\Pay\Plugin\Wechat\Pay\Common\QueryPlugin;
12			use Yansongda\Supports\Str;
13
14			class QueryShortcut implements ShortcutInterface
15			{
16			/**
17			* @throws \Yansongda\Pay\Exception\InvalidParamsException
18			*/
19			public function getPlugins(array $params): array
20			{
21			if (isset($params['combine_out_trade_no'])) {
22			return $this->combinePlugins();
			0 ignored issues – show Bug Best Practice introduced 2021-06-21 08:24 UTC by Report Bug Copy Issue Report The expression `return $this->combinePlugins()` returns the type `array<integer,string>` which is incompatible with the return type mandated by `Yansongda\Pay\Contract\S...Interface::getPlugins()` of `Yansongda\Pay\Contract\PluginInterface[]`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
23			}
24
25			$typeMethod = Str::camel($params['_type'] ?? 'default').'Plugins';
26
27			if (method_exists($this, $typeMethod)) {
28			return $this->{$typeMethod}();
29			}
30
31			throw new InvalidParamsException(Exception::SHORTCUT_MULTI_TYPE_ERROR, "Query type [$typeMethod] not supported");
32			}
33
34			protected function defaultPlugins(): array
35			{
36			return [
37			QueryPlugin::class,
38			];
39			}
40
41			protected function refundPlugins(): array
42			{
43			return [
44			FindRefundPlugin::class,
45			];
46			}
47
48			protected function combinePlugins(): array
49			{
50			return [
51			\Yansongda\Pay\Plugin\Wechat\Pay\Combine\QueryPlugin::class,
52			];
53			}
54			}
55

yansongda / pay

Pull Request — master (#662)

QueryShortcut A

Complexity

Size/Duplication

Importance

4 Methods

Duplication Side-by-Side

Filter issues like