PapayApplyShortcut - Code Metrics - Inspection of "feat: 增加委托代扣 shortcut" - yansongda/pay - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#773)

by Songda

created 2023-04-09 15:38 UTC

PapayApplyShortcut A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	9
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	6
c	2
b	0
f	0
dl	0
loc	9
rs	10
wmc	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	getPlugins()	0	7	1

<?php

declare(strict_types=1);

namespace Yansongda\Pay\Plugin\Wechat\Shortcut;

use Yansongda\Pay\Contract\ShortcutInterface;
use Yansongda\Pay\Plugin\ParserPlugin;
use Yansongda\Pay\Plugin\Wechat\Papay\ApplyPlugin;
use Yansongda\Pay\Plugin\Wechat\PreparePlugin;
use Yansongda\Pay\Plugin\Wechat\RadarSignPlugin;

/**
 * 申请代扣.
 *
 * @see https://pay.weixin.qq.com/wiki/doc/api/wxpay_v2/papay/chapter3_8.shtml
 */
class PapayApplyShortcut implements ShortcutInterface
{
    public function getPlugins(array $params): array
    {
        return [
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
            PreparePlugin::class,
            ApplyPlugin::class,
            RadarSignPlugin::class,
            ParserPlugin::class,
        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yansongda\Pay\Plugin\Wechat\Shortcut;
6
7			use Yansongda\Pay\Contract\ShortcutInterface;
8			use Yansongda\Pay\Plugin\ParserPlugin;
9			use Yansongda\Pay\Plugin\Wechat\Papay\ApplyPlugin;
10			use Yansongda\Pay\Plugin\Wechat\PreparePlugin;
11			use Yansongda\Pay\Plugin\Wechat\RadarSignPlugin;
12
13			/**
14			* 申请代扣.
15			*
16			* @see https://pay.weixin.qq.com/wiki/doc/api/wxpay_v2/papay/chapter3_8.shtml
17			*/
18			class PapayApplyShortcut implements ShortcutInterface
19			{
20			public function getPlugins(array $params): array
21			{
22			return [
			0 ignored issues – show Bug Best Practice introduced 2023-04-08 08:39 UTC by Report Bug Copy Issue Report The expression `return array(Yansongda\P...in\ParserPlugin::class)` returns the type `array<integer,string>` which is incompatible with the return type mandated by `Yansongda\Pay\Contract\S...Interface::getPlugins()` of `Yansongda\Pay\Contract\PluginInterface[]`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
23			PreparePlugin::class,
24			ApplyPlugin::class,
25			RadarSignPlugin::class,
26			ParserPlugin::class,
27			];
28			}
29			}
30

yansongda / pay

Pull Request — master (#773)

PapayApplyShortcut A

Complexity

Size/Duplication

Importance

1 Method

Duplication Side-by-Side

Filter issues like