RadarSignPlugin::v2PayloadToString() - Code Metrics - Inspection of "refactor: 优化现有微信v2插件代码" - yansongda/pay - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#772)

by Songda

created 2023-04-09 14:12 UTC

RadarSignPlugin::v2PayloadToString() A

↳ Parent: RadarSignPlugin

Complexity

Conditions	5
Paths	7

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	5
c	0
b	0
f	0
nc	7
nop	1
dl	0
loc	11
rs	9.6111

<?php

declare(strict_types=1);

namespace Yansongda\Pay\Plugin\Wechat;

use Closure;
use GuzzleHttp\Psr7\Utils;
use Psr\Http\Message\RequestInterface;
use Yansongda\Pay\Contract\PluginInterface;
use Yansongda\Pay\Exception\ContainerException;
use Yansongda\Pay\Exception\Exception;
use Yansongda\Pay\Exception\InvalidConfigException;
use Yansongda\Pay\Exception\InvalidParamsException;
use Yansongda\Pay\Exception\ServiceNotFoundException;
use Yansongda\Pay\Logger;
use Yansongda\Pay\Packer\JsonPacker;
use Yansongda\Pay\Packer\XmlPacker;
use Yansongda\Pay\Rocket;
use Yansongda\Supports\Collection;
use Yansongda\Supports\Str;

use function Yansongda\Pay\get_public_cert;
use function Yansongda\Pay\get_wechat_config;
use function Yansongda\Pay\get_wechat_sign;
use function Yansongda\Pay\get_wechat_sign_v2;

class RadarSignPlugin implements PluginInterface
{
    protected JsonPacker $jsonPacker;

    protected XmlPacker $xmlPacker;

    public function __construct(JsonPacker $jsonPacker, XmlPacker $xmlPacker)
    {
        $this->jsonPacker = $jsonPacker;
        $this->xmlPacker = $xmlPacker;
    }

    /**
     * @throws ContainerException
     * @throws InvalidConfigException
     * @throws InvalidParamsException
     * @throws ServiceNotFoundException
     */
    public function assembly(Rocket $rocket, Closure $next): Rocket
    {
        Logger::debug('[wechat][RadarSignPlugin] 插件开始装载', ['rocket' => $rocket]);

        switch ($rocket->getParams()['_version'] ?? 'default') {
            case 'v2':
                $radar = $this->v2($rocket);

                break;

            default:
                $radar = $this->v3($rocket);

                break;
        }

        $rocket->setRadar($radar);

        Logger::info('[wechat][RadarSignPlugin] 插件装载完毕', ['rocket' => $rocket]);

        return $next($rocket);
    }

    /**
     * @throws ContainerException
     * @throws ServiceNotFoundException
     * @throws InvalidConfigException
     * @throws \Exception
     */
    protected function v2(Rocket $rocket): RequestInterface
    {
        $rocket->mergePayload(['nonce_str' => Str::random(32)]);
        $rocket->mergePayload([
            'sign' => get_wechat_sign_v2($rocket->getParams(), $rocket->getPayload()->all()),
        ]);

        return $rocket->getRadar()->withBody(

            Utils::streamFor($this->xmlPacker->pack($rocket->getPayload()->all()))
        );
    }

    /**
     * @throws ContainerException
     * @throws InvalidConfigException
     * @throws InvalidParamsException
     * @throws ServiceNotFoundException
     * @throws \Exception
     */
    protected function v3(Rocket $rocket): RequestInterface
    {
        $timestamp = time();
        $random = Str::random(32);
        $body = $this->v3PayloadToString($rocket->getPayload());
        $contents = $this->v3GetContents($rocket, $timestamp, $random);
        $authorization = $this->v3GetWechatAuthorization($rocket->getParams(), $timestamp, $random, $contents);
        $radar = $rocket->getRadar()->withHeader('Authorization', $authorization);

        if (!empty($rocket->getParams()['_serial_no'])) {
            $radar = $radar->withHeader('Wechatpay-Serial', $rocket->getParams()['_serial_no']);
        }

        if (!empty($body)) {
            $radar = $radar->withBody(Utils::streamFor($body));
        }

        return $radar;

    }

    /**
     * @throws ContainerException
     * @throws InvalidConfigException
     * @throws ServiceNotFoundException
     */
    protected function v3GetWechatAuthorization(array $params, int $timestamp, string $random, string $contents): string
    {
        $config = get_wechat_config($params);
        $mchPublicCertPath = $config['mch_public_cert_path'] ?? null;

        if (empty($mchPublicCertPath)) {
            throw new InvalidConfigException(Exception::WECHAT_CONFIG_ERROR, 'Missing Wechat Config -- [mch_public_cert_path]');
        }

        $ssl = openssl_x509_parse(get_public_cert($mchPublicCertPath));

        if (empty($ssl['serialNumberHex'])) {
            throw new InvalidConfigException(Exception::WECHAT_CONFIG_ERROR, 'Parse [mch_public_cert_path] Serial Number Error');
        }

        $auth = sprintf(
            'mchid="%s",nonce_str="%s",timestamp="%d",serial_no="%s",signature="%s"',
            $config['mch_id'] ?? '',
            $random,
            $timestamp,
            $ssl['serialNumberHex'],
            get_wechat_sign($params, $contents),
        );

        return 'WECHATPAY2-SHA256-RSA2048 '.$auth;
    }

    /**
     * @throws InvalidParamsException
     */
    protected function v3GetContents(Rocket $rocket, int $timestamp, string $random): string
    {
        $request = $rocket->getRadar();

        if (is_null($request)) {
            throw new InvalidParamsException(Exception::REQUEST_NULL_ERROR);
        }

        $uri = $request->getUri();

        return $request->getMethod()."\n".
            $uri->getPath().(empty($uri->getQuery()) ? '' : '?'.$uri->getQuery())."\n".
            $timestamp."\n".
            $random."\n".
            $this->v3PayloadToString($rocket->getPayload())."\n";
    }

    protected function v3PayloadToString(?Collection $payload): string
    {
        return (is_null($payload) || 0 === $payload->count()) ? '' : $this->jsonPacker->pack($payload->all());
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Yansongda\Pay\Plugin\Wechat;
6
7			use Closure;
8			use GuzzleHttp\Psr7\Utils;
9			use Psr\Http\Message\RequestInterface;
10			use Yansongda\Pay\Contract\PluginInterface;
11			use Yansongda\Pay\Exception\ContainerException;
12			use Yansongda\Pay\Exception\Exception;
13			use Yansongda\Pay\Exception\InvalidConfigException;
14			use Yansongda\Pay\Exception\InvalidParamsException;
15			use Yansongda\Pay\Exception\ServiceNotFoundException;
16			use Yansongda\Pay\Logger;
17			use Yansongda\Pay\Packer\JsonPacker;
18			use Yansongda\Pay\Packer\XmlPacker;
19			use Yansongda\Pay\Rocket;
20			use Yansongda\Supports\Collection;
21			use Yansongda\Supports\Str;
22
23			use function Yansongda\Pay\get_public_cert;
24			use function Yansongda\Pay\get_wechat_config;
25			use function Yansongda\Pay\get_wechat_sign;
26			use function Yansongda\Pay\get_wechat_sign_v2;
27
28			class RadarSignPlugin implements PluginInterface
29			{
30			protected JsonPacker $jsonPacker;
31
32			protected XmlPacker $xmlPacker;
33
34			public function __construct(JsonPacker $jsonPacker, XmlPacker $xmlPacker)
35			{
36			$this->jsonPacker = $jsonPacker;
37			$this->xmlPacker = $xmlPacker;
38			}
39
40			/**
41			* @throws ContainerException
42			* @throws InvalidConfigException
43			* @throws InvalidParamsException
44			* @throws ServiceNotFoundException
45			*/
46			public function assembly(Rocket $rocket, Closure $next): Rocket
47			{
48			Logger::debug('[wechat][RadarSignPlugin] 插件开始装载', ['rocket' => $rocket]);
49
50			switch ($rocket->getParams()['_version'] ?? 'default') {
51			case 'v2':
52			$radar = $this->v2($rocket);
53
54			break;
55
56			default:
57			$radar = $this->v3($rocket);
58
59			break;
60			}
61
62			$rocket->setRadar($radar);
63
64			Logger::info('[wechat][RadarSignPlugin] 插件装载完毕', ['rocket' => $rocket]);
65
66			return $next($rocket);
67			}
68
69			/**
70			* @throws ContainerException
71			* @throws ServiceNotFoundException
72			* @throws InvalidConfigException
73			* @throws \Exception
74			*/
75			protected function v2(Rocket $rocket): RequestInterface
76			{
77			$rocket->mergePayload(['nonce_str' => Str::random(32)]);
78			$rocket->mergePayload([
79			'sign' => get_wechat_sign_v2($rocket->getParams(), $rocket->getPayload()->all()),
80			]);
81
82			return $rocket->getRadar()->withBody(
			0 ignored issues – show Bug Best Practice introduced 2023-03-19 13:35 UTC by Report Bug Copy Issue Report The expression `return $rocket->getRadar...>getPayload()->all())))` could return the type `null` which is incompatible with the type-hinted return `Psr\Http\Message\RequestInterface`. Consider adding an additional type-check to rule them out. Loading history...
83			Utils::streamFor($this->xmlPacker->pack($rocket->getPayload()->all()))
84			);
85			}
86
87			/**
88			* @throws ContainerException
89			* @throws InvalidConfigException
90			* @throws InvalidParamsException
91			* @throws ServiceNotFoundException
92			* @throws \Exception
93			*/
94			protected function v3(Rocket $rocket): RequestInterface
95			{
96			$timestamp = time();
97			$random = Str::random(32);
98			$body = $this->v3PayloadToString($rocket->getPayload());
99			$contents = $this->v3GetContents($rocket, $timestamp, $random);
100			$authorization = $this->v3GetWechatAuthorization($rocket->getParams(), $timestamp, $random, $contents);
101			$radar = $rocket->getRadar()->withHeader('Authorization', $authorization);
102
103			if (!empty($rocket->getParams()['_serial_no'])) {
104			$radar = $radar->withHeader('Wechatpay-Serial', $rocket->getParams()['_serial_no']);
105			}
106
107			if (!empty($body)) {
108			$radar = $radar->withBody(Utils::streamFor($body));
109			}
110
111			return $radar;
			0 ignored issues – show Bug Best Practice introduced 2023-03-18 15:15 UTC by Report Bug Copy Issue Report The expression `return $radar` could return the type `null` which is incompatible with the type-hinted return `Psr\Http\Message\RequestInterface`. Consider adding an additional type-check to rule them out. Loading history...
112			}
113
114			/**
115			* @throws ContainerException
116			* @throws InvalidConfigException
117			* @throws ServiceNotFoundException
118			*/
119			protected function v3GetWechatAuthorization(array $params, int $timestamp, string $random, string $contents): string
120			{
121			$config = get_wechat_config($params);
122			$mchPublicCertPath = $config['mch_public_cert_path'] ?? null;
123
124			if (empty($mchPublicCertPath)) {
125			throw new InvalidConfigException(Exception::WECHAT_CONFIG_ERROR, 'Missing Wechat Config -- [mch_public_cert_path]');
126			}
127
128			$ssl = openssl_x509_parse(get_public_cert($mchPublicCertPath));
129
130			if (empty($ssl['serialNumberHex'])) {
131			throw new InvalidConfigException(Exception::WECHAT_CONFIG_ERROR, 'Parse [mch_public_cert_path] Serial Number Error');
132			}
133
134			$auth = sprintf(
135			'mchid="%s",nonce_str="%s",timestamp="%d",serial_no="%s",signature="%s"',
136			$config['mch_id'] ?? '',
137			$random,
138			$timestamp,
139			$ssl['serialNumberHex'],
140			get_wechat_sign($params, $contents),
141			);
142
143			return 'WECHATPAY2-SHA256-RSA2048 '.$auth;
144			}
145
146			/**
147			* @throws InvalidParamsException
148			*/
149			protected function v3GetContents(Rocket $rocket, int $timestamp, string $random): string
150			{
151			$request = $rocket->getRadar();
152
153			if (is_null($request)) {
154			throw new InvalidParamsException(Exception::REQUEST_NULL_ERROR);
155			}
156
157			$uri = $request->getUri();
158
159			return $request->getMethod()."\n".
160			$uri->getPath().(empty($uri->getQuery()) ? '' : '?'.$uri->getQuery())."\n".
161			$timestamp."\n".
162			$random."\n".
163			$this->v3PayloadToString($rocket->getPayload())."\n";
164			}
165
166			protected function v3PayloadToString(?Collection $payload): string
167			{
168			return (is_null($payload) \|\| 0 === $payload->count()) ? '' : $this->jsonPacker->pack($payload->all());
169			}
170			}
171

yansongda / pay

Pull Request — master (#772)

RadarSignPlugin::v2PayloadToString() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like