Lincable\Eloquent\Lincable

Complexity

Total Complexity

5

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getUrlField()	0	3	1
A	getMediaManager()	0	3	1
A	link()	0	6	1
A	bootLincable()	0	4	1
A	addLincableField()	0	6	1

<?php

namespace Lincable\Eloquent;

use Lincable\MediaManager;
use Illuminate\Container\Container;
use Lincable\Http\File\FileResolver;

trait Lincable
{
    /**
     * Boot the model statically.
     * 
     * @return void
     */
    public static function bootLincable()
    {
        static::creating(function ($model) {
            $model->addLincableFields();
        });
    }

    /**
     * Add the lincable fields to model fillables.
     * 
     * @return void
     */
    public function addLincableField()
    {
        // Get the model fillable fields.
        $fillables = $this->getFillable();

It seems like getFillable() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->fillable(array_merge($fillables, [$this->getUrlField()]));

It seems like fillable() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Link the model to a file.
     * 
     * @param  mixed $file
     * @return this
     */
    public function link($file)
    {
        // Resolve the file object to link the model. It can
        // be a symfony uploaded file or a file request, which 
        // is preferable for linking. 
        $file = FileResolver::resolve($file);

The assignment to $file is dead and can be removed.

    }

    /**
     * Return the url field to link the model.
     * 
     * @return string
     */
    public function getUrlField()
    {
        return config('lincable.models.url_field');

The expression return config('lincable.models.url_field') also could return the type array which is incompatible with the documented return type string.

    }

    /**
     * Return a media manager instance.
     * 
     * @return \Lincable\MediaManager
     */
    protected function getMediaManager() 
    {
        return Container::getInstance()->make(MediaManager::class);
    }
}