Lincable\Http\File\FileResolver::resolveSymfonyFile()

Complexity

Conditions	5
Paths	5

Size

Total Lines	22
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	5

Importance

Changes

0

<?php
    public static function resolveSymfonyFile($file)
    {
        if (is_string($file)) {
            return new SymfonyFile($file);
        }
            
        if ($file instanceof FileRequest) {
            return $file->prepareFile();

The expression return $file->prepareFile() also could return the type callable which is incompatible with the documented return type Symfony\Component\HttpFoundation\File\File.

        }
            
        if ($file instanceof UploadedFile) {
            return $file->move(
                FileFactory::getTemporaryDirectory(), 

Are you sure the usage of Lincable\Http\File\FileFactory::getTemporaryDirectory() targeting Lincable\Http\File\FileFactory::getTemporaryDirectory() seems to always return null.

Lincable\Http\File\FileFactory::getTemporaryDirectory() of type void is incompatible with the type string expected by parameter $directory of Symfony\Component\HttpFoundation\File\UploadedFile::move().

                $file->hashName()

The method hashName() does not exist on Symfony\Component\HttpFoundation\File\UploadedFile. Are you sure you never get this type here, but always one of the subclasses?

            );   
        }
        
        if ($file instanceof Symfonyfile) {
            return $file;
        }

        throw new NotResolvableFileException($file);
    }