Lincable\Http\File\FileFactory

Complexity

Total Complexity

7

Size/Duplication

Total Lines	75
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	extension()	0	3	1
A	fileName()	0	3	1
A	getTemporaryDirectory()	0	16	3
A	createTemporary()	0	18	2

<?php

namespace Lincable\Http\File;

use Illuminate\Http\File;

class FileFactory
{
    /**
     * Create a temporary file from specified original content.
     *
     * @param  mixed  $data
     * @param  string  $originalFileName
     * @param  mixed|null  $flags
     * @return void
     */
    public static function createTemporary(
        $data,
        string $originalFileName = null, 
        $flags = null
    ) {
        // Generate a temp file from configuration and file name.
        $filename = static::getTemporaryDirectory(

Are you sure the assignment to $filename is correct as static::getTemporaryDirectory(str_random() . '.' . static::extension($originalFileName)) targeting Lincable\Http\File\FileFactory::getTemporaryDirectory() seems to always return null.

            str_random().'.'.static::extension($originalFileName)

It seems like $originalFileName can also be of type null; however, parameter $filename of Lincable\Http\File\FileFactory::extension() does only seem to accept string, maybe add an additional type check?

        );

        file_put_contents($filename, $data, $flags);

$filename of type void is incompatible with the type string expected by parameter $filename of file_put_contents().

        
        // Handle stream resource.
        if (is_resource($data)) {
            fclose($data); 
        }

        return new File($filename);

$filename of type void is incompatible with the type string expected by parameter $path of Illuminate\Http\File::__construct().

The expression return new Illuminate\Http\File($filename) returns the type Illuminate\Http\File which is incompatible with the documented return type void.

    }

    /**
     * Return the extension from filename.
     *
     * @param  string  $filename
     * @return string
     */
    public static function extension(string $filename)
    {
        return pathinfo($filename, PATHINFO_EXTENSION);
    }

    /**
     * Return the file name from path.
     *
     * @param  string  $path
     * @return string
     */
    public static function fileName(string $path)
    {
        return pathinfo($path, PATHINFO_BASENAME);
    }

    /**
     * Return the configured temporary directory. You may pass
     * a file name to build some custom path.
     *
     * @param  string|null  $fileName
     * @return void
     */
    public static function getTemporaryDirectory(string $fileName = null)
    {
        $configuredTemp = config('lincable.temp_directory');

        $directory = str_finish(
            $configuredTemp === null 
                ? sys_get_temp_dir() 
                : (string) $configuredTemp, 
            DIRECTORY_SEPARATOR
        );
    
        if ($fileName) {
            return $directory.$fileName;

The expression return $directory . $fileName returns the type string which is incompatible with the documented return type void.

        }

        return $directory;

The expression return $directory returns the type string which is incompatible with the documented return type void.

    }
}