Complex classes like Builder often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Builder, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 20 | class Builder |
||
| 21 | { |
||
| 22 | /** |
||
| 23 | * @var Collection |
||
| 24 | */ |
||
| 25 | public $collection; |
||
| 26 | |||
| 27 | /** |
||
| 28 | * @var Repository |
||
| 29 | */ |
||
| 30 | public $config; |
||
| 31 | |||
| 32 | /** |
||
| 33 | * @var Factory |
||
| 34 | */ |
||
| 35 | public $view; |
||
| 36 | |||
| 37 | /** |
||
| 38 | * @var HtmlBuilder |
||
| 39 | */ |
||
| 40 | public $html; |
||
| 41 | |||
| 42 | /** |
||
| 43 | * @var UrlGenerator |
||
| 44 | */ |
||
| 45 | public $url; |
||
| 46 | |||
| 47 | /** |
||
| 48 | * @var FormBuilder |
||
| 49 | */ |
||
| 50 | public $form; |
||
| 51 | |||
| 52 | /** |
||
| 53 | * @var string|array |
||
| 54 | */ |
||
| 55 | protected $ajax = ''; |
||
| 56 | |||
| 57 | /** |
||
| 58 | * @var array |
||
| 59 | */ |
||
| 60 | protected $tableAttributes = ['class' => 'table', 'id' => 'dataTableBuilder']; |
||
| 61 | |||
| 62 | /** |
||
| 63 | * @var string |
||
| 64 | */ |
||
| 65 | protected $template = ''; |
||
| 66 | |||
| 67 | /** |
||
| 68 | * @var array |
||
| 69 | */ |
||
| 70 | protected $attributes = []; |
||
| 71 | |||
| 72 | /** |
||
| 73 | * Lists of valid DataTables Callbacks. |
||
| 74 | * |
||
| 75 | * @link https://datatables.net/reference/option/. |
||
| 76 | * @var array |
||
| 77 | */ |
||
| 78 | protected $validCallbacks = [ |
||
| 79 | 'createdRow', |
||
| 80 | 'drawCallback', |
||
| 81 | 'footerCallback', |
||
| 82 | 'formatNumber', |
||
| 83 | 'headerCallback', |
||
| 84 | 'infoCallback', |
||
| 85 | 'initComplete', |
||
| 86 | 'preDrawCallback', |
||
| 87 | 'rowCallback', |
||
| 88 | 'stateLoadCallback', |
||
| 89 | 'stateLoaded', |
||
| 90 | 'stateLoadParams', |
||
| 91 | 'stateSaveCallback', |
||
| 92 | 'stateSaveParams', |
||
| 93 | ]; |
||
| 94 | |||
| 95 | /** |
||
| 96 | * @param Repository $config |
||
| 97 | * @param Factory $view |
||
| 98 | * @param HtmlBuilder $html |
||
| 99 | * @param UrlGenerator $url |
||
| 100 | * @param FormBuilder $form |
||
| 101 | */ |
||
| 102 | public function __construct( |
||
| 116 | |||
| 117 | /** |
||
| 118 | * Generate DataTable javascript. |
||
| 119 | * |
||
| 120 | * @param null $script |
||
| 121 | * @param array $attributes |
||
| 122 | * @return string |
||
| 123 | */ |
||
| 124 | public function scripts($script = null, array $attributes = ['type' => 'text/javascript']) |
||
| 130 | |||
| 131 | /** |
||
| 132 | * Get generated raw scripts. |
||
| 133 | * |
||
| 134 | * @return string |
||
| 135 | */ |
||
| 136 | public function generateScripts() |
||
| 152 | |||
| 153 | /** |
||
| 154 | * Generate DataTables js parameters. |
||
| 155 | * |
||
| 156 | * @param array $attributes |
||
| 157 | * @return string |
||
| 158 | */ |
||
| 159 | public function parameterize($attributes = []) |
||
| 160 | { |
||
| 161 | $parameters = (new Parameters($attributes))->toArray(); |
||
| 162 | |||
| 163 | $values = []; |
||
| 164 | $replacements = []; |
||
| 165 | foreach ($parameters as $key => &$value) { |
||
| 166 | if (!is_array($value)) { |
||
| 167 | if (strpos($value, '$.') === 0) { |
||
| 168 | // Store function string. |
||
| 169 | $values[] = $value; |
||
| 170 | // Replace function string in $foo with a 'unique' special key. |
||
| 171 | $value = '%' . $key . '%'; |
||
| 172 | // Later on, we'll look for the value, and replace it. |
||
| 173 | $replacements[] = '"' . $value . '"'; |
||
| 174 | } |
||
| 175 | } |
||
| 176 | } |
||
| 177 | |||
| 178 | list($ajaxDataFunction, $parameters) = $this->encodeAjaxDataFunction($parameters); |
||
| 179 | list($columnFunctions, $parameters) = $this->encodeColumnFunctions($parameters); |
||
| 180 | list($callbackFunctions, $parameters) = $this->encodeCallbackFunctions($parameters); |
||
| 181 | |||
| 182 | $json = json_encode($parameters); |
||
| 183 | |||
| 184 | $json = str_replace($replacements, $values, $json); |
||
| 185 | |||
| 186 | $json = $this->decodeAjaxDataFunction($ajaxDataFunction, $json); |
||
| 187 | $json = $this->decodeColumnFunctions($columnFunctions, $json); |
||
| 188 | $json = $this->decodeCallbackFunctions($callbackFunctions, $json); |
||
| 189 | |||
| 190 | return $json; |
||
| 191 | } |
||
| 192 | |||
| 193 | /** |
||
| 194 | * Encode ajax data function param. |
||
| 195 | * |
||
| 196 | * @param array $parameters |
||
| 197 | * @return mixed |
||
| 198 | */ |
||
| 199 | protected function encodeAjaxDataFunction($parameters) |
||
| 200 | { |
||
| 201 | $ajaxData = ''; |
||
| 202 | if (isset($parameters['ajax']['data'])) { |
||
| 203 | $ajaxData = $parameters['ajax']['data']; |
||
| 204 | $parameters['ajax']['data'] = "#ajax_data#"; |
||
| 205 | } |
||
| 206 | |||
| 207 | return [$ajaxData, $parameters]; |
||
| 208 | } |
||
| 209 | |||
| 210 | /** |
||
| 211 | * Encode columns render function. |
||
| 212 | * |
||
| 213 | * @param array $parameters |
||
| 214 | * @return array |
||
| 215 | */ |
||
| 216 | protected function encodeColumnFunctions(array $parameters) |
||
| 217 | { |
||
| 218 | $columnFunctions = []; |
||
| 219 | foreach ($parameters['columns'] as $i => $column) { |
||
| 220 | unset($parameters['columns'][$i]['exportable']); |
||
| 221 | unset($parameters['columns'][$i]['printable']); |
||
| 222 | unset($parameters['columns'][$i]['footer']); |
||
| 223 | |||
| 224 | if (isset($column['render'])) { |
||
| 225 | $columnFunctions[$i] = $column['render']; |
||
| 226 | $parameters['columns'][$i]['render'] = "#column_function.{$i}#"; |
||
| 227 | } |
||
| 228 | } |
||
| 229 | |||
| 230 | return [$columnFunctions, $parameters]; |
||
| 231 | } |
||
| 232 | |||
| 233 | /** |
||
| 234 | * Encode DataTables callbacks function. |
||
| 235 | * |
||
| 236 | * @param array $parameters |
||
| 237 | * @return array |
||
| 238 | */ |
||
| 239 | protected function encodeCallbackFunctions(array $parameters) |
||
| 240 | { |
||
| 241 | $callbackFunctions = []; |
||
| 242 | foreach ($parameters as $key => $callback) { |
||
| 243 | if (in_array($key, $this->validCallbacks)) { |
||
| 244 | $callbackFunctions[$key] = $this->compileCallback($callback); |
||
| 245 | $parameters[$key] = "#callback_function.{$key}#"; |
||
| 246 | } |
||
| 247 | } |
||
| 248 | |||
| 249 | return [$callbackFunctions, $parameters]; |
||
| 250 | } |
||
| 251 | |||
| 252 | /** |
||
| 253 | * Compile DataTable callback value. |
||
| 254 | * |
||
| 255 | * @param mixed $callback |
||
| 256 | * @return mixed|string |
||
| 257 | */ |
||
| 258 | private function compileCallback($callback) |
||
| 259 | { |
||
| 260 | if (is_callable($callback)) { |
||
| 261 | return value($callback); |
||
| 262 | } elseif ($this->view->exists($callback)) { |
||
| 263 | return $this->view->make($callback)->render(); |
||
| 264 | } |
||
| 265 | |||
| 266 | return $callback; |
||
| 267 | } |
||
| 268 | |||
| 269 | /** |
||
| 270 | * Decode ajax data method. |
||
| 271 | * |
||
| 272 | * @param string $function |
||
| 273 | * @param string $json |
||
| 274 | * @return string |
||
| 275 | */ |
||
| 276 | protected function decodeAjaxDataFunction($function, $json) |
||
| 277 | { |
||
| 278 | return str_replace("\"#ajax_data#\"", $function, $json); |
||
| 279 | } |
||
| 280 | |||
| 281 | /** |
||
| 282 | * Decode columns render functions. |
||
| 283 | * |
||
| 284 | * @param array $columnFunctions |
||
| 285 | * @param string $json |
||
| 286 | * @return string |
||
| 287 | */ |
||
| 288 | protected function decodeColumnFunctions(array $columnFunctions, $json) |
||
| 289 | { |
||
| 290 | foreach ($columnFunctions as $i => $function) { |
||
| 291 | $json = str_replace("\"#column_function.{$i}#\"", $function, $json); |
||
| 292 | } |
||
| 293 | |||
| 294 | return $json; |
||
| 295 | } |
||
| 296 | |||
| 297 | /** |
||
| 298 | * Decode DataTables callbacks function. |
||
| 299 | * |
||
| 300 | * @param array $callbackFunctions |
||
| 301 | * @param string $json |
||
| 302 | * @return string |
||
| 303 | */ |
||
| 304 | protected function decodeCallbackFunctions(array $callbackFunctions, $json) |
||
| 305 | { |
||
| 306 | foreach ($callbackFunctions as $i => $function) { |
||
| 307 | $json = str_replace("\"#callback_function.{$i}#\"", $function, $json); |
||
| 308 | } |
||
| 309 | |||
| 310 | return $json; |
||
| 311 | } |
||
| 312 | |||
| 313 | /** |
||
| 314 | * Get javascript template to use. |
||
| 315 | * |
||
| 316 | * @return string |
||
| 317 | */ |
||
| 318 | protected function template() |
||
| 319 | { |
||
| 320 | return $this->view->make( |
||
| 321 | $this->template ?: $this->config->get('datatables.script_template', 'datatables::script') |
||
| 322 | )->render(); |
||
| 323 | } |
||
| 324 | |||
| 325 | /** |
||
| 326 | * Sets HTML table attribute(s). |
||
| 327 | * |
||
| 328 | * @param string|array $attribute |
||
| 329 | * @param mixed $value |
||
| 330 | * @return $this |
||
| 331 | */ |
||
| 332 | public function setTableAttribute($attribute, $value = null) |
||
| 333 | { |
||
| 334 | if (is_array($attribute)) { |
||
| 335 | $this->setTableAttributes($attribute); |
||
| 336 | } else { |
||
| 337 | $this->tableAttributes[$attribute] = $value; |
||
| 338 | } |
||
| 339 | |||
| 340 | return $this; |
||
| 341 | } |
||
| 342 | |||
| 343 | /** |
||
| 344 | * Sets multiple HTML table attributes at once. |
||
| 345 | * |
||
| 346 | * @param array $attributes |
||
| 347 | * @return $this |
||
| 348 | */ |
||
| 349 | public function setTableAttributes(array $attributes) |
||
| 350 | { |
||
| 351 | foreach ($attributes as $attribute => $value) { |
||
| 352 | $this->setTableAttribute($attribute, $value); |
||
| 353 | } |
||
| 354 | |||
| 355 | return $this; |
||
| 356 | } |
||
| 357 | |||
| 358 | /** |
||
| 359 | * Retrieves HTML table attribute value. |
||
| 360 | * |
||
| 361 | * @param string $attribute |
||
| 362 | * @return mixed |
||
| 363 | * @throws \Exception |
||
| 364 | */ |
||
| 365 | public function getTableAttribute($attribute) |
||
| 366 | { |
||
| 367 | if (!array_key_exists($attribute, $this->tableAttributes)) { |
||
| 368 | throw new \Exception("Table attribute '{$attribute}' does not exist."); |
||
| 369 | } |
||
| 370 | |||
| 371 | return $this->tableAttributes[$attribute]; |
||
| 372 | } |
||
| 373 | |||
| 374 | /** |
||
| 375 | * Add a column in collection using attributes. |
||
| 376 | * |
||
| 377 | * @param array $attributes |
||
| 378 | * @return $this |
||
| 379 | */ |
||
| 380 | public function addColumn(array $attributes) |
||
| 381 | { |
||
| 382 | $this->collection->push(new Column($attributes)); |
||
| 383 | |||
| 384 | return $this; |
||
| 385 | } |
||
| 386 | |||
| 387 | /** |
||
| 388 | * Add a Column object at the beginning of collection |
||
| 389 | * |
||
| 390 | * @param \Yajra\Datatables\Html\Column $column |
||
| 391 | * @return $this |
||
| 392 | */ |
||
| 393 | public function addBefore(Column $column) |
||
| 394 | { |
||
| 395 | $this->collection->prepend($column); |
||
| 396 | |||
| 397 | return $this; |
||
| 398 | } |
||
| 399 | |||
| 400 | /** |
||
| 401 | * Add a column at the beginning of collection using attributes. |
||
| 402 | * |
||
| 403 | * @param array $attributes |
||
| 404 | * @return $this |
||
| 405 | */ |
||
| 406 | public function addColumnBefore(array $attributes) |
||
| 407 | { |
||
| 408 | $this->collection->prepend(new Column($attributes)); |
||
| 409 | |||
| 410 | return $this; |
||
| 411 | } |
||
| 412 | |||
| 413 | /** |
||
| 414 | * Add a Column object in collection. |
||
| 415 | * |
||
| 416 | * @param \Yajra\Datatables\Html\Column $column |
||
| 417 | * @return $this |
||
| 418 | */ |
||
| 419 | public function add(Column $column) |
||
| 425 | |||
| 426 | /** |
||
| 427 | * Set datatables columns from array definition. |
||
| 428 | * |
||
| 429 | * @param array $columns |
||
| 430 | * @return $this |
||
| 431 | */ |
||
| 432 | public function columns(array $columns) |
||
| 433 | { |
||
| 434 | $this->collection = new Collection; |
||
| 435 | |||
| 436 | foreach ($columns as $key => $value) { |
||
| 437 | if (!is_a($value, Column::class)) { |
||
| 438 | if (is_array($value)) { |
||
| 439 | $attributes = array_merge(['name' => $key, 'data' => $key], $this->setTitle($key, $value)); |
||
| 440 | } else { |
||
| 456 | |||
| 457 | /** |
||
| 458 | * Set title attribute of an array if not set. |
||
| 459 | * |
||
| 460 | * @param string $title |
||
| 461 | * @param array $attributes |
||
| 462 | * @return array |
||
| 463 | */ |
||
| 464 | public function setTitle($title, array $attributes) |
||
| 472 | |||
| 473 | /** |
||
| 474 | * Convert string into a readable title. |
||
| 475 | * |
||
| 476 | * @param string $title |
||
| 477 | * @return string |
||
| 478 | */ |
||
| 479 | public function getQualifiedTitle($title) |
||
| 483 | |||
| 484 | /** |
||
| 485 | * Add a checkbox column. |
||
| 486 | * |
||
| 487 | * @param array $attributes |
||
| 488 | * @return $this |
||
| 489 | */ |
||
| 490 | public function addCheckbox(array $attributes = []) |
||
| 507 | |||
| 508 | /** |
||
| 509 | * Add a action column. |
||
| 510 | * |
||
| 511 | * @param array $attributes |
||
| 512 | * @return $this |
||
| 513 | */ |
||
| 514 | public function addAction(array $attributes = []) |
||
| 532 | |||
| 533 | /** |
||
| 534 | * Add a index column. |
||
| 535 | * |
||
| 536 | * @param array $attributes |
||
| 537 | * @return $this |
||
| 538 | */ |
||
| 539 | public function addIndex(array $attributes = []) |
||
| 558 | |||
| 559 | /** |
||
| 560 | * Setup ajax parameter for datatables pipeline plugin |
||
| 561 | * |
||
| 562 | * @param string $url |
||
| 563 | * @param string $pages |
||
| 564 | * @return $this |
||
| 565 | */ |
||
| 566 | public function pipeline($url, $pages) |
||
| 572 | |||
| 573 | /** |
||
| 574 | * Setup ajax parameter |
||
| 575 | * |
||
| 576 | * @param string|array $attributes |
||
| 577 | * @return $this |
||
| 578 | */ |
||
| 579 | public function ajax($attributes) |
||
| 585 | |||
| 586 | /** |
||
| 587 | * Generate DataTable's table html. |
||
| 588 | * |
||
| 589 | * @param array $attributes |
||
| 590 | * @param bool $drawFooter |
||
| 591 | * @return string |
||
| 592 | */ |
||
| 593 | public function table(array $attributes = [], $drawFooter = false) |
||
| 610 | |||
| 611 | /** |
||
| 612 | * Compile table headers and to support responsive extension. |
||
| 613 | * |
||
| 614 | * @return array |
||
| 615 | */ |
||
| 616 | private function compileTableHeaders() |
||
| 629 | |||
| 630 | /** |
||
| 631 | * Compile table footer contents. |
||
| 632 | * |
||
| 633 | * @return array |
||
| 634 | */ |
||
| 635 | private function compileTableFooter() |
||
| 644 | |||
| 645 | /** |
||
| 646 | * Configure DataTable's parameters. |
||
| 647 | * |
||
| 648 | * @param array $attributes |
||
| 649 | * @return $this |
||
| 650 | */ |
||
| 651 | public function parameters(array $attributes = []) |
||
| 657 | |||
| 658 | /** |
||
| 659 | * Set custom javascript template. |
||
| 660 | * |
||
| 661 | * @param string $template |
||
| 662 | * @return $this |
||
| 663 | */ |
||
| 664 | public function setTemplate($template) |
||
| 670 | |||
| 671 | /** |
||
| 672 | * Get collection of columns. |
||
| 673 | * |
||
| 674 | * @return \Illuminate\Support\Collection |
||
| 675 | */ |
||
| 676 | public function getColumns() |
||
| 680 | |||
| 681 | /** |
||
| 682 | * Remove column by name. |
||
| 683 | * |
||
| 684 | * @param array $names |
||
| 685 | * @return $this |
||
| 686 | */ |
||
| 687 | public function removeColumn(...$names) |
||
| 697 | |||
| 698 | /** |
||
| 699 | * Minify ajax url generated when using get request |
||
| 700 | * by deleting unnecessary url params. |
||
| 701 | * |
||
| 702 | * @param string $url |
||
| 703 | * @param string $script |
||
| 704 | * @param array $data |
||
| 705 | * @return $this |
||
| 706 | */ |
||
| 707 | public function minifiedAjax($url, $script = null, $data = []) |
||
| 727 | |||
| 728 | /** |
||
| 729 | * Make a data script to be appended on ajax request of dataTables. |
||
| 730 | * |
||
| 731 | * @param array $data |
||
| 732 | * @return string |
||
| 733 | */ |
||
| 734 | protected function makeDataScript(array $data) |
||
| 743 | } |
||
| 744 |
Since your code implements the magic getter
_get, this function will be called for any read access on an undefined variable. You can add the@propertyannotation to your class or interface to document the existence of this variable.If the property has read access only, you can use the @property-read annotation instead.
Of course, you may also just have mistyped another name, in which case you should fix the error.
See also the PhpDoc documentation for @property.