Issues in FractalServiceProvider.php (master) - Issues in master - yajra/laravel-datatables-fractal - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/FractalServiceProvider.php (2 issues)

Labels

Bug 2

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Yajra\DataTables;

use League\Fractal\Manager;
use Illuminate\Support\ServiceProvider;
use League\Fractal\Serializer\DataArraySerializer;
use Yajra\DataTables\Commands\TransformerMakeCommand;
use Yajra\DataTables\Transformers\FractalTransformer;

class FractalServiceProvider extends ServiceProvider
{
    /**
     * Indicates if loading of the provider is deferred.
     *
     * @var bool
     */
    protected $defer = false;

    /**
     * Bootstrap the application events.
     *
     * @return void
     */
    public function boot()
    {
        $this->mergeConfigFrom(__DIR__ . '/../config/datatables-fractal.php', 'datatables-fractal');
        $this->publishAssets();

        $this->registerMacro();
    }

    /**
     * Publish datatables assets.
     *
     * @return void
     */
    protected function publishAssets()
    {
        $this->publishes(
            [
            __DIR__ . '/../config/datatables-fractal.php' => config_path('datatables-fractal.php'),
            ], 'datatables-fractal'
        );
    }

    /**
     * Register DataTables macro methods.
     *
     * @return void
     */
    protected function registerMacro()
    {
        DataTableAbstract::macro(
            'setTransformer', function ($transformer) {
                $this->transformer = [$transformer];
class MyClass { }

$x = new MyClass();
$x->foo = true;

                return $this;
            }
        );

        DataTableAbstract::macro(
            'addTransformer', function ($transformer) {
                $this->transformer[] = $transformer;

                return $this;
            }
        );

        DataTableAbstract::macro(
            'setSerializer', function ($serializer) {
                $this->serializer = $serializer;
class MyClass { }

$x = new MyClass();
$x->foo = true;

                return $this;
            }
        );
    }

    /**
     * Register the service provider.
     *
     * @return void
     */
    public function register()
    {
        $this->app->singleton(
            'datatables.fractal', function () {
                $fractal = new Manager;
                $config  = $this->app['config'];
                $request = $this->app['request'];

                $includesKey = $config->get('datatables-fractal.includes', 'include');
                if ($request->get($includesKey)) {
                    $fractal->parseIncludes($request->get($includesKey));
                }

                $serializer = $config->get('datatables-fractal.serializer', DataArraySerializer::class);
                $fractal->setSerializer(new $serializer);

                return $fractal;
            }
        );

        $this->app->singleton(
            'datatables.transformer', function () {
                return new FractalTransformer($this->app->make('datatables.fractal'));
            }
        );

        $this->commands(
            [
                TransformerMakeCommand::class,
            ]
        );
    }

    /**
     * Get the services provided by the provider.
     *
     * @return array
     */
    public function provides()
    {
        return [
            'datatables.fractal',
            'datatables.transformer',
        ];
    }
}


1			<?php
2
3			namespace Yajra\DataTables;
4
5			use League\Fractal\Manager;
6			use Illuminate\Support\ServiceProvider;
7			use League\Fractal\Serializer\DataArraySerializer;
8			use Yajra\DataTables\Commands\TransformerMakeCommand;
9			use Yajra\DataTables\Transformers\FractalTransformer;
10
11			class FractalServiceProvider extends ServiceProvider
12			{
13			/**
14			* Indicates if loading of the provider is deferred.
15			*
16			* @var bool
17			*/
18			protected $defer = false;
19
20			/**
21			* Bootstrap the application events.
22			*
23			* @return void
24			*/
25			public function boot()
26			{
27			$this->mergeConfigFrom(__DIR__ . '/../config/datatables-fractal.php', 'datatables-fractal');
28			$this->publishAssets();
29
30			$this->registerMacro();
31			}
32
33			/**
34			* Publish datatables assets.
35			*
36			* @return void
37			*/
38			protected function publishAssets()
39			{
40			$this->publishes(
41			[
42			__DIR__ . '/../config/datatables-fractal.php' => config_path('datatables-fractal.php'),
43			], 'datatables-fractal'
44			);
45			}
46
47			/**
48			* Register DataTables macro methods.
49			*
50			* @return void
51			*/
52			protected function registerMacro()
53			{
54			DataTableAbstract::macro(
55			'setTransformer', function ($transformer) {
56			$this->transformer = [$transformer];
			0 ignored issues – show Bug introduced 2017-06-30 07:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `transformer` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
57
58			return $this;
59			}
60			);
61
62			DataTableAbstract::macro(
63			'addTransformer', function ($transformer) {
64			$this->transformer[] = $transformer;
65
66			return $this;
67			}
68			);
69
70			DataTableAbstract::macro(
71			'setSerializer', function ($serializer) {
72			$this->serializer = $serializer;
			0 ignored issues – show Bug introduced 2017-06-30 07:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `serializer` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
73
74			return $this;
75			}
76			);
77			}
78
79			/**
80			* Register the service provider.
81			*
82			* @return void
83			*/
84			public function register()
85			{
86			$this->app->singleton(
87			'datatables.fractal', function () {
88			$fractal = new Manager;
89			$config = $this->app['config'];
90			$request = $this->app['request'];
91
92			$includesKey = $config->get('datatables-fractal.includes', 'include');
93			if ($request->get($includesKey)) {
94			$fractal->parseIncludes($request->get($includesKey));
95			}
96
97			$serializer = $config->get('datatables-fractal.serializer', DataArraySerializer::class);
98			$fractal->setSerializer(new $serializer);
99
100			return $fractal;
101			}
102			);
103
104			$this->app->singleton(
105			'datatables.transformer', function () {
106			return new FractalTransformer($this->app->make('datatables.fractal'));
107			}
108			);
109
110			$this->commands(
111			[
112			TransformerMakeCommand::class,
113			]
114			);
115			}
116
117			/**
118			* Get the services provided by the provider.
119			*
120			* @return array
121			*/
122			public function provides()
123			{
124			return [
125			'datatables.fractal',
126			'datatables.transformer',
127			];
128			}
129			}
130

yajra / laravel-datatables-fractal

Issues (3)

Security Analysis no request data

src/FractalServiceProvider.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like