GateRegistrar::getPermissions() - Code Metrics - Inspection of "Bump v3.6.0 :rocket:" - yajra/laravel-acl - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 85d653...679971 )

by Arjay

created 2018-01-03 05:11 UTC

GateRegistrar::getPermissions() A

↳ Parent: GateRegistrar

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	12
rs	9.4285
cc	2
eloc	7
nc	2
nop	0

<?php

namespace Yajra\Acl;

use Illuminate\Contracts\Auth\Access\Gate as GateContract;
use Illuminate\Contracts\Cache\Repository;
use Illuminate\Support\Collection;
use Illuminate\Support\Str;
use Yajra\Acl\Models\Permission;

class GateRegistrar
{
    /**
     * @var GateContract
     */
    private $gate;

    /**
     * @var Repository
     */
    private $cache;

    /**
     * GateRegistrar constructor.
     *
     * @param GateContract $gate
     * @param Repository   $cache
     */
    public function __construct(GateContract $gate, Repository $cache)
    {
        $this->gate  = $gate;
        $this->cache = $cache;
    }

    /**
     * Handle permission gate registration.
     */
    public function register()
    {
        $this->getPermissions()->each(function (Permission $permission) {
            $ability = $permission->slug;
            $policy  = function ($user) use ($permission) {
                return $user->hasRole($permission->roles);
            };

            if (Str::contains($permission->slug, '@')) {
                $policy  = $permission->slug;
                $ability = $permission->name;
            }

            $this->gate->define($ability, $policy);
        });
    }

    /**
     * Get all permissions.
     *
     * @return Collection
     */
    protected function getPermissions()
    {
        try {
            return $this->cache->rememberForever('permissions.policies', function () {
                return Permission::with('roles')->get();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            });
        } catch (\Exception $exception) {
            $this->cache->forget('permissions.policies');

            return new Collection;
        }
    }
}


1			<?php
2
3			namespace Yajra\Acl;
4
5			use Illuminate\Contracts\Auth\Access\Gate as GateContract;
6			use Illuminate\Contracts\Cache\Repository;
7			use Illuminate\Support\Collection;
8			use Illuminate\Support\Str;
9			use Yajra\Acl\Models\Permission;
10
11			class GateRegistrar
12			{
13			/**
14			* @var GateContract
15			*/
16			private $gate;
17
18			/**
19			* @var Repository
20			*/
21			private $cache;
22
23			/**
24			* GateRegistrar constructor.
25			*
26			* @param GateContract $gate
27			* @param Repository $cache
28			*/
29			public function __construct(GateContract $gate, Repository $cache)
30			{
31			$this->gate = $gate;
32			$this->cache = $cache;
33			}
34
35			/**
36			* Handle permission gate registration.
37			*/
38			public function register()
39			{
40			$this->getPermissions()->each(function (Permission $permission) {
41			$ability = $permission->slug;
42			$policy = function ($user) use ($permission) {
43			return $user->hasRole($permission->roles);
44			};
45
46			if (Str::contains($permission->slug, '@')) {
47			$policy = $permission->slug;
48			$ability = $permission->name;
49			}
50
51			$this->gate->define($ability, $policy);
52			});
53			}
54
55			/**
56			* Get all permissions.
57			*
58			* @return Collection
59			*/
60			protected function getPermissions()
61			{
62			try {
63			return $this->cache->rememberForever('permissions.policies', function () {
64			return Permission::with('roles')->get();
			0 ignored issues – show Bug introduced 2016-08-19 04:44 UTC by Report Bug Copy Issue Report The method `get` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
65			});
66			} catch (\Exception $exception) {
67			$this->cache->forget('permissions.policies');
68
69			return new Collection;
70			}
71			}
72			}
73

yajra / laravel-acl

Push — master ( 85d653...679971 )

GateRegistrar::getPermissions() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like