Yajra\CMS\Http\Controllers\PermissionsController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	158
Duplicated Lines	25.32 %

Coupling/Cohesion

Components	2
Dependencies	7

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	index()	0	4	1
A	create()	0	8	1
A	store()	13	13	1
A	createResource()	0	7	1
A	storeResource()	0	13	2
A	edit()	0	6	1
A	update()	13	13	1
A	destroy()	14	14	3

<?php

namespace Yajra\CMS\Http\Controllers;

use Yajra\CMS\DataTables\PermissionsDataTable;
use Illuminate\Database\QueryException;
use Illuminate\Http\Request;
use Yajra\Acl\Models\Permission;
use Yajra\Acl\Models\Role;

class PermissionsController extends Controller
{
    /**
     * @var \Illuminate\Http\Request
     */
    protected $request;

    /**
     * Controller specific permission ability map.
     *
     * @var array
     */
    protected $customPermissionMap = [
        'createResource' => 'create',
        'storeResource'  => 'create',
    ];

    /**
     * PermissionsController constructor.
     *
     * @param \Illuminate\Http\Request $request
     */
    public function __construct(Request $request)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->request = $request;
        $this->authorizePermissionResource('permission');
    }

    /**
     * Display list of permissions.
     *
     * @param \Yajra\CMS\DataTables\PermissionsDataTable $dataTable
     * @return \Illuminate\Http\JsonResponse|\Illuminate\View\View
     */
    public function index(PermissionsDataTable $dataTable)
    {
        return $dataTable->render('administrator.permissions.index');
    }

    /**
     * Show permission form.
     *
     * @return \Illuminate\View\View
     */
    public function create()
    {
        $permission           = new Permission;
        $permission->resource = 'System';
        $roles                = Role::all();

        return view('administrator.permissions.create', compact('permission', 'roles'));
    }

    /**
     * Store a newly created permission.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store()

This method seems to be duplicated in your project.

    {
        $this->validate($this->request, [
            'name'     => 'required',
            'resource' => 'required|alpha_num',
            'slug'     => 'required|unique:permissions,slug',
        ]);

        $permission = Permission::create($this->request->all());
        $permission->syncRoles($this->request->get('roles', []));

        return redirect()->route('administrator.permissions.index');
    }

    /**
     * Create a permission resource form.
     *
     * @return \BladeView|bool|\Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function createResource()
    {
        $permission = new Permission;
        $roles      = Role::all();

        return view('administrator.permissions.create-resource', compact('permission', 'roles'));
    }

    /**
     * Store permission resource.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function storeResource()
    {
        $this->validate($this->request, [
            'resource' => 'required|alpha_num',
        ]);

        $permissions = Permission::createResource($this->request->resource);
        foreach ($permissions as $permission) {
            $permission->syncRoles($this->request->get('roles', []));
        }

        return redirect()->route('administrator.permissions.index');
    }

    /**
     * Show and edit selected permission.
     *
     * @param \Yajra\Acl\Models\Permission $permission
     * @return \Illuminate\View\View
     */
    public function edit(Permission $permission)
    {
        $roles = Role::all();

        return view('administrator.permissions.edit', compact('permission', 'roles'));
    }

    /**
     * Update selected permission.
     *
     * @param \Yajra\Acl\Models\Permission $permission
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update(Permission $permission)

This method seems to be duplicated in your project.

    {
        $this->validate($this->request, [
            'name'     => 'required',
            'resource' => 'required|alpha_num',
            'slug'     => 'required|unique:permissions,slug,' . $permission->id,
        ]);

        $permission->update($this->request->all());
        $permission->syncRoles($this->request->get('roles', []));

        return redirect()->route('administrator.permissions.index');
    }

    /**
     * Remove selected permission.
     *
     * @param \Yajra\Acl\Models\Permission $permission
     * @return \Illuminate\Http\RedirectResponse
     */
    public function destroy(Permission $permission)

This method seems to be duplicated in your project.

    {
        if (! $permission->system) {
            try {
                $permission->delete();

                return $this->notifySuccess('Permission successfully deleted!');
            } catch (QueryException $e) {
                return $this->notifyError($e->getMessage());
            }
        }

        return $this->notifyError('System permission is protected and cannot be deleted!');
    }
}