MenuItemsController - Code Metrics - Inspection of "Refactor view composer." - yajra/cms-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e5ba92...7a1e6c )

by Arjay

created 2016-06-20 06:22 UTC

MenuItemsController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	182
Duplicated Lines	9.89 %

Coupling/Cohesion

Components	3
Dependencies	14

Importance

Changes	5
Bugs	2	Features	1

Metric	Value
c	5
b	2
f	1
dl	18
loc	182
rs	10
wmc	15
lcom	3
cbo	14

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	index()	0	5	1
A	create()	7	7	1
A	store()	0	16	1
A	edit()	0	8	2
A	update()	0	20	2
A	destroy()	0	10	2
A	publish()	0	11	2
A	articles()	0	4	1
A	extensions()	11	11	2

How to fix Duplicated Code

<?php

namespace Yajra\CMS\Http\Controllers;

use App\Http\Requests;
use Baum\MoveNotPossibleException;
use Exception;
use Illuminate\Http\Request;
use Yajra\CMS\DataTables\ArticlesDataTable;
use Yajra\CMS\DataTables\MenuItemsDataTable;
use Yajra\CMS\Entities\Extension;
use Yajra\CMS\Entities\Menu;
use Yajra\CMS\Entities\Navigation;
use Yajra\CMS\Http\Requests\MenuItemsFormRequest;
use Yajra\CMS\Repositories\Extension\Repository;

class MenuItemsController extends Controller
{
    /**
     * Controller specific permission ability map.
     *
     * @var array
     */
    protected $customPermissionMap = [
        'publish'  => 'update',
        'articles' => 'view',
        'types'    => 'view',
    ];

    /**
     * @var \Yajra\CMS\Repositories\Extension\Repository
     */
    protected $extensions;

    /**
     * MenuItemsController constructor.
     *
     * @param \Yajra\CMS\Repositories\Extension\Repository $extensions
     */
    public function __construct(Repository $extensions)
    {
        $this->authorizePermissionResource('menu');
        $this->extensions = $extensions;

        view()->share('extensions', $this->extensions->all()->where('type', 'menu'));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * @param \Yajra\CMS\Entities\Navigation $navigation
     * @param \Yajra\CMS\DataTables\MenuItemsDataTable $dataTable
     * @return \Illuminate\Http\JsonResponse|\Illuminate\View\View
     */
    public function index(Navigation $navigation, MenuItemsDataTable $dataTable)
    {
        return $dataTable->forNavigation($navigation)
                         ->render('administrator.navigation.menu.index', compact('navigation'));
    }

    /**
     * @param \Yajra\CMS\Entities\Navigation $navigation
     * @param \Yajra\CMS\Entities\Menu $menu
     * @return mixed
     */
    public function create(Navigation $navigation, Menu $menu)

    {
        $menu->extension_id = old('extension_id', Extension::MENU_INTERNAL);
        $menu->load('extension');

        return view('administrator.navigation.menu.create', compact('navigation', 'menu'));
    }

    /**
     * @param \Yajra\CMS\Entities\Navigation $navigation
     * @param \Yajra\CMS\Http\Requests\MenuItemsFormRequest $request
     * @return mixed
     */
    public function store(Navigation $navigation, MenuItemsFormRequest $request)
    {
        $menu = new Menu();
        $menu->fill($request->all());
        $menu->published     = $request->get('published', false);
        $menu->authenticated = $request->get('authenticated', false);
        $navigation->menus()->save($menu);

        $menu->makeChildOf(Menu::query()->findOrFail($request->get('parent_id')));

        $menu->permissions()->sync($request->get('permissions', []));

        flash()->success(trans('cms::menu.store.success'));


        return redirect()->route('administrator.navigation.menu.index', $navigation->id);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @param \Yajra\CMS\Entities\Navigation $navigation
     * @param \Yajra\CMS\Entities\Menu $menu
     * @return mixed
     */
    public function edit(Navigation $navigation, Menu $menu)
    {
        if ($menu->isRoot()) {
            abort(404);
        }

        return view('administrator.navigation.menu.edit', compact('navigation', 'menu'));
    }

    /**
     * @param \Yajra\CMS\Entities\Navigation $navigation
     * @param \Yajra\CMS\Entities\Menu $menu
     * @param \Yajra\CMS\Http\Requests\MenuItemsFormRequest $request
     * @return mixed
     */
    public function update(Navigation $navigation, Menu $menu, MenuItemsFormRequest $request)
    {
        try {
            $menu->makeChildOf(Menu::query()->findOrFail($request->get('parent_id')));
        } catch (MoveNotPossibleException $e) {
            flash()->error(trans('cms::menu.update.move_error'));


            return back();
        }
        $menu->fill($request->all());
        $menu->published     = $request->get('published', false);
        $menu->authenticated = $request->get('authenticated', false);
        $navigation->menus()->save($menu);

        $menu->permissions()->sync($request->get('permissions', []));

        flash()->success(trans('cms::menu.update.success'));


        return redirect()->route('administrator.navigation.menu.index', $navigation->id);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @param \Yajra\CMS\Entities\Navigation $navigation
     * @param \Yajra\CMS\Entities\Menu $menu
     * @return string
     * @throws \Exception
     */
    public function destroy(Navigation $navigation, Menu $menu)
    {
        if ($menu->isRoot()) {
            abort(404);
        }

        $navigation->menus()->findOrFail($menu->id)->delete();

        return $this->notifySuccess(trans('cms::menu.destroy.success'));
    }

    /**
     * Publish/Unpublish a menu.
     *
     * @param \Yajra\CMS\Entities\Navigation $navigation
     * @param \Yajra\CMS\Entities\Menu $menu
     * @return \Illuminate\Http\JsonResponse
     */
    public function publish(Navigation $navigation, Menu $menu)
    {
        /** @var \Yajra\CMS\Entities\Menu $menu */
        $menu = $navigation->menus()->findOrFail($menu->id);
        $menu->togglePublishedState();

        return $this->notifySuccess(sprintf(
            'Menu successfully %s!',
            $menu->published ? 'published' : 'unpublished'
        ));
    }

    /**
     * Get articles list.
     *
     * @param \Yajra\CMS\DataTables\ArticlesDataTable $dataTable
     * @return \Illuminate\Http\JsonResponse
     */
    public function articles(ArticlesDataTable $dataTable)
    {
        return $dataTable->ajax();
    }

    /**
     * @param \Illuminate\Http\Request $request
     * @param \Yajra\CMS\Entities\Menu $menu
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View|string
     */
    public function extensions(Request $request, Menu $menu)

    {
        $extension = $this->extensions->findOrFail($request->query('key'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $template  = $extension->param('template');

        if (view()->exists($template)) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            return view($template, compact('menu'));
        }

        return '';
    }
}


Push — master ( e5ba92...7a1e6c )

MenuItemsController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

1		<?php
2
3		namespace Yajra\CMS\Http\Controllers;
4
5		use App\Http\Requests;
6		use Baum\MoveNotPossibleException;
7		use Exception;
8		use Illuminate\Http\Request;
9		use Yajra\CMS\DataTables\ArticlesDataTable;
10		use Yajra\CMS\DataTables\MenuItemsDataTable;
11		use Yajra\CMS\Entities\Extension;
12		use Yajra\CMS\Entities\Menu;
13		use Yajra\CMS\Entities\Navigation;
14		use Yajra\CMS\Http\Requests\MenuItemsFormRequest;
15		use Yajra\CMS\Repositories\Extension\Repository;
16
17		class MenuItemsController extends Controller
18		{
19		/**
20		* Controller specific permission ability map.
21		*
22		* @var array
23		*/
24		protected $customPermissionMap = [
25		'publish' => 'update',
26		'articles' => 'view',
27		'types' => 'view',
28		];
29
30		/**
31		* @var \Yajra\CMS\Repositories\Extension\Repository
32		*/
33		protected $extensions;
34
35		/**
36		* MenuItemsController constructor.
37		*
38		* @param \Yajra\CMS\Repositories\Extension\Repository $extensions
39		*/
40		public function __construct(Repository $extensions)
41		{
42		$this->authorizePermissionResource('menu');
43		$this->extensions = $extensions;
44
45		view()->share('extensions', $this->extensions->all()->where('type', 'menu'));
		0 ignored issues – show Bug introduced 2016-06-20 06:35 UTC by Report Bug Copy Issue Report The method `share` does only exist in `Illuminate\Contracts\View\Factory`, but not in `Illuminate\View\View`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
46		}
47
48		/**
49		* @param \Yajra\CMS\Entities\Navigation $navigation
50		* @param \Yajra\CMS\DataTables\MenuItemsDataTable $dataTable
51		* @return \Illuminate\Http\JsonResponse\|\Illuminate\View\View
52		*/
53		public function index(Navigation $navigation, MenuItemsDataTable $dataTable)
54		{
55		return $dataTable->forNavigation($navigation)
56		->render('administrator.navigation.menu.index', compact('navigation'));
57		}
58
59		/**
60		* @param \Yajra\CMS\Entities\Navigation $navigation
61		* @param \Yajra\CMS\Entities\Menu $menu
62		* @return mixed
63		*/
64	View Code Duplication	public function create(Navigation $navigation, Menu $menu)
		0 ignored issues – show Duplication introduced 2016-06-20 06:35 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
65		{
66		$menu->extension_id = old('extension_id', Extension::MENU_INTERNAL);
67		$menu->load('extension');
68
69		return view('administrator.navigation.menu.create', compact('navigation', 'menu'));
70		}
71
72		/**
73		* @param \Yajra\CMS\Entities\Navigation $navigation
74		* @param \Yajra\CMS\Http\Requests\MenuItemsFormRequest $request
75		* @return mixed
76		*/
77		public function store(Navigation $navigation, MenuItemsFormRequest $request)
78		{
79		$menu = new Menu();
80		$menu->fill($request->all());
81		$menu->published = $request->get('published', false);
82		$menu->authenticated = $request->get('authenticated', false);
83		$navigation->menus()->save($menu);
84
85		$menu->makeChildOf(Menu::query()->findOrFail($request->get('parent_id')));
86
87		$menu->permissions()->sync($request->get('permissions', []));
88
89		flash()->success(trans('cms::menu.store.success'));
		0 ignored issues – show Bug introduced 2016-06-20 06:35 UTC by Report Bug Copy Issue Report It seems like `trans('cms::menu.store.success')` targeting `trans()` can also be of type `object<Symfony\Component...on\TranslatorInterface>`; however, `Laracasts\Flash\FlashNotifier::success()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
90
91		return redirect()->route('administrator.navigation.menu.index', $navigation->id);
		0 ignored issues – show Documentation introduced 2016-06-13 15:10 UTC by Report Bug Copy Issue Report `$navigation->id` is of type `integer`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
92		}
93
94		/**
95		* @param \Yajra\CMS\Entities\Navigation $navigation
96		* @param \Yajra\CMS\Entities\Menu $menu
97		* @return mixed
98		*/
99		public function edit(Navigation $navigation, Menu $menu)
100		{
101		if ($menu->isRoot()) {
102		abort(404);
103		}
104
105		return view('administrator.navigation.menu.edit', compact('navigation', 'menu'));
106		}
107
108		/**
109		* @param \Yajra\CMS\Entities\Navigation $navigation
110		* @param \Yajra\CMS\Entities\Menu $menu
111		* @param \Yajra\CMS\Http\Requests\MenuItemsFormRequest $request
112		* @return mixed
113		*/
114		public function update(Navigation $navigation, Menu $menu, MenuItemsFormRequest $request)
115		{
116		try {
117		$menu->makeChildOf(Menu::query()->findOrFail($request->get('parent_id')));
118		} catch (MoveNotPossibleException $e) {
119		flash()->error(trans('cms::menu.update.move_error'));
		0 ignored issues – show Bug introduced 2016-06-20 06:35 UTC by Report Bug Copy Issue Report It seems like `trans('cms::menu.update.move_error')` targeting `trans()` can also be of type `object<Symfony\Component...on\TranslatorInterface>`; however, `Laracasts\Flash\FlashNotifier::error()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
120
121		return back();
122		}
123		$menu->fill($request->all());
124		$menu->published = $request->get('published', false);
125		$menu->authenticated = $request->get('authenticated', false);
126		$navigation->menus()->save($menu);
127
128		$menu->permissions()->sync($request->get('permissions', []));
129
130		flash()->success(trans('cms::menu.update.success'));
		0 ignored issues – show Bug introduced 2016-06-20 06:35 UTC by Report Bug Copy Issue Report It seems like `trans('cms::menu.update.success')` targeting `trans()` can also be of type `object<Symfony\Component...on\TranslatorInterface>`; however, `Laracasts\Flash\FlashNotifier::success()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
131
132		return redirect()->route('administrator.navigation.menu.index', $navigation->id);
		0 ignored issues – show Documentation introduced 2016-06-13 15:10 UTC by Report Bug Copy Issue Report `$navigation->id` is of type `integer`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
133		}
134
135		/**
136		* @param \Yajra\CMS\Entities\Navigation $navigation
137		* @param \Yajra\CMS\Entities\Menu $menu
138		* @return string
139		* @throws \Exception
140		*/
141		public function destroy(Navigation $navigation, Menu $menu)
142		{
143		if ($menu->isRoot()) {
144		abort(404);
145		}
146
147		$navigation->menus()->findOrFail($menu->id)->delete();
148
149		return $this->notifySuccess(trans('cms::menu.destroy.success'));
150		}
151
152		/**
153		* Publish/Unpublish a menu.
154		*
155		* @param \Yajra\CMS\Entities\Navigation $navigation
156		* @param \Yajra\CMS\Entities\Menu $menu
157		* @return \Illuminate\Http\JsonResponse
158		*/
159		public function publish(Navigation $navigation, Menu $menu)
160		{
161		/** @var \Yajra\CMS\Entities\Menu $menu */
162		$menu = $navigation->menus()->findOrFail($menu->id);
163		$menu->togglePublishedState();
164
165		return $this->notifySuccess(sprintf(
166		'Menu successfully %s!',
167		$menu->published ? 'published' : 'unpublished'
168		));
169		}
170
171		/**
172		* Get articles list.
173		*
174		* @param \Yajra\CMS\DataTables\ArticlesDataTable $dataTable
175		* @return \Illuminate\Http\JsonResponse
176		*/
177		public function articles(ArticlesDataTable $dataTable)
178		{
179		return $dataTable->ajax();
180		}
181
182		/**
183		* @param \Illuminate\Http\Request $request
184		* @param \Yajra\CMS\Entities\Menu $menu
185		* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View\|string
186		*/
187	View Code Duplication	public function extensions(Request $request, Menu $menu)
		0 ignored issues – show Duplication introduced 2016-06-20 06:35 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
188		{
189		$extension = $this->extensions->findOrFail($request->query('key'));
		0 ignored issues – show Documentation introduced 2016-06-20 06:35 UTC by Report Bug Copy Issue Report `$request->query('key')` is of type `string\|array`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
190		$template = $extension->param('template');
191
192		if (view()->exists($template)) {
		0 ignored issues – show Bug introduced 2016-06-13 15:10 UTC by Report Bug Copy Issue Report The method `exists` does only exist in `Illuminate\Contracts\View\Factory`, but not in `Illuminate\View\View`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
193		return view($template, compact('menu'));
194		}
195
196		return '';
197		}
198		}
199

yajra / cms-core

Push — master ( e5ba92...7a1e6c )

MenuItemsController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like