ImageBrowserController - Code Metrics - Inspection of "Dynamic imagefile browser." - yajra/cms-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a9a16a...2f2eb3 )

unknown

created 2016-07-26 06:34 UTC

ImageBrowserController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	57
Duplicated Lines	24.56 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	14
loc	57
rs	10
wmc	4
lcom	0
cbo	3

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getFiles()	0	7	1
A	uploadFile()	0	10	1
A	getMediaFiles()	14	14	2

How to fix Duplicated Code

<?php

namespace Yajra\CMS\Http\Controllers;

use App\Http\Controllers\Controller;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Illuminate\Http\Request;
use Yajra\CMS\Http\NotificationResponse;
use Symfony\Component\Finder\Finder;

/**
 * Class ImageBrowserController
 *
 * @package Yajra\CMS\Http\Controllers
 */
class ImageBrowserController extends Controller
{
    use NotificationResponse;

    /**
     * Get files by directory path.
     *
     * @param \Illuminate\Http\Request $request
     * @return array
     */
    public function getFiles(Request $request)
    {
        $path       = $request->get('path');
        $mediaFiles = $this->getMediaFiles($path);

        return view('administrator.file-browser.container', compact('mediaFiles', 'path'))->render();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Upload image file.
     *
     * @param \Illuminate\Http\Request $request
     * @return array
     */
    public function uploadFile(Request $request)
    {
        $this->validate($request, [
            'image' => 'required|image',
        ]);
        $filename = $request->file('image')->getClientOriginalName();
        $request->file('image')->move(storage_path($this->mediaPath . $request->get('directory') . '/'), $filename);

        return $this->notifySuccess('Image Successfully Uploaded!');
    }

    /**
     * Show all files on selected path.
     *
     * @param string $currentPath
     * @param array $mediaFiles
     * @return array
     */
    public function getMediaFiles($currentPath = null, $mediaFiles = [])

    {
        $path = storage_path('app/public/media' . $currentPath);
        foreach (Finder::create()->in($path)->sortByType()->depth(0) as $file) {
            $mediaFiles[] = [
                'filename' => $file->getFilename(),
                'realPath' => $file->getRealPath(),
                'type'     => $file->getType(),
                'filepath' => str_replace(storage_path('app/public/media'), '', $file->getRealPath()),
            ];
        }

        return $mediaFiles;
    }
}


1		<?php
2
3		namespace Yajra\CMS\Http\Controllers;
4
5		use App\Http\Controllers\Controller;
		0 ignored issues – show Bug introduced 2016-07-25 23:40 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Yajra\CMS\Http\Controllers\Controller`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
6		use Illuminate\Http\Request;
7		use Yajra\CMS\Http\NotificationResponse;
8		use Symfony\Component\Finder\Finder;
9
10		/**
11		* Class ImageBrowserController
12		*
13		* @package Yajra\CMS\Http\Controllers
14		*/
15		class ImageBrowserController extends Controller
16		{
17		use NotificationResponse;
18
19		/**
20		* Get files by directory path.
21		*
22		* @param \Illuminate\Http\Request $request
23		* @return array
24		*/
25		public function getFiles(Request $request)
26		{
27		$path = $request->get('path');
28		$mediaFiles = $this->getMediaFiles($path);
29
30		return view('administrator.file-browser.container', compact('mediaFiles', 'path'))->render();
		0 ignored issues – show Bug introduced 2016-07-25 23:40 UTC by Report Bug Copy Issue Report The method `render` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
31		}
32
33		/**
34		* Upload image file.
35		*
36		* @param \Illuminate\Http\Request $request
37		* @return array
38		*/
39		public function uploadFile(Request $request)
40		{
41		$this->validate($request, [
42		'image' => 'required\|image',
43		]);
44		$filename = $request->file('image')->getClientOriginalName();
45		$request->file('image')->move(storage_path($this->mediaPath . $request->get('directory') . '/'), $filename);
46
47		return $this->notifySuccess('Image Successfully Uploaded!');
48		}
49
50		/**
51		* Show all files on selected path.
52		*
53		* @param string $currentPath
54		* @param array $mediaFiles
55		* @return array
56		*/
57	View Code Duplication	public function getMediaFiles($currentPath = null, $mediaFiles = [])
		0 ignored issues – show Duplication introduced 2016-07-26 06:45 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58		{
59		$path = storage_path('app/public/media' . $currentPath);
60		foreach (Finder::create()->in($path)->sortByType()->depth(0) as $file) {
61		$mediaFiles[] = [
62		'filename' => $file->getFilename(),
63		'realPath' => $file->getRealPath(),
64		'type' => $file->getType(),
65		'filepath' => str_replace(storage_path('app/public/media'), '', $file->getRealPath()),
66		];
67		}
68
69		return $mediaFiles;
70		}
71		}
72

yajra / cms-core

Push — master ( a9a16a...2f2eb3 )

ImageBrowserController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like