ImageBrowserController::getImageFiles() - Code Metrics - Inspection of "Enhance image file viewing on image browser." - yajra/cms-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ddf4ad...b4622f )

unknown

created 2016-07-26 08:48 UTC

ImageBrowserController::getImageFiles() A

↳ Parent: ImageBrowserController

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	7
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	9
rs	9.6666

<?php

namespace Yajra\CMS\Http\Controllers;

use App\Http\Controllers\Controller;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Illuminate\Http\Request;
use Yajra\CMS\Http\NotificationResponse;
use Symfony\Component\Finder\Finder;

/**
 * Class ImageBrowserController
 *
 * @package Yajra\CMS\Http\Controllers
 */
class ImageBrowserController extends Controller
{
    use NotificationResponse;

    /**
     * Get files by directory path.
     *
     * @param \Illuminate\Http\Request $request
     * @return array
     */
    public function getFiles(Request $request)
    {
        $path       = $request->get('path');
        $mediaFiles = $this->getMediaFiles($path);

        return view('administrator.file-browser.container', compact('mediaFiles', 'path'))->render();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Upload image file.
     *
     * @param \Illuminate\Http\Request $request
     * @return array
     */
    public function uploadFile(Request $request)
    {
        $this->validate($request, [
            'file' => 'required|image',
        ]);
        $filename = $request->file('file')->getClientOriginalName();
        $request->file('file')
                ->move(storage_path('app/' . config('media.root_dir') . $request->get('directory') . '/'), $filename);

        return $this->notifySuccess('Image Successfully Uploaded!');
    }

    /**
     * Show all files on selected path.
     *
     * @param string $currentPath
     * @param array $mediaFiles
     * @return array
     */
    public function getMediaFiles($currentPath = null, $mediaFiles = [])
    {
        $path       = storage_path('app/public/media' . $currentPath);
        $imageFiles = $this->getImageFiles($path);

        foreach (Finder::create()->in($path)->sortByType()->directories() as $file) {
            $imageFiles->name($file->getBaseName());
        }

        foreach ($imageFiles as $file) {
            $mediaFiles[] = [
                'filename' => $file->getFilename(),
                'realPath' => $file->getRealPath(),
                'type'     => $file->getType(),
                'filepath' => str_replace(storage_path('app/public/media'), '', $file->getRealPath()),
            ];
        }

        return $mediaFiles;
    }

    /**
     * Get image files by path.
     *
     * @param string $path
     * @return Finder
     */
    private function getImageFiles($path)
    {
        return Finder::create()->in($path)->sortByType()
                     ->name('*.jpg')
                     ->name('*.jpeg')
                     ->name('*.png')
                     ->name('*.gif')
                     ->depth(0);
    }
}


1			<?php
2
3			namespace Yajra\CMS\Http\Controllers;
4
5			use App\Http\Controllers\Controller;
			0 ignored issues – show Bug introduced 2016-07-25 23:40 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Yajra\CMS\Http\Controllers\Controller`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
6			use Illuminate\Http\Request;
7			use Yajra\CMS\Http\NotificationResponse;
8			use Symfony\Component\Finder\Finder;
9
10			/**
11			* Class ImageBrowserController
12			*
13			* @package Yajra\CMS\Http\Controllers
14			*/
15			class ImageBrowserController extends Controller
16			{
17			use NotificationResponse;
18
19			/**
20			* Get files by directory path.
21			*
22			* @param \Illuminate\Http\Request $request
23			* @return array
24			*/
25			public function getFiles(Request $request)
26			{
27			$path = $request->get('path');
28			$mediaFiles = $this->getMediaFiles($path);
29
30			return view('administrator.file-browser.container', compact('mediaFiles', 'path'))->render();
			0 ignored issues – show Bug introduced 2016-07-25 23:40 UTC by Report Bug Copy Issue Report The method `render` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
31			}
32
33			/**
34			* Upload image file.
35			*
36			* @param \Illuminate\Http\Request $request
37			* @return array
38			*/
39			public function uploadFile(Request $request)
40			{
41			$this->validate($request, [
42			'file' => 'required\|image',
43			]);
44			$filename = $request->file('file')->getClientOriginalName();
45			$request->file('file')
46			->move(storage_path('app/' . config('media.root_dir') . $request->get('directory') . '/'), $filename);
47
48			return $this->notifySuccess('Image Successfully Uploaded!');
49			}
50
51			/**
52			* Show all files on selected path.
53			*
54			* @param string $currentPath
55			* @param array $mediaFiles
56			* @return array
57			*/
58			public function getMediaFiles($currentPath = null, $mediaFiles = [])
59			{
60			$path = storage_path('app/public/media' . $currentPath);
61			$imageFiles = $this->getImageFiles($path);
62
63			foreach (Finder::create()->in($path)->sortByType()->directories() as $file) {
64			$imageFiles->name($file->getBaseName());
65			}
66
67			foreach ($imageFiles as $file) {
68			$mediaFiles[] = [
69			'filename' => $file->getFilename(),
70			'realPath' => $file->getRealPath(),
71			'type' => $file->getType(),
72			'filepath' => str_replace(storage_path('app/public/media'), '', $file->getRealPath()),
73			];
74			}
75
76			return $mediaFiles;
77			}
78
79			/**
80			* Get image files by path.
81			*
82			* @param string $path
83			* @return Finder
84			*/
85			private function getImageFiles($path)
86			{
87			return Finder::create()->in($path)->sortByType()
88			->name('*.jpg')
89			->name('*.jpeg')
90			->name('*.png')
91			->name('*.gif')
92			->depth(0);
93			}
94			}
95

yajra / cms-core

Push — master ( ddf4ad...b4622f )

ImageBrowserController::getImageFiles() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like