Yajra\CMS\Http\Controllers\NavigationController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	126
Duplicated Lines	23.02 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	index()	0	4	1
A	create()	0	4	1
A	store()	15	15	1
A	edit()	0	4	1
A	update()	14	14	1
A	destroy()	0	6	1
A	publish()	0	9	2

<?php

namespace Yajra\CMS\Http\Controllers;

use Yajra\CMS\DataTables\NavigationDataTable;
use Yajra\CMS\Entities\Navigation;
use App\Http\Requests;
use Illuminate\Http\Request;

class NavigationController extends Controller
{
    /**
     * Controller specific permission ability map.
     *
     * @var array
     */
    protected $customPermissionMap = [
        'publish' => 'update',
    ];

    /**
     * NavigationController constructor.
     */
    public function __construct()
    {
        $this->authorizePermissionResource('navigation');
    }

    /**
     * Display list of navigation.
     *
     * @param \Yajra\CMS\DataTables\NavigationDataTable $dataTable
     * @return \Illuminate\Http\JsonResponse|\Illuminate\View\View
     */
    public function index(NavigationDataTable $dataTable)
    {
        return $dataTable->render('administrator.navigation.index');
    }

    /**
     * Show navigation form.
     *
     * @param \Yajra\CMS\Entities\Navigation $navigation
     * @return mixed
     */
    public function create(Navigation $navigation)
    {
        return view('administrator.navigation.create', compact('navigation'));
    }

    /**
     * Store a newly created navigation.
     *
     * @param \Illuminate\Http\Request $request
     * @return mixed
     */
    public function store(Request $request)

This method seems to be duplicated in your project.

    {
        $this->validate($request, [
            'title' => 'required|max:255',
            'type'  => 'required|max:255|alpha|unique:navigation,type',
        ]);

        $navigation = new Navigation;
        $navigation->fill($request->all());
        $navigation->published = $request->get('published', false);
        $navigation->save();
        flash()->success(trans('cms::navigation.store.success'));

It seems like trans('cms::navigation.store.success') targeting trans() can also be of type object<Illuminate\Contracts\Translation\Translator>; however, Laracasts\Flash\FlashNotifier::success() does only seem to accept string, maybe add an additional type check?

        return redirect()->route('administrator.navigation.index');
    }

    /**
     * Show and edit selected navigation.
     *
     * @param \Yajra\CMS\Entities\Navigation $navigation
     * @return mixed
     */
    public function edit(Navigation $navigation)
    {
        return view('administrator.navigation.edit', compact('navigation'));
    }

    /**
     * Update selected navigation.
     *
     * @param \Yajra\CMS\Entities\Navigation $navigation
     * @param \Illuminate\Http\Request $request
     * @return mixed
     */
    public function update(Navigation $navigation, Request $request)

This method seems to be duplicated in your project.

    {
        $this->validate($request, [
            'title' => 'required|max:255',
            'type'  => 'required|max:255|alpha|unique:navigation,type,' . $navigation->id,
        ]);

        $navigation->fill($request->all());
        $navigation->published = $request->get('published', false);
        $navigation->save();
        flash()->success(trans('cms::navigation.update.success'));

It seems like trans('cms::navigation.update.success') targeting trans() can also be of type object<Illuminate\Contracts\Translation\Translator>; however, Laracasts\Flash\FlashNotifier::success() does only seem to accept string, maybe add an additional type check?

        return redirect()->route('administrator.navigation.index');
    }

    /**
     * Remove selected navigation.
     *
     * @param \Yajra\CMS\Entities\Navigation $navigation
     * @return string
     * @throws \Exception
     */
    public function destroy(Navigation $navigation)
    {
        $navigation->delete();

        return $this->notifySuccess(trans('cms::navigation.destroy.success'));
    }

    /**
     * Publish/Unpublish a navigation.
     *
     * @param \Yajra\CMS\Entities\Navigation $navigation
     * @return \Illuminate\Http\JsonResponse
     */
    public function publish(Navigation $navigation)
    {
        $navigation->togglePublishedState();

        return $this->notifySuccess(sprintf(
            trans('cms::navigation.update.publish'),
            $navigation->published ? 'published' : 'unpublished'
        ));
    }
}