CategoryController   A
last analyzed

Complexity

Total Complexity 4

Size/Duplication

Total Lines 33
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 3

Importance

Changes 0
Metric Value
dl 0
loc 33
rs 10
c 0
b 0
f 0
wmc 4
lcom 0
cbo 3

1 Method

Rating   Name   Duplication   Size   Complexity  
B show() 0 23 4
1
<?php
2
3
namespace Yajra\CMS\Http\Controllers;
4
5
use App\Http\Controllers\Controller;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, Yajra\CMS\Http\Controllers\Controller.

Let’s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let’s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
6
use Illuminate\Http\Request;
7
use Yajra\CMS\Entities\Category;
8
use Yajra\CMS\Events\CategoryWasViewed;
9
10
class CategoryController extends Controller
11
{
12
    /**
13
     * Display an article.
14
     *
15
     * @param \Yajra\CMS\Entities\Category $category
16
     * @param \Illuminate\Http\Request $request
17
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
18
     */
19
    public function show(Category $category, Request $request)
20
    {
21
        $category->increment('hits');
22
23
        $layout   = $request->query('layout', 'blog');
24
        $limit    = $request->get('limit', $layout == 'list' ? 10 : 5);
25
        $articles = $category->articles()->latest()->simplePaginate($limit);
26
27
        $path = null;
28
        if ($layout === 'list') {
29
            $path .= '?layout=list';
30
            $articles->setPath($path);
31
        }
32
33
        if ($request->has('limit')) {
34
            $path .= '&limit=' . $limit;
35
            $articles->setPath($path);
36
        }
37
38
        event(new CategoryWasViewed($category));
39
40
        return view("category.$layout", compact('category', 'articles', 'limit'));
41
    }
42
}
43