Yajra\CMS\Http\Controllers\CategoriesController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	140
Duplicated Lines	14.29 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes	1
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	index()	0	4	1
A	create()	0	6	1
A	store()	10	10	1
A	edit()	0	8	2
A	update()	10	10	1
A	destroy()	0	14	3
A	publish()	0	18	2

<?php

namespace Yajra\CMS\Http\Controllers;

use Yajra\CMS\DataTables\CategoriesDataTable;
use Yajra\CMS\Entities\Category;
use Yajra\CMS\Http\Requests\CategoriesFormRequest;

class CategoriesController extends Controller
{
    /**
     * Controller specific permission ability map.
     *
     * @var array
     */
    protected $customPermissionMap = [
        'publish' => 'update',
    ];

    /**
     * CategoriesController constructor.
     */
    public function __construct()
    {
        $this->authorizePermissionResource('category');
    }

    /**
     * Display a listing of the resource.
     *
     * @param  \Yajra\CMS\DataTables\CategoriesDataTable $dataTable
     * @return \Illuminate\Http\Response
     */
    public function index(CategoriesDataTable $dataTable)
    {
        return $dataTable->render('administrator.categories.index');
    }

    /**
     * Show the form for creating a new resource.
     *
     * @param  \Yajra\CMS\Entities\Category $category
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function create(Category $category)
    {
        $category->published = true;

        return view('administrator.categories.create', compact('category'));
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Yajra\CMS\Http\Requests\CategoriesFormRequest $request
     * @param  \Yajra\CMS\Entities\Category $category
     * @return \Illuminate\Http\Response
     */
    public function store(CategoriesFormRequest $request, Category $category)

This method seems to be duplicated in your project.

    {
        $category->fill($request->all());
        $category->published     = $request->get('published', false);
        $category->authenticated = $request->get('authenticated', false);
        $category->save();
        flash()->success(trans('cms::categories.alert.success', ['stat' => 'Created']));

It seems like trans('cms::categories.alert.success', array('stat' => 'Created')) targeting trans() can also be of type object<Illuminate\Contracts\Translation\Translator>; however, Laracasts\Flash\FlashNotifier::success() does only seem to accept string, maybe add an additional type check?

        return redirect()->route('administrator.categories.index');
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \Yajra\CMS\Entities\Category $category
     * @return \Illuminate\Http\Response
     */
    public function edit(Category $category)
    {
        if ($category->isRoot()) {
            abort(404);
        }

        return view('administrator.categories.edit', compact('category'));
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  CategoriesFormRequest $request
     * @param  \Yajra\CMS\Entities\Category $category
     * @return \Illuminate\Http\Response
     */
    public function update(CategoriesFormRequest $request, Category $category)

This method seems to be duplicated in your project.

    {
        $category->fill($request->all());
        $category->published     = $request->get('published', false);
        $category->authenticated = $request->get('authenticated', false);
        $category->save();
        flash()->success(trans('cms::categories.alert.success', ['stat' => 'Updated']));

It seems like trans('cms::categories.alert.success', array('stat' => 'Updated')) targeting trans() can also be of type object<Illuminate\Contracts\Translation\Translator>; however, Laracasts\Flash\FlashNotifier::success() does only seem to accept string, maybe add an additional type check?

        return redirect()->route('administrator.categories.index');
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \Yajra\CMS\Entities\Category $category
     * @return \Illuminate\Http\JsonResponse
     */
    public function destroy(Category $category)
    {
        if ($category->isRoot()) {
            abort(404);
        }

        if ($category->has('articles')) {
            return $this->notifyError(trans('cms::categories.destroy.error'));
        }

        $category->delete();

        return $this->notifySuccess(trans('cms::categories.destroy.success'));
    }

    /**
     * Button Response from DataTable request to publish status.
     *
     * @param  \Yajra\CMS\Entities\Category $category
     * @return \Illuminate\Http\JsonResponse
     */
    public function publish(Category $category)
    {
        $category->togglePublishedState();

        $category->getDescendants()->each(
            function (Category $cat) use ($category) {
                $cat->published = $category->published;
                $cat->save();
            }
        );

        return $this->notifySuccess(
            sprintf(
                'Category successfully %s!',
                $category->published ? 'published' : 'unpublished'
            )
        );
    }
}