yahoojapan / ConfigCacheBundle

Tests/ConfigCache/Locale/Loader/ArrayLoaderTest.php

Doc Comments +7 added lines

@@ -86,6 +86,9 @@ 
         $this->assertSame('walkByLocaleInternal', $method->invoke($loader));
     }
 
+    /**
+     * @param string $name
+     */
     protected function createMock($name, array $methods = null)
     {
         $mock = $this->getMockBuilder($name)
@@ -97,6 +100,10 @@ 
         return $mock;
     }
 
+    /**
+     * @param string $name
+     * @param string $value
+     */
     protected function setProperty($instance, $name, $value)
     {
         $property = new \ReflectionProperty($instance, $name);

Tests/ConfigCache/Util/ArrayAccessTest.php

Doc Comments +4 added lines

@@ -145,6 +145,10 @@
         $this->assertEquals(new ArrayAccess($parameters), ArrayAccess::create($parameters));
     }
 
+    /**
+     * @param ArrayAccess $instance
+     * @param string $name
+     */
     protected function getProperty($instance, $name)
     {
         $property = new \ReflectionProperty($instance, $name);

Tests/ConfigCache/Locale/RegisterLocaleTest.php

Spacing +2 added lines, -2 removed lines

@@ -152,7 +152,7 @@ 
      */
     public function testCreateCacheDefinition()
     {
-        list($register, ) = $this->getRegisterMockAndContainerWithParameter();
+        list($register,) = $this->getRegisterMockAndContainerWithParameter();
         $id = 'register_test';
 
         // $register->bundleId = 'register_test'
@@ -194,7 +194,7 @@ 
             ->with($suffix)
             ->willReturn($expected)
             ;
-        $method   = new \ReflectionMethod($register, $methodName);
+        $method = new \ReflectionMethod($register, $methodName);
         $method->setAccessible(true);
         $this->assertSame($expected, $method->invoke($register));
     }

Tests/ConfigCache/Loader/LoaderTest.php

Spacing +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
     {
         $arrayLoader1 = $this->getMock('YahooJapan\ConfigCacheBundle\ConfigCache\Loader\ArrayLoaderInterface');
         $arrayLoader2 = $this->getMock('YahooJapan\ConfigCacheBundle\ConfigCache\Loader\ArrayLoaderInterface');
-        $loader      = $this->getMockForAbstractClass('YahooJapan\ConfigCacheBundle\ConfigCache\Loader\Loader');
+        $loader = $this->getMockForAbstractClass('YahooJapan\ConfigCacheBundle\ConfigCache\Loader\Loader');
         $loader->addLoaders(array($arrayLoader1, $arrayLoader2));
         $loaders = new \ReflectionProperty($loader, 'loaders');
         $loaders->setAccessible(true);

Tests/ConfigCache/Definition/ProcessorTest.php

Spacing +3 added lines, -3 removed lines

@@ -426,7 +426,7 @@ 
 
     protected function createNoChildNode()
     {
-        list($treeBuilder, ) = $this->createTreeBuilder();
+        list($treeBuilder,) = $this->createTreeBuilder();
 
         return $treeBuilder->buildTree();
     }
@@ -502,7 +502,7 @@ 
             ->children()
                 ->scalarNode('zzz')
                     ->validate()
-                        ->ifTrue(function ($v) {
+                        ->ifTrue(function($v) {
                             return !preg_match('/^[A-Z\/]+$/', $v);
                         })
                         ->thenInvalid('Unexpected node[%s]')
@@ -523,7 +523,7 @@ 
                 ->scalarNode('ccc')->end()
                 ->scalarNode('zzz')
                     ->validate()
-                        ->ifTrue(function ($v) {
+                        ->ifTrue(function($v) {
                             return !preg_match('/^[A-Z\/]+$/', $v);
                         })
                         ->thenInvalid('Unexpected node value[%s]')

Tests/ConfigCache/ConfigCacheTest.php

Spacing +3 added lines, -3 removed lines

@@ -130,7 +130,7 @@ 
         $expectedFileNames = array($expectedFileName, $this->getHashFileName($expectedFileName));
         $finder = Finder::create()
             ->files()
-            ->filter(function (\SplFileInfo $file) use ($expectedFileNames) {
+            ->filter(function(\SplFileInfo $file) use ($expectedFileNames) {
                 if (in_array($file->getFilename(), $expectedFileNames)) {
                     return true;
                 }
@@ -202,7 +202,7 @@ 
         $expectedFileNames = array($expectedFileName, $this->getHashFileName($expectedFileName));
         $finder = Finder::create()
             ->files()
-            ->filter(function (\SplFileInfo $file) use ($expectedFileNames) {
+            ->filter(function(\SplFileInfo $file) use ($expectedFileNames) {
                 if (in_array($file->getFilename(), $expectedFileNames)) {
                     return true;
                 }
@@ -470,7 +470,7 @@ 
      */
     public function testProcessConfiguration($validated, $validating, $expected)
     {
-        $configuration  = new ConfigCacheConfiguration();
+        $configuration = new ConfigCacheConfiguration();
         $method = new \ReflectionMethod(self::$cache, 'processConfiguration');
         $method->setAccessible(true);
         try {

Tests/ConfigCache/RegisterTest.php

Spacing +13 added lines, -13 removed lines

@@ -444,7 +444,7 @@ 
     public function testRegisterOneInternal($resources, $expectedDirs, $expectedFiles)
     {
         $internalMethod = 'setCacheDefinition';
-        list($register, ) = $this->getRegisterMockAndContainerWithParameter(array($internalMethod));
+        list($register,) = $this->getRegisterMockAndContainerWithParameter(array($internalMethod));
         $id = 'register_test';
 
         $bundleId = new \ReflectionProperty($register, 'bundleId');
@@ -529,7 +529,7 @@ 
     public function testRegisterAllInternal($bundles, $resources, $invokedCount, $expectedDirs, $expectedFiles)
     {
         $internalMethod = 'setCacheDefinition';
-        list($register, ) = $this->getRegisterMockAndContainerWithParameter(array($internalMethod));
+        list($register,) = $this->getRegisterMockAndContainerWithParameter(array($internalMethod));
 
         $registerResources = new \ReflectionProperty($register, 'resources');
         $registerResources->setAccessible(true);
@@ -772,7 +772,7 @@ 
      */
     public function testSetConfigurationByExtension($configuration, $expected)
     {
-        list($register, ) = $this->getRegisterMockAndContainer();
+        list($register,) = $this->getRegisterMockAndContainer();
         // mock of ConfigurationExtensionInterface in order to getConfiguration only
         $extension = $this->getMock('Symfony\Component\DependencyInjection\Extension\ConfigurationExtensionInterface');
         $extension
@@ -1336,7 +1336,7 @@ 
             ->with($suffix)
             ->willReturn($expected)
             ;
-        $method   = new \ReflectionMethod($register, $methodName);
+        $method = new \ReflectionMethod($register, $methodName);
         $method->setAccessible(true);
         $this->assertSame($expected, $method->invoke($register));
     }
@@ -1344,15 +1344,15 @@ 
     public function getIdProvider()
     {
         return array(
-            array('getYamlLoaderId',          'buildId',      'yaml_file_loader',  'config.yaml_file_loader'),
-            array('getXmlLoaderId',           'buildId',      'xml_file_loader',   'config.xml_file_loader'),
-            array('getLoaderResolverId',      'buildId',      'loader_resolver',   'config.loader_resolver'),
-            array('getDelegatingLoaderId',    'buildId',      'delegating_loader', 'config.delegatingloader'),
-            array('getPhpFileCacheClass',     'buildClassId', 'php_file_cache',    'config.php_file_cache.class'),
-            array('getConfigCacheClass',      'buildClassId', 'config_cache',      'config.config_cache.class'),
-            array('getYamlFileLoaderClass',   'buildClassId', 'yaml_file_loader',  'config.yaml_file_loader.class'),
-            array('getXmlFileLoaderClass',    'buildClassId', 'xml_file_loader',   'config.xml_file_loader.class'),
-            array('getLoaderResolverClass',   'buildClassId', 'loader_resolver',   'config.loader_resolver.class'),
+            array('getYamlLoaderId', 'buildId', 'yaml_file_loader', 'config.yaml_file_loader'),
+            array('getXmlLoaderId', 'buildId', 'xml_file_loader', 'config.xml_file_loader'),
+            array('getLoaderResolverId', 'buildId', 'loader_resolver', 'config.loader_resolver'),
+            array('getDelegatingLoaderId', 'buildId', 'delegating_loader', 'config.delegatingloader'),
+            array('getPhpFileCacheClass', 'buildClassId', 'php_file_cache', 'config.php_file_cache.class'),
+            array('getConfigCacheClass', 'buildClassId', 'config_cache', 'config.config_cache.class'),
+            array('getYamlFileLoaderClass', 'buildClassId', 'yaml_file_loader', 'config.yaml_file_loader.class'),
+            array('getXmlFileLoaderClass', 'buildClassId', 'xml_file_loader', 'config.xml_file_loader.class'),
+            array('getLoaderResolverClass', 'buildClassId', 'loader_resolver', 'config.loader_resolver.class'),
             array('getDelegatingLoaderClass', 'buildClassId', 'delegating_loader', 'config.delegatingloader.class'),
         );
     }

DependencyInjection/Configuration.php

Spacing +2 added lines, -2 removed lines

@@ -42,7 +42,7 @@ 
                             ->defaultValue(0)
                             ->validate()
                                 // priority must be less than LocaleListener priority
-                                ->ifTrue(function ($priority) {
+                                ->ifTrue(function($priority) {
                                     return $priority >= Configuration::getPriorityMax();
                                 })
                                 ->thenInvalid('ConfigCacheListener priority[%s] must be less than LocaleListener priority['.Configuration::getPriorityMax().']')
@@ -50,7 +50,7 @@ 
                         ->end()
                     ->end()
                     ->validate()
-                        ->ifTrue(function ($locale) {
+                        ->ifTrue(function($locale) {
                             return $locale['enabled'] && $locale['locales'] === array();
                         })
                         ->thenInvalid('yahoo_japan_config_cache.locale.locales must be configured.')

ConfigCache/Register.php

Spacing +1 added lines, -1 removed lines

@@ -251,7 +251,7 @@
     {
         $finder = Finder::create()
             ->files()
-            ->filter(function (\SplFileInfo $file) use ($excludes) {
+            ->filter(function(\SplFileInfo $file) use ($excludes) {
                 foreach ($excludes as $exclude) {
                     if (strpos($file->getRealPath(), $exclude) !== false) {
                         return false;