AuthController::guard() - Code Metrics - yabhq/flightdeck - Measure and Improve Code Quality continuously with Scrutinizer

AuthController::guard() A
last analyzed 2020-12-14 16:51 UTC

↳ Parent: AuthController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Yab\FlightDeck\Http\Controllers;

use Illuminate\Http\Request;
use Illuminate\Routing\Controller;
use Illuminate\Support\Facades\Auth;
use Yab\FlightDeck\Http\Requests\LoginRequest;

class AuthController extends Controller
{
    /**
     * Get a JWT via given credentials.
     *
     * @param LoginRequest $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function store(LoginRequest $request)
    {
        $credentials = $request->only(['email', 'password']);

        if (! $token = $this->guard()->attempt($credentials)) {
            return response()->json(['error' => 'Unauthorized'], 401);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        }

        return $this->respondWithToken($token);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Log the user out (Invalidate the token).
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function destroy()
    {
        $this->guard()->logout();

        return response()->json(['message' => 'Successfully logged out']);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Refresh a token.
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function update()
    {
        return $this->respondWithToken($this->guard()->refresh());

    }

    /**
     * Get the token array structure.
     *
     * @param  string $token
     *
     * @return \Illuminate\Http\JsonResponse
     */
    protected function respondWithToken($token)
    {
        return response()->json([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'access_token' => $token,
            'token_type' => 'bearer',
            'expires_in' => $this->guard()->factory()->getTTL() * 60

        ]);
    }

    /**
     * Get the guard to be used for login, logout and token refreshes.
     *
     * @return \Illuminate\Contracts\Auth\StatefulGuard
     */
    protected function guard()
    {
        return auth()->guard();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}

1			<?php
2
3			namespace Yab\FlightDeck\Http\Controllers;
4
5			use Illuminate\Http\Request;
6			use Illuminate\Routing\Controller;
7			use Illuminate\Support\Facades\Auth;
8			use Yab\FlightDeck\Http\Requests\LoginRequest;
9
10			class AuthController extends Controller
11			{
12			/**
13			* Get a JWT via given credentials.
14			*
15			* @param LoginRequest $request
16			* @return \Illuminate\Http\JsonResponse
17			*/
18			public function store(LoginRequest $request)
19			{
20			$credentials = $request->only(['email', 'password']);
21
22			if (! $token = $this->guard()->attempt($credentials)) {
23			return response()->json(['error' => 'Unauthorized'], 401);
			0 ignored issues – show Bug introduced 2019-04-05 22:32 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
24			}
25
26			return $this->respondWithToken($token);
			0 ignored issues – show Documentation introduced 2019-11-11 16:50 UTC by Report Bug Copy Issue Report `$token` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
27			}
28
29			/**
30			* Log the user out (Invalidate the token).
31			*
32			* @return \Illuminate\Http\JsonResponse
33			*/
34			public function destroy()
35			{
36			$this->guard()->logout();
37
38			return response()->json(['message' => 'Successfully logged out']);
			0 ignored issues – show Bug introduced 2019-04-05 22:32 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
39			}
40
41			/**
42			* Refresh a token.
43			*
44			* @return \Illuminate\Http\JsonResponse
45			*/
46			public function update()
47			{
48			return $this->respondWithToken($this->guard()->refresh());
			0 ignored issues – show Bug introduced 2019-11-11 16:50 UTC by Report Bug Copy Issue Report The method `refresh()` does not seem to exist on `object<Illuminate\Contracts\Auth\StatefulGuard>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
49			}
50
51			/**
52			* Get the token array structure.
53			*
54			* @param string $token
55			*
56			* @return \Illuminate\Http\JsonResponse
57			*/
58			protected function respondWithToken($token)
59			{
60			return response()->json([
			0 ignored issues – show Bug introduced 2019-04-05 22:32 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
61			'access_token' => $token,
62			'token_type' => 'bearer',
63			'expires_in' => $this->guard()->factory()->getTTL() * 60
			0 ignored issues – show Bug introduced 2019-11-11 16:50 UTC by Report Bug Copy Issue Report The method `factory()` does not seem to exist on `object<Illuminate\Contracts\Auth\StatefulGuard>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
64			]);
65			}
66
67			/**
68			* Get the guard to be used for login, logout and token refreshes.
69			*
70			* @return \Illuminate\Contracts\Auth\StatefulGuard
71			*/
72			protected function guard()
73			{
74			return auth()->guard();
			0 ignored issues – show Bug introduced 2019-11-11 16:50 UTC by Report Bug Copy Issue Report The method `guard` does only exist in `Illuminate\Contracts\Auth\Factory`, but not in `Illuminate\Contracts\Auth\Guard`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
75			}
76			}

yabhq / flightdeck

AuthController::guard() A last analyzed 2020-12-14 16:51 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

AuthController::guard() A
last analyzed 2020-12-14 16:51 UTC