Response::parsePaystackResponse() - Code Metrics - Inspection of "Rewrote logic for better unit testing" - yabacon/paystack-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 890e48...201e88 )

by Ibrahim

created 2017-01-30 06:23 UTC

Response::parsePaystackResponse() A

↳ Parent: Response

Complexity

Conditions	4
Paths	2

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	0
cts	7
cp	0
rs	9.2
c	0
b	0
f	0
cc	4
eloc	7
nc	2
nop	0
crap	20

<?php

namespace Yabacon\Paystack\Http;

use \Yabacon\Paystack\Exception\ApiException;

class Response
{
    public $okay;
    public $body;
    public $forApi;
    public $messages = [];

    private function parsePaystackResponse()
    {
        $resp = \json_decode($this->body);

        if (json_last_error() !== JSON_ERROR_NONE || !$resp->status) {
            throw new ApiException(
                "Paystack Request failed with response: '" .
                ((json_last_error() === JSON_ERROR_NONE) ? $resp->message : $this->body) . "'."
            );
        }

        return $resp;
    }

    private function implodedMessages()
    {
        return implode("\n\n", $this->messages);
    }

    public function wrapUp()
    {
        if ($this->okay && $this->forApi) {
            return $this->parsePaystackResponse();
        }
        if (!$this->okay && $this->forApi) {
            throw new Exception($this->implodedMessages());
        }
        if ($this->okay) {
            error_log($this->implodedMessages());
            return $this->body;
        }
        return false;
    }
}


1			<?php
2
3			namespace Yabacon\Paystack\Http;
4
5			use \Yabacon\Paystack\Exception\ApiException;
6
7			class Response
8			{
9			public $okay;
10			public $body;
11			public $forApi;
12			public $messages = [];
13
14			private function parsePaystackResponse()
15			{
16			$resp = \json_decode($this->body);
17
18			if (json_last_error() !== JSON_ERROR_NONE \|\| !$resp->status) {
19			throw new ApiException(
20			"Paystack Request failed with response: '" .
21			((json_last_error() === JSON_ERROR_NONE) ? $resp->message : $this->body) . "'."
22			);
23			}
24
25			return $resp;
26			}
27
28			private function implodedMessages()
29			{
30			return implode("\n\n", $this->messages);
31			}
32
33			public function wrapUp()
34			{
35			if ($this->okay && $this->forApi) {
36			return $this->parsePaystackResponse();
37			}
38			if (!$this->okay && $this->forApi) {
39			throw new Exception($this->implodedMessages());
40			}
41			if ($this->okay) {
42			error_log($this->implodedMessages());
43			return $this->body;
44			}
45			return false;
46			}
47			}
48

yabacon / paystack-php

Push — master ( 890e48...201e88 )

Response::parsePaystackResponse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like