Invoice - Code Metrics - Inspection of "Add More tests" - yabacon/paystack-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 200759...6ce54b )

by Ibrahim

created 2018-05-15 18:30 UTC

Invoice A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	121
Duplicated Lines	22.31 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	10
c	0
b	0
f	0
lcom	1
cbo	0
dl	27
loc	121
ccs	80
cts	80
cp	1
rs	10

10 Methods

Rating	Name	Duplication	Size	Complexity
A	root()	0	4	1
B	create()	0	28	1
A	fetch()	9	9	1
A	getList()	0	11	1
A	verify()	9	9	1
A	notify()	0	7	1
A	metrics()	0	7	1
A	finalize()	9	9	1
A	update()	0	18	1
A	archive()	0	7	1

How to fix Duplicated Code

<?php

namespace Yabacon\Paystack\Routes;

use Yabacon\Paystack\Contracts\RouteInterface;

class Invoice implements RouteInterface
{
    public static function root()
    {
        return '/paymentrequest';
    }

    public static function create()
    {
        return [
            RouteInterface::METHOD_KEY => RouteInterface::POST_METHOD,
            RouteInterface::ENDPOINT_KEY => Invoice::root(),
            RouteInterface::PARAMS_KEY => [
                'line_items',
                'description',
                'amount',
                'customer',
                'send_notification',
                'tax',
                'due_date',
                'metadata',
                'draft',
                'currency',
                'has_invoice',
                'invoice_number',
            ],
            RouteInterface::REQUIRED_KEY => [
                RouteInterface::PARAMS_KEY => [
                    'customer',
                    'amount',
                    'due_date',
                ],
            ],
        ];
    }

    public static function fetch()

    {
        return [
            RouteInterface::METHOD_KEY => RouteInterface::GET_METHOD,
            RouteInterface::ENDPOINT_KEY => Invoice::root() . '/{invoice_id_or_code}',
            RouteInterface::ARGS_KEY => ['invoice_id_or_code'],
            RouteInterface::REQUIRED_KEY => [RouteInterface::ARGS_KEY => ['invoice_id_or_code']],
        ];
    }

    public static function getList()
    {
        return [
            RouteInterface::METHOD_KEY => RouteInterface::GET_METHOD,
            RouteInterface::ENDPOINT_KEY => Invoice::root(),
            RouteInterface::PARAMS_KEY => [
                'currency',
                'customer', 'status', 'paid', 'include_archive',
            ],
        ];
    }

    public static function verify()

    {
        return [
            RouteInterface::METHOD_KEY => RouteInterface::GET_METHOD,
            RouteInterface::ENDPOINT_KEY => Invoice::root() . '/verify/{invoice_id_or_code}',
            RouteInterface::ARGS_KEY => ['invoice_id_or_code'],
            RouteInterface::REQUIRED_KEY => [RouteInterface::ARGS_KEY => ['invoice_id_or_code']],
        ];
    }

    public static function notify()
    {
        return [
            RouteInterface::METHOD_KEY => RouteInterface::POST_METHOD,
            RouteInterface::ENDPOINT_KEY => Invoice::root() . '/notify/{invoice_id_or_code}',
        ];
    }

    public static function metrics()
    {
        return [
            RouteInterface::METHOD_KEY => RouteInterface::GET_METHOD,
            RouteInterface::ENDPOINT_KEY => Invoice::root() . '/totals',
        ];
    }

    public static function finalize()

    {
        return [
            RouteInterface::METHOD_KEY => RouteInterface::POST_METHOD,
            RouteInterface::ENDPOINT_KEY => Invoice::root() . '/finalize/{invoice_id_or_code}',
            RouteInterface::ARGS_KEY => ['invoice_id_or_code'],
            RouteInterface::REQUIRED_KEY => [RouteInterface::ARGS_KEY => ['invoice_id_or_code']],
        ];
    }

    public static function update()
    {
        return [
            RouteInterface::METHOD_KEY => RouteInterface::PUT_METHOD,
            RouteInterface::ENDPOINT_KEY => Invoice::root() . '/update/{invoice_id_or_code}',
            RouteInterface::PARAMS_KEY => [
                'line_items',
                'description',
                'amount',
                'customer',
                'send_notification',
                'tax',
                'due_date',
                'metadata',
                'currency',
            ],
        ];
    }

    public static function archive()
    {
        return [
            RouteInterface::METHOD_KEY => RouteInterface::POST_METHOD,
            RouteInterface::ENDPOINT_KEY => Invoice::root() . '/archive/{invoice_id_or_code}',
        ];
    }
}


1			<?php
2
3			namespace Yabacon\Paystack\Routes;
4
5			use Yabacon\Paystack\Contracts\RouteInterface;
6
7			class Invoice implements RouteInterface
8			{
9	3		public static function root()
10			{
11	3		return '/paymentrequest';
12			}
13
14	2		public static function create()
15			{
16			return [
17	2		RouteInterface::METHOD_KEY => RouteInterface::POST_METHOD,
18	2		RouteInterface::ENDPOINT_KEY => Invoice::root(),
19	2		RouteInterface::PARAMS_KEY => [
20	2		'line_items',
21	2		'description',
22	2		'amount',
23	2		'customer',
24	2		'send_notification',
25	2		'tax',
26	2		'due_date',
27	2		'metadata',
28	2		'draft',
29	2		'currency',
30	2		'has_invoice',
31	2		'invoice_number',
32	2		],
33	2		RouteInterface::REQUIRED_KEY => [
34	2		RouteInterface::PARAMS_KEY => [
35	2		'customer',
36	2		'amount',
37	2		'due_date',
38	2		],
39	2		],
40	2		];
41			}
42
43	2	View Code Duplication	public static function fetch()
			0 ignored issues – show Duplication introduced 2016-04-30 23:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44			{
45			return [
46	2		RouteInterface::METHOD_KEY => RouteInterface::GET_METHOD,
47	2		RouteInterface::ENDPOINT_KEY => Invoice::root() . '/{invoice_id_or_code}',
48	2		RouteInterface::ARGS_KEY => ['invoice_id_or_code'],
49	2		RouteInterface::REQUIRED_KEY => [RouteInterface::ARGS_KEY => ['invoice_id_or_code']],
50	2		];
51			}
52
53	2		public static function getList()
54			{
55			return [
56	2		RouteInterface::METHOD_KEY => RouteInterface::GET_METHOD,
57	2		RouteInterface::ENDPOINT_KEY => Invoice::root(),
58	2		RouteInterface::PARAMS_KEY => [
59	2		'currency',
60	2		'customer', 'status', 'paid', 'include_archive',
61	2		],
62	2		];
63			}
64
65	2	View Code Duplication	public static function verify()
			0 ignored issues – show Duplication introduced 2018-05-15 18:32 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66			{
67			return [
68	2		RouteInterface::METHOD_KEY => RouteInterface::GET_METHOD,
69	2		RouteInterface::ENDPOINT_KEY => Invoice::root() . '/verify/{invoice_id_or_code}',
70	2		RouteInterface::ARGS_KEY => ['invoice_id_or_code'],
71	2		RouteInterface::REQUIRED_KEY => [RouteInterface::ARGS_KEY => ['invoice_id_or_code']],
72	2		];
73			}
74
75	2		public static function notify()
76			{
77			return [
78	2		RouteInterface::METHOD_KEY => RouteInterface::POST_METHOD,
79	2		RouteInterface::ENDPOINT_KEY => Invoice::root() . '/notify/{invoice_id_or_code}',
80	2		];
81			}
82
83	2		public static function metrics()
84			{
85			return [
86	2		RouteInterface::METHOD_KEY => RouteInterface::GET_METHOD,
87	2		RouteInterface::ENDPOINT_KEY => Invoice::root() . '/totals',
88	2		];
89			}
90
91	2	View Code Duplication	public static function finalize()
			0 ignored issues – show Duplication introduced 2018-05-15 18:32 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
92			{
93			return [
94	2		RouteInterface::METHOD_KEY => RouteInterface::POST_METHOD,
95	2		RouteInterface::ENDPOINT_KEY => Invoice::root() . '/finalize/{invoice_id_or_code}',
96	2		RouteInterface::ARGS_KEY => ['invoice_id_or_code'],
97	2		RouteInterface::REQUIRED_KEY => [RouteInterface::ARGS_KEY => ['invoice_id_or_code']],
98	2		];
99			}
100
101	2		public static function update()
102			{
103			return [
104	2		RouteInterface::METHOD_KEY => RouteInterface::PUT_METHOD,
105	2		RouteInterface::ENDPOINT_KEY => Invoice::root() . '/update/{invoice_id_or_code}',
106	2		RouteInterface::PARAMS_KEY => [
107	2		'line_items',
108	2		'description',
109	2		'amount',
110	2		'customer',
111	2		'send_notification',
112	2		'tax',
113	2		'due_date',
114	2		'metadata',
115	2		'currency',
116	2		],
117	2		];
118			}
119
120	2		public static function archive()
121			{
122			return [
123	2		RouteInterface::METHOD_KEY => RouteInterface::POST_METHOD,
124	2		RouteInterface::ENDPOINT_KEY => Invoice::root() . '/archive/{invoice_id_or_code}',
125	2		];
126			}
127			}
128

yabacon / paystack-php

Push — master ( 200759...6ce54b )

Invoice A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like