DBase::__construct() - Code Metrics - Inspection of "Bugfixing and switching to use Symfony Session com..." - yaIPAM/yaIPAM - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 93ed75...8dabb9 )

by Klaas

created 2017-06-16 13:05 UTC

DBase::__construct() B

↳ Parent: DBase

Complexity

Conditions	2
Paths	2

Size

Total Lines	37
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	28
nc	2
nop	1
dl	0
loc	37
ccs	0
cts	34
cp	0
crap	6
rs	8.8571
c	0
b	0
f	0

<?php
/**
 * Created by PhpStorm.
 * User: ktammling
 * Date: 16.06.17
 * Time: 14:56
 */

namespace Framework;

use Doctrine\ORM\Tools\Setup;
use Doctrine\ORM\EntityManager;
use Doctrine\DBAL\DriverManager;
use Doctrine\DBAL;
use SimpleThings\EntityAudit\AuditConfiguration;
use SimpleThings\EntityAudit\AuditManager;
use Doctrine\Common\EventManager;

class DBase {

    protected $dbal;
    protected $entityManager;

    public function __construct($Config)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        $dbal_config = new DBAL\Configuration();
        $this->dbal = DriverManager::getConnection($Config['dbase'], $dbal_config);
        $orm_config = Setup::createAnnotationMetadataConfiguration(array(SCRIPT_BASE.'/src/entities'), $Config['general']['devMode'], null, null, false);
        if (extension_loaded('apcu')) {
            $orm_config->setQueryCacheImpl(new \Doctrine\Common\Cache\ApcuCache());
            $orm_config->setMetadataCacheImpl(new \Doctrine\Common\Cache\ApcuCache());
            $orm_config->setResultCacheImpl(new \Doctrine\Common\Cache\ApcuCache());
        }
        $auditconfig = new AuditConfiguration();
        $auditconfig->setAuditedEntityClasses(array(
            'Entity\Addresses',
            'Entity\Prefixes',
            'Entity\User',
            'Entity\Vrfs'
        ));
        $auditconfig->setGlobalIgnoreColumns(array(
            'created_at',
            'updated_at'
        ));
        $auditconfig->setUsernameCallable(function() {
            return $_SESSION['Username'];
        });
        $evm = new EventManager();
        $auditManager = new AuditManager($auditconfig);
        $auditManager->registerEvents($evm);
        $EntityManager = EntityManager::create($Config['dbase'], $orm_config, $evm);
        $EntityManager->getConfiguration()->addCustomStringFunction('inet_aton', 'Application\DQL\InetAtonFunction');
        $EntityManager->getConfiguration()->addCustomStringFunction('inet6_aton', 'Application\DQL\Inet6AtonFunction');
        $EntityManager->getConfiguration()->addCustomStringFunction('MATCH_AGAINST', 'Application\DQL\MatchAgainstFunction');
        $this->entityManager = $EntityManager;

        return true;


    }

    /**
     * @return DBAL\Connection
     */
    public function getDbal()
    {
        return $this->dbal;
    }

    /**
     * @return EntityManager
     */
    public function getEntityManager()
    {
        return $this->entityManager;
    }



}

1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: ktammling
5			* Date: 16.06.17
6			* Time: 14:56
7			*/
8
9			namespace Framework;
10
11			use Doctrine\ORM\Tools\Setup;
12			use Doctrine\ORM\EntityManager;
13			use Doctrine\DBAL\DriverManager;
14			use Doctrine\DBAL;
15			use SimpleThings\EntityAudit\AuditConfiguration;
16			use SimpleThings\EntityAudit\AuditManager;
17			use Doctrine\Common\EventManager;
18
19			class DBase {
20
21			protected $dbal;
22			protected $entityManager;
23
24			public function __construct($Config)
			0 ignored issues – show Coding Style introduced 2017-06-16 13:09 UTC by Report Bug Copy Issue Report `__construct` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
25			{
26
27			$dbal_config = new DBAL\Configuration();
28			$this->dbal = DriverManager::getConnection($Config['dbase'], $dbal_config);
29			$orm_config = Setup::createAnnotationMetadataConfiguration(array(SCRIPT_BASE.'/src/entities'), $Config['general']['devMode'], null, null, false);
30			if (extension_loaded('apcu')) {
31			$orm_config->setQueryCacheImpl(new \Doctrine\Common\Cache\ApcuCache());
32			$orm_config->setMetadataCacheImpl(new \Doctrine\Common\Cache\ApcuCache());
33			$orm_config->setResultCacheImpl(new \Doctrine\Common\Cache\ApcuCache());
34			}
35			$auditconfig = new AuditConfiguration();
36			$auditconfig->setAuditedEntityClasses(array(
37			'Entity\Addresses',
38			'Entity\Prefixes',
39			'Entity\User',
40			'Entity\Vrfs'
41			));
42			$auditconfig->setGlobalIgnoreColumns(array(
43			'created_at',
44			'updated_at'
45			));
46			$auditconfig->setUsernameCallable(function() {
47			return $_SESSION['Username'];
48			});
49			$evm = new EventManager();
50			$auditManager = new AuditManager($auditconfig);
51			$auditManager->registerEvents($evm);
52			$EntityManager = EntityManager::create($Config['dbase'], $orm_config, $evm);
53			$EntityManager->getConfiguration()->addCustomStringFunction('inet_aton', 'Application\DQL\InetAtonFunction');
54			$EntityManager->getConfiguration()->addCustomStringFunction('inet6_aton', 'Application\DQL\Inet6AtonFunction');
55			$EntityManager->getConfiguration()->addCustomStringFunction('MATCH_AGAINST', 'Application\DQL\MatchAgainstFunction');
56			$this->entityManager = $EntityManager;
57
58			return true;
			0 ignored issues – show Bug introduced 2017-06-16 13:09 UTC by Report Bug Copy Issue Report Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct? Loading history...
59
60			}
61
62			/**
63			* @return DBAL\Connection
64			*/
65			public function getDbal()
66			{
67			return $this->dbal;
68			}
69
70			/**
71			* @return EntityManager
72			*/
73			public function getEntityManager()
74			{
75			return $this->entityManager;
76			}
77
78
79
80			}

yaIPAM / yaIPAM

Push — master ( 93ed75...8dabb9 )

DBase::__construct() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like