GameDeliveryTest::setUp() - Code Metrics - Inspection of "Game delivery" - xsolla/xsolla-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#25)

by Vitaliy

created 2016-01-12 13:41 UTC

GameDeliveryTest::setUp() B

↳ Parent: GameDeliveryTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	25
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	25
rs	8.8571
cc	1
eloc	16
nc	1
nop	0

<?php

namespace Xsolla\SDK\Tests\Integration\API;

/**
 * @group api
 */
class GameDeliveryTest extends AbstractAPITest
{
    private static $gameDeliveryEntityId;

    private static $gameDeliveryEntitySku;

    private $gameDeliveryEntityTemplate;

    public function setUp()
    {
        parent::setUp();
        $this->gameDeliveryEntityTemplate = array(
            'sku' => uniqid('sdk-test', true),
            'name' => array(
                'en' => 'sdk-test name-en',
            ),
            'description' => array(
                'en' => 'sdk-test description-en',
            ),
            'system_requirements' => 'sdk-test system_requirements',
            'default_currency' => 'USD',
            'drm' => array(
                array(
                    'id' => 1,
                    'platforms' => array(
                        array(
                            'id' => 1,
                        ),
                    ),
                ),
            ),
        );
    }

    public function testListGameDeliveryDrmPlatforms()
    {
        $response = $this->xsollaClient->ListGameDeliveryDrmPlatforms();
        static::assertArrayHasKey('platforms', $response);
        static::assertArrayHasKey('drm', $response);
    }

    public function testCreateGameDeliveryEntity()
    {
        $response = $this->xsollaClient->CreateGameDeliveryEntity(array(
            'project_id' => $this->projectId,
            'request' => $this->gameDeliveryEntityTemplate,
        ));
        static::assertArrayHasKey('id', $response);
        static::$gameDeliveryEntityId = $response['id'];
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
        static::$gameDeliveryEntitySku = $this->gameDeliveryEntityTemplate['sku'];
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
    }

    /**
     * @depends testCreateGameDeliveryEntity
     */
    public function testListGameDeliveryEntities()
    {
        $response = $this->xsollaClient->ListGameDeliveryEntities(array(
            'project_id' => $this->projectId,
        ));
        static::assertInternalType('array', $response);
        static::assertArrayHasKey('id', current($response));
    }

    /**
     * @depends testCreateGameDeliveryEntity
     */
    public function testGetGameDeliveryEntity()
    {
        $response = $this->xsollaClient->GetGameDeliveryEntity(array(
            'project_id' => $this->projectId,
            'game_delivery_id' => self::$gameDeliveryEntityId,
        ));
        static::assertSame(self::$gameDeliveryEntityId, $response['id']);
        static::assertSame(self::$gameDeliveryEntitySku, $response['sku']);
    }

    /**
     * @depends testCreateGameDeliveryEntity
     */
    public function testUpdateGameDeliveryEntity()
    {
        $this->xsollaClient->UpdateGameDeliveryEntity(array(
            'project_id' => $this->projectId,
            'game_delivery_id' => self::$gameDeliveryEntityId,
            'request' => $this->gameDeliveryEntityTemplate,
        ));
    }
}


1			<?php
2
3			namespace Xsolla\SDK\Tests\Integration\API;
4
5			/**
6			* @group api
7			*/
8			class GameDeliveryTest extends AbstractAPITest
9			{
10			private static $gameDeliveryEntityId;
11
12			private static $gameDeliveryEntitySku;
13
14			private $gameDeliveryEntityTemplate;
15
16			public function setUp()
17			{
18			parent::setUp();
19			$this->gameDeliveryEntityTemplate = array(
20			'sku' => uniqid('sdk-test', true),
21			'name' => array(
22			'en' => 'sdk-test name-en',
23			),
24			'description' => array(
25			'en' => 'sdk-test description-en',
26			),
27			'system_requirements' => 'sdk-test system_requirements',
28			'default_currency' => 'USD',
29			'drm' => array(
30			array(
31			'id' => 1,
32			'platforms' => array(
33			array(
34			'id' => 1,
35			),
36			),
37			),
38			),
39			);
40			}
41
42			public function testListGameDeliveryDrmPlatforms()
43			{
44			$response = $this->xsollaClient->ListGameDeliveryDrmPlatforms();
45			static::assertArrayHasKey('platforms', $response);
46			static::assertArrayHasKey('drm', $response);
47			}
48
49			public function testCreateGameDeliveryEntity()
50			{
51			$response = $this->xsollaClient->CreateGameDeliveryEntity(array(
52			'project_id' => $this->projectId,
53			'request' => $this->gameDeliveryEntityTemplate,
54			));
55			static::assertArrayHasKey('id', $response);
56			static::$gameDeliveryEntityId = $response['id'];
			0 ignored issues – show Bug introduced 2016-01-12 13:47 UTC by Report Bug Copy Issue Report Since `$gameDeliveryEntityId` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$gameDeliveryEntityId` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
57			static::$gameDeliveryEntitySku = $this->gameDeliveryEntityTemplate['sku'];
			0 ignored issues – show Bug introduced 2016-01-12 13:47 UTC by Report Bug Copy Issue Report Since `$gameDeliveryEntitySku` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$gameDeliveryEntitySku` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
58			}
59
60			/**
61			* @depends testCreateGameDeliveryEntity
62			*/
63			public function testListGameDeliveryEntities()
64			{
65			$response = $this->xsollaClient->ListGameDeliveryEntities(array(
66			'project_id' => $this->projectId,
67			));
68			static::assertInternalType('array', $response);
69			static::assertArrayHasKey('id', current($response));
70			}
71
72			/**
73			* @depends testCreateGameDeliveryEntity
74			*/
75			public function testGetGameDeliveryEntity()
76			{
77			$response = $this->xsollaClient->GetGameDeliveryEntity(array(
78			'project_id' => $this->projectId,
79			'game_delivery_id' => self::$gameDeliveryEntityId,
80			));
81			static::assertSame(self::$gameDeliveryEntityId, $response['id']);
82			static::assertSame(self::$gameDeliveryEntitySku, $response['sku']);
83			}
84
85			/**
86			* @depends testCreateGameDeliveryEntity
87			*/
88			public function testUpdateGameDeliveryEntity()
89			{
90			$this->xsollaClient->UpdateGameDeliveryEntity(array(
91			'project_id' => $this->projectId,
92			'game_delivery_id' => self::$gameDeliveryEntityId,
93			'request' => $this->gameDeliveryEntityTemplate,
94			));
95			}
96			}
97

xsolla / xsolla-sdk-php

Pull Request — master (#25)

GameDeliveryTest::setUp() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like