SubscriptionsTest - Code Metrics - Inspection of "Merge pull request #37 from xsolla/tests_improveme..." - xsolla/xsolla-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8bc6ad...b2c48e )

by Vitaliy

created 2016-06-09 23:33 UTC

SubscriptionsTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	182
Duplicated Lines	18.68 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	6
Bugs	1	Features	1

Metric	Value
wmc	15
c	6
b	1
f	1
lcom	1
cbo	2
dl	34
loc	182
rs	10

15 Methods

Rating	Name	Duplication	Size	Complexity
A	testUpdateSubscription()	0	4	1
A	testCreateSubscriptionPlan()	0	10	1
A	testListSubscriptionPlans()	0	7	1
A	testUpdateSubscriptionPlan()	0	9	1
A	testDisableSubscriptionPlan()	0	7	1
A	testEnableSubscriptionPlan()	0	7	1
A	testDeleteSubscriptionPlan()	0	7	1
A	testCreateSubscriptionProduct()	9	9	1
A	testUpdateSubscriptionProduct()	9	9	1
A	testDeleteSubscriptionProduct()	0	7	1
A	testListSubscriptionProducts()	0	7	1
A	testListSubscriptions()	8	8	1
A	testListUserSubscriptionPayments()	8	8	1
A	testListSubscriptionPayments()	0	7	1
A	testListSubscriptionCurrencies()	0	7	1

How to fix Duplicated Code

<?php

namespace Xsolla\SDK\Tests\Integration\API;

/**
 * @group api
 */
class SubscriptionsTest extends AbstractAPITest
{
    protected static $planId;

    protected static $productId;

    protected $plan = array(
        'name' => array(
            'en' => 'Subscription Plan Name',
        ),
        'group_id' => 'group_id',
        'charge' => array(
            'amount' => 1,
            'currency' => 'USD',
            'period' => array(
                'value' => 1,
                'type' => 'month',
            ),
        ),
        'expiration' => array(
            'value' => 3,
            'type' => 'month',
        ),
    );

    protected $product = array(
        'name' => 'Product Name',
        'group_id' => 'group_id',
    );

    public function testCreateSubscriptionPlan()
    {
        $response = static::$xsollaClient->CreateSubscriptionPlan(array(
            'project_id' => static::$projectId,
            'request' => $this->plan,
        ));
        static::assertArrayHasKey('plan_id', $response);
        static::assertInternalType('integer', $response['plan_id']);
        static::$planId = $response['plan_id'];
    }

    /**
     * @depends testCreateSubscriptionPlan
     */
    public function testListSubscriptionPlans()
    {
        $response = static::$xsollaClient->ListSubscriptionPlans(array(
            'project_id' => static::$projectId,
        ));
        static::assertInternalType('array', $response);
    }

    /**
     * @depends testListSubscriptionPlans
     */
    public function testUpdateSubscriptionPlan()
    {
        $response = static::$xsollaClient->UpdateSubscriptionPlan(array(
            'project_id' => static::$projectId,
            'plan_id' => static::$planId,
            'request' => $this->plan,
        ));
        static::assertInternalType('array', $response);
    }

    /**
     * @depends testUpdateSubscriptionPlan
     */
    public function testDisableSubscriptionPlan()
    {
        static::$xsollaClient->DisableSubscriptionPlan(array(
            'project_id' => static::$projectId,
            'plan_id' => static::$planId,
        ));
    }

    /**
     * @depends testDisableSubscriptionPlan
     */
    public function testEnableSubscriptionPlan()
    {
        static::$xsollaClient->EnableSubscriptionPlan(array(
            'project_id' => static::$projectId,
            'plan_id' => static::$planId,
        ));
    }

    /**
     * @depends testEnableSubscriptionPlan
     */
    public function testDeleteSubscriptionPlan()
    {
        static::$xsollaClient->DeleteSubscriptionPlan(array(
            'project_id' => static::$projectId,
            'plan_id' => static::$planId,
        ));
    }

    /**
     * @depends testDeleteSubscriptionPlan
     */
    public function testCreateSubscriptionProduct()

    {
        $response = static::$xsollaClient->CreateSubscriptionProduct(array(
            'project_id' => static::$projectId,
            'request' => $this->product,
        ));
        static::assertArrayHasKey('product_id', $response);
        static::$productId = $response['product_id'];
    }

    /**
     * @depends testCreateSubscriptionProduct
     */
    public function testUpdateSubscriptionProduct()

    {
        $response = static::$xsollaClient->UpdateSubscriptionProduct(array(
            'project_id' => static::$projectId,
            'product_id' => static::$productId,
            'request' => $this->product,
        ));
        static::assertInternalType('array', $response);
    }

    /**
     * @depends testUpdateSubscriptionProduct
     */
    public function testDeleteSubscriptionProduct()
    {
        static::$xsollaClient->DeleteSubscriptionProduct(array(
            'project_id' => static::$projectId,
            'product_id' => static::$productId,
        ));
    }

    public function testListSubscriptionProducts()
    {
        $response = static::$xsollaClient->ListSubscriptionProducts(array(
            'project_id' => static::$projectId,
        ));
        static::assertInternalType('array', $response);
    }

    public function testUpdateSubscription()
    {
        static::markTestIncomplete('We haven\'t active subscriptions in test project.');
    }

    public function testListSubscriptions()

    {
        $response = static::$xsollaClient->ListSubscriptions(array(
            'project_id' => static::$projectId,
            'user_id' => static::$userId,
        ));
        static::assertInternalType('array', $response);
    }

    public function testListUserSubscriptionPayments()

    {
        $response = static::$xsollaClient->ListUserSubscriptionPayments(array(
            'project_id' => static::$projectId,
            'user_id' => static::$userId,
        ));
        static::assertInternalType('array', $response);
    }

    public function testListSubscriptionPayments()
    {
        $response = static::$xsollaClient->ListSubscriptionPayments(array(
            'project_id' => static::$projectId,
        ));
        static::assertInternalType('array', $response);
    }

    public function testListSubscriptionCurrencies()
    {
        $response = static::$xsollaClient->ListSubscriptionCurrencies(array(
            'project_id' => static::$projectId,
        ));
        static::assertInternalType('array', $response);
    }
}


1		<?php
2
3		namespace Xsolla\SDK\Tests\Integration\API;
4
5		/**
6		* @group api
7		*/
8		class SubscriptionsTest extends AbstractAPITest
9		{
10		protected static $planId;
11
12		protected static $productId;
13
14		protected $plan = array(
15		'name' => array(
16		'en' => 'Subscription Plan Name',
17		),
18		'group_id' => 'group_id',
19		'charge' => array(
20		'amount' => 1,
21		'currency' => 'USD',
22		'period' => array(
23		'value' => 1,
24		'type' => 'month',
25		),
26		),
27		'expiration' => array(
28		'value' => 3,
29		'type' => 'month',
30		),
31		);
32
33		protected $product = array(
34		'name' => 'Product Name',
35		'group_id' => 'group_id',
36		);
37
38		public function testCreateSubscriptionPlan()
39		{
40		$response = static::$xsollaClient->CreateSubscriptionPlan(array(
41		'project_id' => static::$projectId,
42		'request' => $this->plan,
43		));
44		static::assertArrayHasKey('plan_id', $response);
45		static::assertInternalType('integer', $response['plan_id']);
46		static::$planId = $response['plan_id'];
47		}
48
49		/**
50		* @depends testCreateSubscriptionPlan
51		*/
52		public function testListSubscriptionPlans()
53		{
54		$response = static::$xsollaClient->ListSubscriptionPlans(array(
55		'project_id' => static::$projectId,
56		));
57		static::assertInternalType('array', $response);
58		}
59
60		/**
61		* @depends testListSubscriptionPlans
62		*/
63		public function testUpdateSubscriptionPlan()
64		{
65		$response = static::$xsollaClient->UpdateSubscriptionPlan(array(
66		'project_id' => static::$projectId,
67		'plan_id' => static::$planId,
68		'request' => $this->plan,
69		));
70		static::assertInternalType('array', $response);
71		}
72
73		/**
74		* @depends testUpdateSubscriptionPlan
75		*/
76		public function testDisableSubscriptionPlan()
77		{
78		static::$xsollaClient->DisableSubscriptionPlan(array(
79		'project_id' => static::$projectId,
80		'plan_id' => static::$planId,
81		));
82		}
83
84		/**
85		* @depends testDisableSubscriptionPlan
86		*/
87		public function testEnableSubscriptionPlan()
88		{
89		static::$xsollaClient->EnableSubscriptionPlan(array(
90		'project_id' => static::$projectId,
91		'plan_id' => static::$planId,
92		));
93		}
94
95		/**
96		* @depends testEnableSubscriptionPlan
97		*/
98		public function testDeleteSubscriptionPlan()
99		{
100		static::$xsollaClient->DeleteSubscriptionPlan(array(
101		'project_id' => static::$projectId,
102		'plan_id' => static::$planId,
103		));
104		}
105
106		/**
107		* @depends testDeleteSubscriptionPlan
108		*/
109	View Code Duplication	public function testCreateSubscriptionProduct()
		0 ignored issues – show Duplication introduced 2015-12-08 10:43 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
110		{
111		$response = static::$xsollaClient->CreateSubscriptionProduct(array(
112		'project_id' => static::$projectId,
113		'request' => $this->product,
114		));
115		static::assertArrayHasKey('product_id', $response);
116		static::$productId = $response['product_id'];
117		}
118
119		/**
120		* @depends testCreateSubscriptionProduct
121		*/
122	View Code Duplication	public function testUpdateSubscriptionProduct()
		0 ignored issues – show Duplication introduced 2015-12-08 10:43 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
123		{
124		$response = static::$xsollaClient->UpdateSubscriptionProduct(array(
125		'project_id' => static::$projectId,
126		'product_id' => static::$productId,
127		'request' => $this->product,
128		));
129		static::assertInternalType('array', $response);
130		}
131
132		/**
133		* @depends testUpdateSubscriptionProduct
134		*/
135		public function testDeleteSubscriptionProduct()
136		{
137		static::$xsollaClient->DeleteSubscriptionProduct(array(
138		'project_id' => static::$projectId,
139		'product_id' => static::$productId,
140		));
141		}
142
143		public function testListSubscriptionProducts()
144		{
145		$response = static::$xsollaClient->ListSubscriptionProducts(array(
146		'project_id' => static::$projectId,
147		));
148		static::assertInternalType('array', $response);
149		}
150
151		public function testUpdateSubscription()
152		{
153		static::markTestIncomplete('We haven\'t active subscriptions in test project.');
154		}
155
156	View Code Duplication	public function testListSubscriptions()
		0 ignored issues – show Duplication introduced 2015-12-08 10:43 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
157		{
158		$response = static::$xsollaClient->ListSubscriptions(array(
159		'project_id' => static::$projectId,
160		'user_id' => static::$userId,
161		));
162		static::assertInternalType('array', $response);
163		}
164
165	View Code Duplication	public function testListUserSubscriptionPayments()
		0 ignored issues – show Duplication introduced 2015-12-08 10:43 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
166		{
167		$response = static::$xsollaClient->ListUserSubscriptionPayments(array(
168		'project_id' => static::$projectId,
169		'user_id' => static::$userId,
170		));
171		static::assertInternalType('array', $response);
172		}
173
174		public function testListSubscriptionPayments()
175		{
176		$response = static::$xsollaClient->ListSubscriptionPayments(array(
177		'project_id' => static::$projectId,
178		));
179		static::assertInternalType('array', $response);
180		}
181
182		public function testListSubscriptionCurrencies()
183		{
184		$response = static::$xsollaClient->ListSubscriptionCurrencies(array(
185		'project_id' => static::$projectId,
186		));
187		static::assertInternalType('array', $response);
188		}
189		}
190

xsolla / xsolla-sdk-php

Push — master ( 8bc6ad...b2c48e )

SubscriptionsTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

15 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like